[16.0][MIG] account_tax_balance: Migration to 16.0 by ramiadavid · Pull Request #937 · OCA/account-financial-reporting

ramiadavid · 2022-10-27T18:10:27Z

No description provided.

* Tests * PEP8 * Use invoice._convert_to_write(invoice._cache). This way, the onchange will be inheritable and will add here also the added values * better get_context_values * unify method compute_balance * open move lines linked to balance

Allow to explore all move lines Spanish translation Bugfixes Show negative lines too Show move type in account.move views Tests include new fields

ramiadavid · 2022-10-27T18:18:28Z

Hi @pedrobaeza
The tests are fine, but I'm not 100% sure if the change from internal_type to account_type is correct, if you can check it.
Thank you

tafaRU

Overall LGTM except for ramiadavid#1
--edit--: please also squash administrative commits (if any) with the previous commit for reducing commit noise.

Thanks a lot!

eLBati

Tested

tafaRU · 2022-11-11T09:53:11Z

@ramiadavid thanks for merging my PR! Please also squash administrative commits, then your PR is ready for the merge 👍

pedrobaeza · 2022-11-11T10:25:46Z

/ocabot migration account_tax_balance

tafaRU · 2022-11-11T10:50:37Z

@ramiadavid let me know if you need help for merging the squash administrative commits.

pedrobaeza · 2022-11-11T10:54:26Z

I'm improving the guide for this. I'm pasting the link when finish.

ramiadavid · 2022-11-11T11:07:32Z

@ramiadavid let me know if you need help for merging the squash administrative commits.

If you can explain me how to do it correctly, I would appreciate it, because I don't want to do it wrong

pedrobaeza · 2022-11-11T11:38:48Z

Uf, it has taken more time than expected, but I hope they are good enough:

https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests

Please tell any suggestion to it.

* Test * README * add extra parent menu. If not, with the web_responsive module is mixed between other menus

Let the database do some computations (sum) and do not put large lists of ids in action domain.

This indexes improve the display time of account_tax_balance by a factor of 10 on a database with 1M move lines.

…ain freezes

Due to the change at odoo/odoo@15a1b3a it is now required to run tests that require CoA after install.

ramiadavid · 2022-11-11T13:02:58Z

@tafaRU @pedrobaeza I think it is ready

tafaRU · 2022-11-11T13:04:08Z

@ramiadavid you missed one:

pedrobaeza · 2022-11-11T13:05:09Z

I think that one of the cases where a conflict arises.

ramiadavid · 2022-11-11T13:05:50Z

@tafaRU I'm not sure how to do this, since it causes a conflict

pedrobaeza · 2022-11-11T13:06:40Z

@tafaRU can you please update your review?

pedrobaeza · 2022-11-11T13:15:48Z

/ocabot merge nobump

OCA-git-bot · 2022-11-11T13:15:55Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-937-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2022-11-11T13:19:32Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot · 2022-11-11T13:21:43Z

Congratulations, your PR was merged at 8ab16dd. Thanks a lot for contributing to OCA. ❤️

Gelo-fl · 2023-06-01T07:33:39Z

Hi @dreispt,

This module is merged, however the translations are locked:
account-financial-reporting-16.0-account_tax_balance
Can I know why?

Thanks in advance,

pedrobaeza · 2023-06-02T06:12:54Z

Unlocked.

eLBati and others added 5 commits October 20, 2022 22:11

[ADD] account_tax_balance: Compute tax balances based on date range

4c88180

tests

10384e3

[FIX+IMP] account_tax_balance:

473c54e

* Tests * PEP8 * Use invoice._convert_to_write(invoice._cache). This way, the onchange will be inheritable and will add here also the added values * better get_context_values * unify method compute_balance * open move lines linked to balance

Consider normal and refund operations separately

2bdeb1f

Allow to explore all move lines Spanish translation Bugfixes Show negative lines too Show move type in account.move views Tests include new fields

[MIG] account_tax_balance 10.0

e5f5ff2

ramiadavid mentioned this pull request Oct 27, 2022

Migration to version 16.0 #924

Open

7 tasks

ramiadavid force-pushed the 16.0-mig-account_tax_balance branch from 4328ed2 to 5cd930d Compare October 27, 2022 18:15

ramiadavid marked this pull request as ready for review October 27, 2022 18:18

TheMule71 mentioned this pull request Nov 2, 2022

[16.0] [MIG] l10n_it_account OCA/l10n-italy#2990

Merged

tafaRU mentioned this pull request Nov 11, 2022

Migration to version 16.0 OCA/l10n-italy#2967

Open

81 tasks

tafaRU requested changes Nov 11, 2022

View reviewed changes

eLBati approved these changes Nov 11, 2022

View reviewed changes

OCA-git-bot added this to the 16.0 milestone Nov 11, 2022

eLBati and others added 10 commits November 11, 2022 13:39

[FIX+IMP] account_tax_balance:

6a8cc2b

* Test * README * add extra parent menu. If not, with the web_responsive module is mixed between other menus

[FIX] Include tax amounts from all move types

b9cdcc3

[IMP] account_tax_balance: performance

b604ac4

Let the database do some computations (sum) and do not put large lists of ids in action domain.

[IMP] account_tax_balance: faster search of taxes with moves

c41b939

account_tax_balance: improve test coverage

4f70e6d

add condition tax_exigible in domain variable

d611bca

[IMP] account_tax_balance: add index

508801e

This indexes improve the display time of account_tax_balance by a factor of 10 on a database with 1M move lines.

[MIG] account_tax_balance: Migration to 11.0

94fcd31

dynamize general ledger

f5ebe29

[IMP] account_tax_balance: Change tests to post instal and protect ag…

fd9c2d1

…ain freezes

StefanRijnhart and others added 10 commits November 11, 2022 13:39

[14.0][FIX] account_tax_balance: init hook refund confusion

e5fd247

[IMP] account_tax_balance: black, isort, prettier

37a257f

[MIG] account_tax_balance: Migration to 15.0

491f421

[UPD] Update account_tax_balance.pot

104eb38

[FIX] account_tax_balance: Fix development_status

274da45

[FIX] account_tax_balance: Recompute balance for different dates

7509184

[FIX] account_tax_balance: delete obsolete migration

270c51d

[FIX] account_tax_balance: run test after install

07fb3f8

Due to the change at odoo/odoo@15a1b3a it is now required to run tests that require CoA after install.

[IMP] account_tax_balance: pre-commit stuff

cd56144

[MIG] account_tax_balance: Migration to 16.0

6ad3e20

ramiadavid force-pushed the 16.0-mig-account_tax_balance branch from 78e6237 to 6ad3e20 Compare November 11, 2022 12:39

tafaRU approved these changes Nov 11, 2022

View reviewed changes

OCA-git-bot added the approved label Nov 11, 2022

OCA-git-bot added bot is merging ⏳ ready to merge labels Nov 11, 2022

OCA-git-bot merged commit 750772d into OCA:16.0 Nov 11, 2022

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Nov 11, 2022

ramiadavid deleted the 16.0-mig-account_tax_balance branch November 11, 2022 13:22

Uh oh!

Conversation

ramiadavid commented Oct 27, 2022

Uh oh!

ramiadavid commented Oct 27, 2022

Uh oh!

tafaRU left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eLBati left a comment

Choose a reason for hiding this comment

Uh oh!

tafaRU commented Nov 11, 2022

Uh oh!

pedrobaeza commented Nov 11, 2022

Uh oh!

tafaRU commented Nov 11, 2022

Uh oh!

pedrobaeza commented Nov 11, 2022

Uh oh!

ramiadavid commented Nov 11, 2022

Uh oh!

pedrobaeza commented Nov 11, 2022

Uh oh!

ramiadavid commented Nov 11, 2022

Uh oh!

tafaRU commented Nov 11, 2022

Uh oh!

pedrobaeza commented Nov 11, 2022

Uh oh!

ramiadavid commented Nov 11, 2022

Uh oh!

pedrobaeza commented Nov 11, 2022

Uh oh!

pedrobaeza commented Nov 11, 2022

Uh oh!

OCA-git-bot commented Nov 11, 2022

Uh oh!

OCA-git-bot commented Nov 11, 2022

Uh oh!

OCA-git-bot commented Nov 11, 2022

Uh oh!

Gelo-fl commented Jun 1, 2023

Uh oh!

pedrobaeza commented Jun 2, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

tafaRU left a comment •

edited

Loading