14.0 mig l10n it account stamp#2077
Merged
Merged
Conversation
jado95
force-pushed
the
14.0-mig-l10n_it_account_stamp
branch
5 times, most recently
from
8e517aa to
6a81f94
Compare
jado95
force-pushed
the
14.0-mig-l10n_it_account_stamp
branch
from
6a81f94 to
0d9c911
Compare
SimoRubi
suggested changes
Mar 26, 2021
SimoRubi
left a comment
SimoRubi
left a comment
Member
There was a problem hiding this comment.
Grazie della PR!
Potresti aggiungere un test?
jado95
force-pushed
the
14.0-mig-l10n_it_account_stamp
branch
4 times, most recently
from
57bca5b to
ef43b7f
Compare
MarcoCalcagni
approved these changes
Mar 27, 2021
Contributor
Author
Aggiunto, e direi di aver sistemato anche il resto delle cose chieste. |
jado95
force-pushed
the
14.0-mig-l10n_it_account_stamp
branch
4 times, most recently
from
f0035ff to
5fcd1c0
Compare
marcelofrare
approved these changes
Apr 9, 2021
marcelofrare
left a comment
marcelofrare
left a comment
Contributor
There was a problem hiding this comment.
Ok for me! Thanks @jado95
SimoRubi
suggested changes
Apr 9, 2021
SimoRubi
left a comment
SimoRubi
left a comment
Member
There was a problem hiding this comment.
Grazie del test!
Alcuni dei problemi che ti segnalai in #2077 (review) ci sono ancora, puoi controllare?
I problemi sulle stringhe non sono bloccanti, sarebbe comunque meglio togliere il 'sss' che hai aggiunto
jado95
force-pushed
the
14.0-mig-l10n_it_account_stamp
branch
2 times, most recently
from
85b16ae to
12e54e1
Compare
[FIX] clean [FIX] clean [FIX] pep8 [IMP] use tax obj instead of tax code [FIX] icon path [FIX] get product with lang context [FIX] translation [FIX] product name [FIX] compute after unlink of invoice line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descrizione del problema o della funzionalità:
Comportamento attuale prima di questa PR:
Comportamento desiderato dopo questa PR:
--
Confermo di aver firmato il CLA https://odoo-community.org/page/cla e di aver letto le linee guida su https://odoo-community.org/page/contributing