Skip to content

[14.0][MIG] l10n_it_sdi_channel: Migration to 14.0#2157

Merged
OCA-git-bot merged 39 commits into
OCA:14.0from
Borruso:14.0-mig-l10n_it_sdi_channel
Nov 12, 2021
Merged

[14.0][MIG] l10n_it_sdi_channel: Migration to 14.0#2157
OCA-git-bot merged 39 commits into
OCA:14.0from
Borruso:14.0-mig-l10n_it_sdi_channel

Conversation

@Borruso

@Borruso Borruso commented Mar 5, 2021

Copy link
Copy Markdown
Contributor

Porting del modulo l10n_it_sdi_channel dalla versione 12.0 alla 14.0

--
Confermo di aver firmato il CLA https://odoo-community.org/page/cla e di aver letto le linee guida su https://odoo-community.org/page/contributing

@Borruso Borruso changed the title Porting del modulo l10n_it_sdi_channel dalla versione 12.0 alla 14.0 [14.0][MIG] l10n_it_sdi_channel: Migration to 14.0 Mar 5, 2021
@Borruso Borruso mentioned this pull request Mar 5, 2021
76 tasks

@andreampiovesana andreampiovesana left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go

@GSLabIt GSLabIt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non si potrebbe fare un refactoring e "disaccoppiare" tutto ciò che riguarda la pec e spostarlo su l10n_it_fatturapa_pec?

Comment on lines +14 to +23
email_from_for_fatturaPA = fields.Char(
string="Sender Email Address",
related="sdi_channel_id.pec_server_id.email_from_for_fatturaPA",
readonly=True,
)
email_exchange_system = fields.Char(
string="Exchange System Email Address",
related="sdi_channel_id.email_exchange_system",
readonly=True,
)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non si potrebbero spostare nel modulo fatturapa_pec?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dato che sulla v12 è ancora così, potresti creare una issue con la modifica da apportare in entrambe le versioni

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vedi #2477

Comment on lines +35 to +44
email_from_for_fatturaPA = fields.Char(
string="Sender Email Address",
related="sdi_channel_id.pec_server_id.email_from_for_fatturaPA",
readonly=True,
)
email_exchange_system = fields.Char(
string="Exchange System Email Address",
related="sdi_channel_id.email_exchange_system",
readonly=True,
)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Come sopra

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Come sopra

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vedi #2477

TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Mar 26, 2021
@tafaRU

tafaRU commented Apr 14, 2021

Copy link
Copy Markdown
Member

@Borruso vedi #1959 (comment)

TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Apr 15, 2021
@Borruso Borruso force-pushed the 14.0-mig-l10n_it_sdi_channel branch from d5cc81f to d1ebec8 Compare April 16, 2021 07:43
@Borruso

Borruso commented Apr 16, 2021

Copy link
Copy Markdown
Contributor Author

@Borruso vedi #1959 (comment)

Fatto ma non compare Travis

Comment thread l10n_it_sdi_channel/models/sdi.py Outdated
@Borruso Borruso force-pushed the 14.0-mig-l10n_it_sdi_channel branch from d1ebec8 to a33e068 Compare May 6, 2021 05:53
@Borruso Borruso requested a review from TheMule71 May 6, 2021 05:53
@Borruso Borruso force-pushed the 14.0-mig-l10n_it_sdi_channel branch 3 times, most recently from 57d2216 to 4f630f3 Compare May 6, 2021 06:14
@TheMule71 TheMule71 removed their request for review May 7, 2021 08:50
@Borruso Borruso force-pushed the 14.0-mig-l10n_it_sdi_channel branch from 4f630f3 to 8fc01da Compare June 4, 2021 14:14
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jun 6, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jun 18, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jun 18, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 2, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 2, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 9, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 9, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 9, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 9, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 17, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 20, 2021
OCA-git-bot and others added 13 commits October 15, 2021 09:58
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_sdi_channel
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_sdi_channel/
Currently translated at 100.0% (38 of 38 strings)

Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_sdi_channel
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_sdi_channel/it/
Currently translated at 100.0% (38 of 38 strings)

Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_sdi_channel
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_sdi_channel/it/
…g SMTP server: the e-invoice PEC server must not be used
@Borruso Borruso force-pushed the 14.0-mig-l10n_it_sdi_channel branch from b7fc107 to d630333 Compare October 15, 2021 09:12
@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Oct 15, 2021

@TheMule71 TheMule71 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Unica cosa di cui non sono sicuro - chiedo a chi fa traduzioni - il file it.po va incluso nella migrazione o va lasciato fuori e rigenerato via weblate?

Comment on lines +24 to +25
<header>
</header>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L'header vuoto fa qualcosa?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in effetti è la stessa form che abbiamo per la 12.0
per me possiamo eliminarle dato che non dovrebbero servire a nulla

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Magari è li per estendere la form ed aggiungere eventuali buttons?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Magari è li per estendere la form ed aggiungere eventuali buttons?

vero ma si potrebbe fare un <xpath expr="//form/sheet" position="before">

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vero anche questo. Magari su 14.0 si può rimuovere se non vi sono altri moduli che lo estendono basandosi su <header>.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a questo punto potremmo inserite anche questa modifica nella issue del refactoring 12.0/14.0 che hai scritto e valutare di eliminarlo?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aggiungi pure

@tafaRU

tafaRU commented Nov 2, 2021

Copy link
Copy Markdown
Member

@TheMule71

il file it.po va incluso nella migrazione o va lasciato fuori e rigenerato via weblate?

se ne era parlato nel canale Discord #traduzioni di Odoo Italia giungendo alla conclusione che non sono da rimuovere altrimenti verrebbero rigenerati vuoti perdendo così di fatto tutte le vecchie traduzioni.

@TheMule71

Copy link
Copy Markdown
Contributor

/ocabot merge nobump

@OCA-git-bot

Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-2157-by-TheMule71-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 02bdc28 into OCA:14.0 Nov 12, 2021
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 275401d. Thanks a lot for contributing to OCA. ❤️

TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Jan 21, 2022
TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Jan 21, 2022
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.