Skip to content

[12.0] IMP l10n_it_fatturapa_in adding "Recompute XML fields" button when fields like "invoices_number" and "registered" are not valorized#2174

Merged
OCA-git-bot merged 1 commit into
OCA:12.0from
eLBati:12.0-recompute_xml_fields
Mar 19, 2021
Merged

[12.0] IMP l10n_it_fatturapa_in adding "Recompute XML fields" button when fields like "invoices_number" and "registered" are not valorized#2174
OCA-git-bot merged 1 commit into
OCA:12.0from
eLBati:12.0-recompute_xml_fields

Conversation

@eLBati

@eLBati eLBati commented Mar 16, 2021

Copy link
Copy Markdown
Member

This may happen in case of temporary errors while importing from SDI

--
Confermo di aver firmato il CLA https://odoo-community.org/page/cla e di aver letto le linee guida su https://odoo-community.org/page/contributing

@mrcast mrcast left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test OK!

Comment on lines +78 to +80
for att in self:
att._compute_xml_data()
att._compute_registered()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perchè non?

Suggested change
for att in self:
att._compute_xml_data()
att._compute_registered()
self._compute_xml_data()
self._compute_registered()

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ci sta. Modificato. Grazie

…elds like "invoices_number" and "registered" are not valorized

This may happen in case of temporary errors while importing from SDI
@eLBati eLBati force-pushed the 12.0-recompute_xml_fields branch from e5c8d7d to f8a5e8f Compare March 19, 2021 06:42

@sergiocorato sergiocorato left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie

@eLBati

eLBati commented Mar 19, 2021

Copy link
Copy Markdown
Member Author

/ocabot merge minor

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-2174-by-eLBati-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 19, 2021
Signed-off-by eLBati
@OCA-git-bot

Copy link
Copy Markdown
Contributor

It looks like something changed on 12.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 12.0-ocabot-merge-pr-2174-by-eLBati-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 063981a into OCA:12.0 Mar 19, 2021
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at f463336. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants