[14.0] [FIX] l10n_it_withholding_tax: fix for #2345 + multicompany#2353
Merged
OCA-git-bot merged 1 commit intoSep 17, 2021
Merged
Conversation
TheMule71
force-pushed
the
14.0-fix-l10n_it_withholding_tax-multicompany
branch
from
a5637a4 to
4d63ebf
Compare
eLBati
reviewed
Jul 2, 2021
| currency = self.env["res.currency"].browse(self.env.context["currency_id"]) | ||
| else: | ||
| currency = self.env.user.company_id.currency_id | ||
| currency = self.env.company |
Contributor
Author
There was a problem hiding this comment.
yes
grazie, sistemato
Member
There was a problem hiding this comment.
TheMule71
changed the title
TheMule71
force-pushed
the
14.0-fix-l10n_it_withholding_tax-multicompany
branch
from
4d63ebf to
7960409
Compare
TheMule71
force-pushed
the
14.0-fix-l10n_it_withholding_tax-multicompany
branch
from
7960409 to
ebafaf8
Compare
TheMule71
changed the title
eLBati
approved these changes
Jul 8, 2021
|
provata e funzionante |
Contributor
Author
|
/ocabot merge patch |
Contributor
|
Hey, thanks for contributing! Proceeding to merge this for you. |
Contributor
|
Congratulations, your PR was merged at 9947464. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usa self.env.company invece di self.env.user.company_id. La seconda, l'azienda di default dell'utente collegato, raramente è quella giusta da usare, visto che comunque si opera nel contesto dell'azienda indicata da self.env.company.
Questa fix fa parte di una serie di fix relative alla gestione del multicompany.
Edit: aggiunto anche fix per la #2345 (era #2351)
Edit2: da verificare se dipende da #2352
--
Confermo di aver firmato il CLA https://odoo-community.org/page/cla e di aver letto le linee guida su https://odoo-community.org/page/contributing