[16.0][MIG] l10n_it_abicab#2977
Closed
Borruso wants to merge 39 commits into
Closed
Conversation
TheMule71
requested changes
Oct 25, 2022
Comment on lines
+13
to
+14
| abi = fields.Char(size=5, string="ABI") | ||
| cab = fields.Char(size=5, string="CAB") |
Contributor
There was a problem hiding this comment.
Ciao.
In call si è parlato di adattarci un po' alla naming convention di Odoo per i campi.
I campi andrebbero rinominati l10n_it_abi e l10n_it_cab.
Comment on lines
+21
to
+22
| bank_abi = fields.Char(size=5, string="ABI", related="bank_id.abi", store=True) | ||
| bank_cab = fields.Char(size=5, string="CAB", related="bank_id.cab", store=True) |
Contributor
There was a problem hiding this comment.
Idem. (Beh non ti sto a segnare tutte le occorrenze d'ora in poi)
Borruso
force-pushed
the
16.0-mig-l10n_it_abicab
branch
5 times, most recently
from
ea0527c to
828b714
Compare
Contributor
|
/ocabot migration l10n_it_abicab |
Borruso
force-pushed
the
16.0-mig-l10n_it_abicab
branch
from
828b714 to
dedba5d
Compare
TonyMasciI
reviewed
Nov 10, 2022
| ) | ||
|
|
||
| @api.onchange("bank_id") | ||
| def onchange_bank_id(self): |
Contributor
There was a problem hiding this comment.
Metodo non necessario per popolare i campi "l10n_it_bank_abi" & "l10n_it_bank_cab" dato che hanno l'attributo related nella loro definizione, creata una issue
[IMP] porting module to Odoo 8.0 [ADD] Readme clear __openerp__.py [FIX] Flake8 - W292 no newline at end of file Replace Openerp -> Odoo [FIX] Depends - Readme - Module name - Update transalation file
[MIG] Rename manifest files
[FIX] authors [FIX] copyright [FIX] README syntax [FIX] README syntax [FIX] contributors
Currently translated at 100.0% (5 of 5 strings) Translation: l10n-italy-11.0/l10n-italy-11.0-l10n_it_abicab Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-11-0/l10n-italy-11-0-l10n_it_abicab/it/
[IMP] Set partner bank abi/cab related
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_abicab Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_abicab/
Currently translated at 100.0% (6 of 6 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_abicab Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_abicab/it/
Currently translated at 100.0% (9 of 9 strings) Translation: l10n-italy-14.0/l10n-italy-14.0-l10n_it_abicab Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_abicab/it/
pylint with optional checks..............................................Passed - hook id: pylint - duration: 61.46s ************* Module l10n_it_fatturapa l10n_it_fatturapa/views/partner_view.xml:51: [W7940(dangerous-view-replace-wo-priority), ] Dangerous use of "replace" from view with priority 0 < 99 ************* Module l10n_it_abicab l10n_it_abicab/views/abicab_view.xml:29: [W7940(dangerous-view-replace-wo-priority), ] Dangerous use of "replace" from view with priority 0 < 99 ************* Module l10n_it_intrastat_statement.models.intrastat_statement_purchase_section l10n_it_intrastat_statement/models/intrastat_statement_purchase_section.py:58: [R7980(consider-merging-classes-inherited), IntrastatStatementPurchaseSection1] Consider merging classes inherited to "account.intrastat.statement.purchase.section" from intrastat_statement_purchase_section.py:212, intrastat_statement_purchase_section.py:357, intrastat_statement_purchase_section.py:428. ************* Module l10n_it_intrastat_statement.models.intrastat_statement_sale_section l10n_it_intrastat_statement/models/intrastat_statement_sale_section.py:26: [R7980(consider-merging-classes-inherited), IntrastatStatementSaleSection1] Consider merging classes inherited to "account.intrastat.statement.sale.section" from intrastat_statement_sale_section.py:172, intrastat_statement_sale_section.py:300, intrastat_statement_sale_section.py:371. pylint with mandatory checks.............................................Failed - hook id: pylint - exit code: 4 ************* Module l10n_it_fatturapa l10n_it_fatturapa/views/partner_view.xml:51: [W7940(dangerous-view-replace-wo-priority), ] Dangerous use of "replace" from view with priority 0 < 99 ************* Module l10n_it_abicab l10n_it_abicab/views/abicab_view.xml:29: [W7940(dangerous-view-replace-wo-priority), ] Dangerous use of "replace" from view with priority 0 < 99
Removed method because there is a "related" attribute in fields bank_abi & bank_cab which makes the method unnecessary
Borruso
force-pushed
the
16.0-mig-l10n_it_abicab
branch
from
dedba5d to
b4c4abe
Compare
tafaRU
requested changes
Nov 11, 2022
tafaRU
left a comment
tafaRU
left a comment
Member
There was a problem hiding this comment.
Squash administrative commits (if any) with the previous commit for reducing commit noise.
Puoi eventualmente fare riferimento a https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests
Member
|
@Borruso risolvo io il mio commento in un'altra PR. |
Member
|
Chiudo in favore di #3036 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration l10n_it_abicab from 14.0 to 16.0
--
Confermo di aver firmato il CLA https://odoo-community.org/page/cla e di aver letto le linee guida su https://odoo-community.org/page/contributing