Skip to content

[14.0] [MIG] l10n_it_bill_of_entry#2986

Merged
OCA-git-bot merged 20 commits into
OCA:14.0from
SirTakobi:14.0-mig-l10n_it_bill_of_entry
Mar 6, 2023
Merged

[14.0] [MIG] l10n_it_bill_of_entry#2986
OCA-git-bot merged 20 commits into
OCA:14.0from
SirTakobi:14.0-mig-l10n_it_bill_of_entry

Conversation

@SirTakobi

Copy link
Copy Markdown
Contributor

@SirTakobi SirTakobi mentioned this pull request Oct 31, 2022
76 tasks
@SirTakobi SirTakobi marked this pull request as ready for review November 2, 2022 08:55
@eLBati eLBati changed the title [MIG] l10n_it_bill_of_entry [14.0] [MIG] l10n_it_bill_of_entry Nov 3, 2022
@primes2h

primes2h commented Nov 8, 2022

Copy link
Copy Markdown
Contributor

/ocabot migration l10n_it_bill_of_entry

@OCA-git-bot OCA-git-bot added this to the 14.0 milestone Nov 8, 2022
@dcorio

dcorio commented Dec 6, 2022

Copy link
Copy Markdown

Ciao @SirTakobi volevo solo farti sapere che ho testato il modulo allo stato attuale e funzionalmente si comporta come atteso

@SirTakobi

Copy link
Copy Markdown
Contributor Author

Ciao @SirTakobi volevo solo farti sapere che ho testato il modulo allo stato attuale e funzionalmente si comporta come atteso

Grazie! Potresti aggiungerlo come review di Github?
È più facile contare le revisioni nel riassunto Reviewers in cima alla PR che scorrere tutta la conversazione.
Puoi fare una review seguendo https://www.odoo-italia.org/documentazione/12.0/sviluppo/review.html#revisione (lo sai già come si fa, ma così pubblicizziamo la nostra documentazione 😛).

@francesco-ooops

Copy link
Copy Markdown
Contributor

Puoi fare una review seguendo https://www.odoo-italia.org/documentazione/12.0/sviluppo/review.html#revisione (lo sai già come si fa, ma così pubblicizziamo la nostra documentazione 😛).

Verificando la documentazione, nella sezione "review funzionale" andrebbe aggiunto a "Revisione funzionale" di andare su files changed > review changes > approve (e il tipo di messaggio da lasciare, es: "revisione funzionale")

oltre ad aggiornare con gli screenshot di runboat

Se volete posso preparare un doc con le modifiche necessarie

@SirTakobi

Copy link
Copy Markdown
Contributor Author

Se volete posso preparare un doc con le modifiche necessarie

Puoi proporre modifiche partendo dal link Modifica su GitHub
image
Alla fine si dovrebbe arrivare a fare una PR su https://github.com/odoo-italia/documentazione

@francesco-ooops

Copy link
Copy Markdown
Contributor

@SirTakobi puoi fare un rebase per testing?

@SirTakobi SirTakobi force-pushed the 14.0-mig-l10n_it_bill_of_entry branch from da3f8e3 to 12680c8 Compare February 28, 2023 12:18
@SirTakobi

SirTakobi commented Feb 28, 2023

Copy link
Copy Markdown
Contributor Author

@SirTakobi puoi fare un rebase per testing?

Fatto.

Per correggere pre-commit ho scritto in OCA/oca-addons-repo-template#184 (comment)

@elvise elvise left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Functional Review

@stefano-ooops stefano-ooops left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testato ok

@SirTakobi

Copy link
Copy Markdown
Contributor Author

@SirTakobi puoi fare un rebase per testing?

Fatto.

Per correggere pre-commit ho scritto in OCA/oca-addons-repo-template#184 (comment)

Sarà risolto dopo #3195

@francesco-ooops

Copy link
Copy Markdown
Contributor

@OCA/local-italy-maintainers possiamo mergiare?

@francesco-ooops

Copy link
Copy Markdown
Contributor

@SirTakobi puoi sistemare il precommit? grazie!

tafaRU and others added 12 commits March 2, 2023 10:44
[FIX] mail author

[ADD] advance_customs_vat and wizard/select_template

[FIX] Add __init__.py

[ADD] button 'Make Bill of Entry'

[FIX] Remove pdb

[REF] override load_template

[ADD] check if invoice.customs_doc_type == 'forwarder_invoice'
[fix] osv -> orm

[add] action_move_create

[add] company

[add] storno move

[add] reconciliation

[add] action_cancel

[imp] descr

[imp] company view

[fix] view

[fix] view

[fix] view

[fix] errore msg

[fix] m2m

[fix] missing partner

[imp] tax code

[imp] description

[add] allow to link BOE to forwarder inv

[imp] interface

[imp] interface

[add] trans

[imp] interface

[REF] Set all the modules of the master branches to "installable": False
moves all modules into a __unported__ directory
 * essential features migration from rel. 7
 * adding demo data and unit tests
@SirTakobi SirTakobi force-pushed the 14.0-mig-l10n_it_bill_of_entry branch from 12680c8 to 9e6e9f7 Compare March 2, 2023 09:45
@SirTakobi

Copy link
Copy Markdown
Contributor Author

@SirTakobi puoi sistemare il precommit? grazie!

Fatto rebase, vediamo come va

@elvise

elvise commented Mar 2, 2023

Copy link
Copy Markdown

@SirTakobi puoi sistemare il precommit? grazie!

Fatto rebase, vediamo come va

💣

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@eLBati

eLBati commented Mar 6, 2023

Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-2986-by-eLBati-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c21a38c into OCA:14.0 Mar 6, 2023
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 56b4171. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.