Skip to content

[16.0] [MIG] l10n_it_payment_reason#2997

Merged
OCA-git-bot merged 7 commits into
OCA:16.0from
TheMule71:16.0-mig-l10n_it_payment_reason
Nov 25, 2022
Merged

[16.0] [MIG] l10n_it_payment_reason#2997
OCA-git-bot merged 7 commits into
OCA:16.0from
TheMule71:16.0-mig-l10n_it_payment_reason

Conversation

@TheMule71

@TheMule71 TheMule71 commented Nov 2, 2022

Copy link
Copy Markdown
Contributor

Incorpora #2990 per i test.

@TheMule71 TheMule71 mentioned this pull request Nov 3, 2022
81 tasks
@primes2h

primes2h commented Nov 8, 2022

Copy link
Copy Markdown
Contributor

/ocabot migration l10n_it_payment_reason

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Nov 8, 2022
@TheMule71 TheMule71 marked this pull request as ready for review November 10, 2022 13:31
@TheMule71 TheMule71 force-pushed the 16.0-mig-l10n_it_payment_reason branch 2 times, most recently from ca548dd to 834419c Compare November 11, 2022 08:07

@SirTakobi SirTakobi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie della PR!
Ho fatto revisione del codice e l'ho provato in locale, per me è ok.
Puoi rimuovere i commit per l10n_it_account?

@TheMule71 TheMule71 force-pushed the 16.0-mig-l10n_it_payment_reason branch from 834419c to ec97bce Compare November 11, 2022 16:35
@TheMule71

Copy link
Copy Markdown
Contributor Author

Grazie della PR! Ho fatto revisione del codice e l'ho provato in locale, per me è ok. Puoi rimuovere i commit per l10n_it_account?

dovrebbe essere OK

@marcelofrare marcelofrare left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

provato su runboat

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@primes2h primes2h left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

INSTALL.rst andrebbe eliminato, contiene info per la migrazione alla versione 14.0, nella quale è stato modificato il nome del modulo e di alcune viste/modelli.

Comment thread l10n_it_payment_reason/__manifest__.py Outdated
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).

{
"name": "ITA - Causali pagamento",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"name": "ITA - Causali pagamento",
"name": "ITA - Causali di pagamento",

@TheMule71 TheMule71 force-pushed the 16.0-mig-l10n_it_payment_reason branch from ec97bce to d610197 Compare November 25, 2022 08:50
@tafaRU

tafaRU commented Nov 25, 2022

Copy link
Copy Markdown
Member

@primes2h puoi aggiornare la tua review? Così poi mergiamo. Grazie.

@primes2h

Copy link
Copy Markdown
Contributor

/ocabot merge nobump

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-2997-by-primes2h-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 25, 2022
Signed-off-by primes2h
@OCA-git-bot

Copy link
Copy Markdown
Contributor

@primes2h your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-2997-by-primes2h-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@tafaRU

tafaRU commented Nov 25, 2022

Copy link
Copy Markdown
Member

@primes2h pare trattarsi di un problema temporaneo:
image

Riprovo: /ocabot merge nobump

@OCA-git-bot

Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-2997-by-tafaRU-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 25, 2022
Signed-off-by tafaRU
@OCA-git-bot

Copy link
Copy Markdown
Contributor

@tafaRU your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-2997-by-tafaRU-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@tafaRU

tafaRU commented Nov 25, 2022

Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot

Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-2997-by-tafaRU-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b99ef8b into OCA:16.0 Nov 25, 2022
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 11c0b66. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants