[16.0] [MIG] l10n_it_fatturapa_in by TheMule71 · Pull Request #3000 · OCA/l10n-italy

TheMule71 · 2022-11-03T00:37:17Z

No description provided.

TheMule71 · 2022-11-03T23:45:04Z

Alcuni test vengono skippati, perché provocano errori DB che impediscono l'esecuzione di test successivi.

primes2h · 2022-11-08T14:29:31Z

/ocabot migration l10n_it_fatturapa_in

TheMule71 · 2022-12-08T01:23:59Z

~~Promemoria: #3004~~

TheMule71 · 2022-12-30T21:11:19Z

~~Include #3111 per far passare i test. Ovviamente, andrebbe mergiata prima quella.~~

~~Tengo temporaneamente separato il commit di fix dei test per agevolare la review.~~

TheMule71 · 2023-04-07T13:30:33Z

@SirTakobi dovrei aver rivisto tutto.

SirTakobi

Grazie mille delle modifiche,
ho solo verificato la storia dei commit e fatto revisione del codice.

Ho messo ancora qualche commento per le questioni in sospeso ma per me non c'è più nulla di bloccante per il merge.

SirTakobi · 2023-04-13T10:05:34Z

@@ -0,0 +1,36 @@
+# Copyright 2015 AgileBG SAGL <http://www.agilebg.com>


Manca 93a6dab, non c'è però una issue per tracciarlo (la PR è #3245).
La modifica è molto semplice, vedi tu se preferisci creare una issue e segnare lì che manca, oppure includere il commit (insieme al commit dei bot che ha causato)

SirTakobi · 2023-04-13T10:07:41Z

@@ -0,0 +1,1926 @@
+# Translation of Odoo Server.


Mancano le traduzioni aggiunte in 8fed160

SirTakobi · 2023-04-13T10:28:38Z

-            self.env["account.account"]
-            .search(
+    @classmethod
+    def setUpClass(cls):


SirTakobi · 2023-04-13T10:29:00Z

        self.assertEqual(invoice.partner_id.name, "SOCIETA' ALPHA SRL")
        self.assertEqual(invoice.amount_untaxed, 25.00)
-        self.assertEqual(invoice.amount_tax, 0.0)
+        self.assertEqual(invoice.amount_tax, 3.75)


SirTakobi · 2023-04-13T10:29:19Z

        )

    def test_37_xml_import_dates(self):
-        self.env.user.lang = "it_IT"


SirTakobi · 2023-04-13T10:29:58Z

-        self.assertTrue(vat_partner_exists())
+
+        # XXX changed to false, now it works as intented
+        self.assertFalse(vat_partner_exists())


Può essere che creando l'attachment tramite Form (com'era prima di questa PR) non serva leggere un campo per scatenare il tutto?
Ad ogni modo, l'importante è che non sia necessario modificare la logica del test.
👍

SirTakobi · 2023-04-13T10:33:32Z

        self.assertEqual(invoices.mapped("e_invoice_validation_error"), [False, False])

    def test_duplicated_vat_on_partners(self):
-        supplier = self.env["res.partner"].search(


SirTakobi · 2023-04-13T10:33:41Z

-            <field name="amount_tax" position="after">
+            <!-- field name="price_subtotal" position="after">
                <field
                    name="efatt_rounding"


SirTakobi · 2023-04-13T11:24:14Z

                    ("type_tax_use", "=", "purchase"),
                    ("kind_id.code", "=", Natura),
                    ("amount", "=", 0.0),
+                    ("company_id", "=", self.env.company.id),


Ho provato, e le regole di sicurezza non vengono applicate perché i test vengono eseguiti con OdooBot che le bypassa in https://github.com/odoo/odoo/blob/f689c4f53fc4663b17c57bd1d704b9ffb9f11f8d/odoo/models.py#L4418.

Quindi questa aggiunta è necessaria solo nei test, perché normalmente non viene usato OdooBot e le regole vengono applicate.
Ti ho proposto TheMule71#37 per rimuovere questa modifica.

SirTakobi · 2023-04-13T12:38:19Z

                line_vals["product_id"] = global_discount_product.id
                line_vals["name"] = global_discount_product.name
                self.adjust_accounting_data(global_discount_product, line_vals)
+            elif company.arrotondamenti_tax_id:


Avevo capito che qui si sarebbe dovuta rimuovere l'imposta di default, ho aggiunto la modifica in TheMule71#37.

Il commit che attualmente è separato penso sia una nuova funzionalità, se vuoi mantenerla in questa PR servirebbe anche la issue di tracciamento.

OCA-git-bot · 2023-04-13T13:04:09Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Co-authored-by: andreapiovesana <andrea.m.piovesana@gmail.com> Co-authored-by: Simone Rubino <sir@takobi.online>

tafaRU · 2023-04-14T08:27:14Z

/ocabot merge nobump

OCA-git-bot · 2023-04-14T08:27:30Z

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-3000-by-tafaRU-bump-nobump, awaiting test results.

OCA-git-bot · 2023-04-14T08:39:25Z

Congratulations, your PR was merged at e6f683b. Thanks a lot for contributing to OCA. ❤️

TheMule71 force-pushed the 16.0-mig-l10n_it_fatturapa_in branch 5 times, most recently from dbd4932 to e94ccf9 Compare November 3, 2022 02:03

TheMule71 mentioned this pull request Nov 3, 2022

Migration to version 16.0 #2967

Open

81 tasks

TheMule71 force-pushed the 16.0-mig-l10n_it_fatturapa_in branch 2 times, most recently from 9e5384d to 0206c5f Compare November 3, 2022 23:35

TheMule71 force-pushed the 16.0-mig-l10n_it_fatturapa_in branch from 0206c5f to 83027a5 Compare November 10, 2022 14:20

eLBati added the needs functional review label Nov 18, 2022

tafaRU removed the needs functional review label Nov 25, 2022

TheMule71 force-pushed the 16.0-mig-l10n_it_fatturapa_in branch 2 times, most recently from b47b943 to 69480f3 Compare December 6, 2022 23:30

TheMule71 force-pushed the 16.0-mig-l10n_it_fatturapa_in branch 5 times, most recently from f45c7ae to e6332e7 Compare December 16, 2022 11:56

TheMule71 marked this pull request as ready for review December 30, 2022 16:47

TheMule71 force-pushed the 16.0-mig-l10n_it_fatturapa_in branch 2 times, most recently from 6905f00 to f965f29 Compare December 30, 2022 19:50

TheMule71 mentioned this pull request Dec 30, 2022

[16.0][FIX] l10n_it_fatturapa_out: piva in tests #3111

Merged

TheMule71 added the needs functional review label Dec 30, 2022

TheMule71 force-pushed the 16.0-mig-l10n_it_fatturapa_in branch from bd88242 to 813119a Compare December 30, 2022 21:51

TheMule71 force-pushed the 16.0-mig-l10n_it_fatturapa_in branch 2 times, most recently from f5b69d9 to 23b323c Compare January 13, 2023 08:56

TheMule71 added 2 commits April 6, 2023 21:09

[IMP] l10n_it_fatturapa_in: add TD27 TD28

8bf9f42

[IMP] l10n_it_fatturapa_in: pre-commit stuff

bc10e44

TheMule71 force-pushed the 16.0-mig-l10n_it_fatturapa_in branch 8 times, most recently from 4739c21 to 489e97d Compare April 7, 2023 13:29

TheMule71 removed the needs functional review label Apr 7, 2023

SirTakobi mentioned this pull request Apr 13, 2023

[COV] l10n_it_fatturapa_in: Set italian user in tests TheMule71/l10n-italy#37

Merged

SirTakobi approved these changes Apr 13, 2023

View reviewed changes

OCA-git-bot added approved ready to merge labels Apr 13, 2023

TheMule71 force-pushed the 16.0-mig-l10n_it_fatturapa_in branch from f5f9646 to 3922943 Compare April 14, 2023 08:18

[MIG] l10n_it_fatturapa_in: Migration to 16.0

615c6dd

Co-authored-by: andreapiovesana <andrea.m.piovesana@gmail.com> Co-authored-by: Simone Rubino <sir@takobi.online>

TheMule71 force-pushed the 16.0-mig-l10n_it_fatturapa_in branch from 3922943 to 615c6dd Compare April 14, 2023 08:24

OCA-git-bot added the bot is merging ⏳ label Apr 14, 2023

OCA-git-bot merged commit 04f6b5c into OCA:16.0 Apr 14, 2023

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Apr 14, 2023

francesco-ooops mentioned this pull request Dec 27, 2023

determinazione della posizione fiscale nell'import della fattura passiva #2715

Closed

3 tasks

francesco-ooops added the migration label Jan 10, 2024

		@@ -0,0 +1,36 @@
		# Copyright 2015 AgileBG SAGL <http://www.agilebg.com>

Uh oh!

Conversation

TheMule71 commented Nov 3, 2022

Uh oh!

TheMule71 commented Nov 3, 2022

Uh oh!

primes2h commented Nov 8, 2022

Uh oh!

TheMule71 commented Dec 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TheMule71 commented Dec 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TheMule71 commented Apr 7, 2023

Uh oh!

SirTakobi left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Apr 13, 2023

Uh oh!

tafaRU commented Apr 14, 2023

Uh oh!

OCA-git-bot commented Apr 14, 2023

Uh oh!

OCA-git-bot commented Apr 14, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

TheMule71 commented Dec 8, 2022 •

edited

Loading

TheMule71 commented Dec 30, 2022 •

edited

Loading