[16.0][MIG] l10n_it_appointment_code#3001
Conversation
Borruso
force-pushed
the
16.0-mig-l10n_it_appointment_code
branch
from
d3749e6 to
ed17ee8
Compare
|
/ocabot migration l10n_it_appointment_code |
Borruso
force-pushed
the
16.0-mig-l10n_it_appointment_code
branch
from
ed17ee8 to
7603ac9
Compare
SirTakobi
left a comment
SirTakobi
left a comment
There was a problem hiding this comment.
Grazie della PR!
Puoi squashare i commit amministrativi come indicato in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0#tasks-to-do-in-the-migration?
Ho trovato un problema di visualizzazione, per correggere ti ho proposto Borruso#12, puoi vedere se va bene ed eventualmente mergiarla?
Borruso
force-pushed
the
16.0-mig-l10n_it_appointment_code
branch
2 times, most recently
from
ef32c68 to
4cebbb0
Compare
tafaRU
left a comment
tafaRU
left a comment
There was a problem hiding this comment.
In aggiunta, puoi schiacciare i tre commits seguenti in uno solo? I due amministrativi con il primo.
Per il resto LGTM, l'ho anche testato su runboat 👍
Borruso
force-pushed
the
16.0-mig-l10n_it_appointment_code
branch
from
4cebbb0 to
89dacab
Compare
Rename cannot be perfomed with hook as OCA#2220 (comment) Also note: * merge_modules = True is not needed when we simply rename modules * rename_xmlids has to be executed as first to build menus_by_module properly otherwise we get: test-l10n_it_codici_carica=# select id ,name, menus_by_module from ir_module_module where name like '%appointment%'; id | name | menus_by_module -----+--------------------------+------------------------------------------------------ 488 | l10n_it_appointment_code | Invoicing/Configuration/Accounting/Appointment Codes+ | | Invoicing/Configuration/Accounting/Role Codes [UPD] Update l10n_it_appointment_code.pot [UPD] README.rst
Borruso
force-pushed
the
16.0-mig-l10n_it_appointment_code
branch
from
89dacab to
8db8d3c
Compare
|
@SirTakobi potresti aggiornare la tua review? |
SirTakobi
left a comment
SirTakobi
left a comment
There was a problem hiding this comment.
Revisione dei commit, del codice e provato in runboat, per me è ok
|
This PR has the |
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 7242684. Thanks a lot for contributing to OCA. ❤️ |
7 participants
Migration l10n_it_appointment_code from 14.0 to 16.0
--
Confermo di aver firmato il CLA https://odoo-community.org/page/cla e di aver letto le linee guida su https://odoo-community.org/page/contributing