[16.0][MIG] l10n_it_central_journal_reportlab by Borruso · Pull Request #3002 · OCA/l10n-italy

Borruso · 2022-11-04T09:46:30Z

Migration l10n_it_central_journal_reportlab from 14.0 to 16.0

--
Confermo di aver firmato il CLA https://odoo-community.org/page/cla e di aver letto le linee guida su https://odoo-community.org/page/contributing

primes2h · 2022-11-08T14:28:08Z

/ocabot migration l10n_it_central_journal_reportlab

TonyMasciI

Aprirò una ISSUE per la V14

TonyMasciI · 2022-11-11T08:33:30Z

+                <field name="l10n_it_central_journal_exclude" />
+            </xpath>
+        </field>
+    </record>


Sposterei questa view in un file dedicato (account_journal_views.xml)

TonyMasciI · 2022-11-11T09:06:55Z

+        if self.l10n_it_date_move_line_from_view:
+            self.l10n_it_year_footer = fields.Date.to_date(
+                self.l10n_it_date_move_line_from_view
+            ).year


Non ha senso modificare questo pezzo di codice:

self.l10n_it_year_footer = fields.Date.to_date( self.l10n_it_date_move_line_from_view ).year

con:

self.l10n_it_year_footer = self.l10n_it_date_move_line_from_view.year

TonyMasciI · 2022-11-11T09:46:05Z

+            date_end = fields.Date.to_date(self.daterange_id.date_end)
+
+            if self.daterange_id.date_last_print:
+                date_last_print = fields.Date.to_date(self.daterange_id.date_last_print)


Suggested change

date_last_print = fields.Date.to_date(self.daterange_id.date_last_print)

date_last_print = self.daterange_id.date_last_print

TonyMasciI · 2022-11-11T09:47:28Z

+            if self.daterange_id.date_last_print:
+                date_last_print = fields.Date.to_date(self.daterange_id.date_last_print)
+                self.last_def_date_print = date_last_print
+                date_start = (date_last_print + timedelta(days=1)).__str__()


Suggested change

date_start = (date_last_print + timedelta(days=1)).__str__()

date_start = (date_last_print + timedelta(days=1)).strftime("%Y-%m-%d")

TonyMasciI · 2022-11-11T10:06:23Z

+                debit = Paragraph(formatLang(self.env, 0), style_number)
+                credit = Paragraph(formatLang(self.env, line["credit"]), style_number)
+                list_balance.append((0, line["credit"]))
+                lines_data.append([[row, date, move, account, name, debit, credit]])


c'è un motivo per cui sono stati fatti due if in cascata quando si potrebbe eseguire questo codice?

Da questo:

if line["debit"] > 0: debit = Paragraph(formatLang(self.env, line["debit"]), style_number) credit = Paragraph(formatLang(self.env, 0), style_number) list_balance.append((line["debit"], 0)) lines_data.append([[row, date, move, account, name, debit, credit]]) if line["credit"] > 0: debit = Paragraph(formatLang(self.env, 0), style_number) credit = Paragraph(formatLang(self.env, line["credit"]), style_number) list_balance.append((0, line["credit"])) lines_data.append([[row, date, move, account, name, debit, credit]])

a questo:

debit = Paragraph(formatLang(self.env, line["debit"]), style_number) credit = Paragraph(formatLang(self.env, line["credit"]), style_number) list_balance.append((line["credit"], line["credit"])) lines_data.append([[row, date, move, account, name, debit, credit]])

TonyMasciI · 2022-11-11T10:24:55Z

+    @api.onchange("date_move_line_from_view")
+    def get_year_footer_reportlab(self):
+        if self.date_move_line_from_view:
+            self.year_footer = fields.Date.to_date(self.date_move_line_from_view).year


Non ha senso modificare questo pezzo di codice:

self.year_footer = fields.Date.to_date(self.date_move_line_from_view).year

con:

self.l10n_it_year_footer = self.l10n_it_date_move_line_from_view.year

Borruso · 2023-09-07T07:46:56Z

@TonyMasciI per le varie modifiche suggerite Aprirò una ISSUE per la V14, suggerisco di applicarle dopo la migrazione dato che queste modifiche dovranno essere per v14 e v16

Bisognerebbe creare poi una issue di tracciamento

TonyMasciI · 2023-09-07T07:52:19Z

@Borruso perfetto!

tafaRU

Il resto LGTM 👍

marcelofrare

LGTM functional

marcelofrare · 2023-09-07T10:12:17Z

Nota a margine:
il readme è piuttosto limitato.
Sarebbe da aggiungere l'indicazione che il file PDF generato dal modulo lo si trova in fondo alla form.
Inoltre, servirebbe spiegare la differenza tra STAMPA e STAMPA DEFINITIVA

tafaRU · 2023-09-07T10:55:19Z

@marcelofrare in merito a #3002 (comment) abbiamo aperto #3562

tafaRU

@Borruso puoi schiacciare 669bf8022d1934fa3a4942fece3847432a943f99 con il precedente?

MarcoCalcagni

OK . test funzionali

…le stampa reportlab

Currently translated at 88.3% (53 of 60 strings) Translation: l10n-italy-14.0/l10n-italy-14.0-l10n_it_central_journal_reportlab Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_central_journal_reportlab/it/

Currently translated at 95.0% (57 of 60 strings) Translation: l10n-italy-14.0/l10n-italy-14.0-l10n_it_central_journal_reportlab Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_central_journal_reportlab/it/

tafaRU · 2023-09-07T13:04:02Z

/ocabot merge nobump

OCA-git-bot · 2023-09-07T13:04:09Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-3002-by-tafaRU-bump-nobump, awaiting test results.

tafaRU · 2023-09-07T13:04:10Z

/ocabot merge nobump

Signed-off-by tafaRU

OCA-git-bot · 2023-09-07T13:04:17Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-3002-by-tafaRU-bump-nobump, awaiting test results.

OCA-git-bot · 2023-09-07T13:17:30Z

Congratulations, your PR was merged at bc548ae. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot added this to the 16.0 milestone Nov 8, 2022

OCA-git-bot mentioned this pull request Nov 8, 2022

Migration to version 16.0 #2967

Open

81 tasks

Borruso force-pushed the 16.0-mig-l10n_it_central_journal_reportlab branch from 36db4b8 to ea0e200 Compare November 10, 2022 10:51

Borruso marked this pull request as ready for review November 10, 2022 10:51

Borruso force-pushed the 16.0-mig-l10n_it_central_journal_reportlab branch 3 times, most recently from 5fe7d50 to 0a38bc5 Compare November 11, 2022 09:31

TonyMasciI reviewed Nov 11, 2022

View reviewed changes

DinamicheAziendali mentioned this pull request Jun 29, 2023

PR aggiunte v16 DinamicheAziendali/l10n-italy#1

Open

14 tasks

Borruso force-pushed the 16.0-mig-l10n_it_central_journal_reportlab branch 2 times, most recently from 2ab3630 to c5b921a Compare July 18, 2023 14:43

Borruso force-pushed the 16.0-mig-l10n_it_central_journal_reportlab branch from c5b921a to 72e95de Compare July 26, 2023 09:00

Borruso force-pushed the 16.0-mig-l10n_it_central_journal_reportlab branch 3 times, most recently from 10294bd to ceb3f7e Compare August 25, 2023 15:26

TonyMasciI approved these changes Sep 7, 2023

View reviewed changes

tafaRU added the needs functional review label Sep 7, 2023

tafaRU requested changes Sep 7, 2023

View reviewed changes

Comment thread l10n_it_central_journal_reportlab/wizard/print_giornale.xml

Borruso force-pushed the 16.0-mig-l10n_it_central_journal_reportlab branch from ceb3f7e to 78ff26f Compare September 7, 2023 08:44

tafaRU approved these changes Sep 7, 2023

View reviewed changes

OCA-git-bot added the approved label Sep 7, 2023

marcelofrare approved these changes Sep 7, 2023

View reviewed changes

michelerusti mentioned this pull request Sep 7, 2023

[l10n_it_central_journal_reportlab] - Migliorative al README #3562

Closed

2 tasks

tafaRU requested changes Sep 7, 2023

View reviewed changes

OCA-git-bot removed the approved label Sep 7, 2023

MarcoCalcagni approved these changes Sep 7, 2023

View reviewed changes

Borruso and others added 6 commits September 7, 2023 14:39

[ADD] l10n_it_central_journal_reportlab: aggiunto modulo libro giorna…

b675bbd

…le stampa reportlab

Added translation using Weblate (Italian)

732028f

[IMP] l10n_it_central_journal_reportlab: pre-commit stuff

826a127

[MIG] l10n_it_central_journal_reportlab: Migration to 16.0

0b60310

Borruso force-pushed the 16.0-mig-l10n_it_central_journal_reportlab branch from 78ff26f to 0b60310 Compare September 7, 2023 12:40

tafaRU approved these changes Sep 7, 2023

View reviewed changes

OCA-git-bot added the approved label Sep 7, 2023

OCA-git-bot added the bot is merging ⏳ label Sep 7, 2023

OCA-git-bot added a commit that referenced this pull request Sep 7, 2023

Merge PR #3002 into 16.0

acd10cd

Signed-off-by tafaRU

OCA-git-bot merged commit 3aa24e9 into OCA:16.0 Sep 7, 2023

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Sep 7, 2023

francesco-ooops added the migration label Jan 10, 2024

monen17 mentioned this pull request May 2, 2025

[14.0][FIX] l10n_it_central_journal_reportlab: utilizzare i data range solo con azienda impostata #3539

Merged

	date_last_print = fields.Date.to_date(self.daterange_id.date_last_print)
	date_last_print = self.daterange_id.date_last_print

	date_start = (date_last_print + timedelta(days=1)).__str__()
	date_start = (date_last_print + timedelta(days=1)).strftime("%Y-%m-%d")

Uh oh!

Conversation

Borruso commented Nov 4, 2022

Uh oh!

primes2h commented Nov 8, 2022

Uh oh!

TonyMasciI left a comment

Choose a reason for hiding this comment

Uh oh!

TonyMasciI Nov 11, 2022

Choose a reason for hiding this comment

Uh oh!

TonyMasciI Nov 11, 2022

Choose a reason for hiding this comment

Uh oh!

TonyMasciI Nov 11, 2022

Choose a reason for hiding this comment

Uh oh!

TonyMasciI Nov 11, 2022

Choose a reason for hiding this comment

Uh oh!

TonyMasciI Nov 11, 2022

Choose a reason for hiding this comment

Uh oh!

TonyMasciI Nov 11, 2022

Choose a reason for hiding this comment

Uh oh!

Borruso commented Sep 7, 2023

Uh oh!

TonyMasciI commented Sep 7, 2023

Uh oh!

tafaRU left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

marcelofrare left a comment

Choose a reason for hiding this comment

Uh oh!

marcelofrare commented Sep 7, 2023

Uh oh!

tafaRU commented Sep 7, 2023

Uh oh!

tafaRU left a comment

Choose a reason for hiding this comment

Uh oh!

MarcoCalcagni left a comment

Choose a reason for hiding this comment

Uh oh!

tafaRU commented Sep 7, 2023

Uh oh!

OCA-git-bot commented Sep 7, 2023

Uh oh!

tafaRU commented Sep 7, 2023

Uh oh!

OCA-git-bot commented Sep 7, 2023

Uh oh!

OCA-git-bot commented Sep 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants