Skip to content

[16.0] [MIG] l10n_it_account_stamp#3021

Merged
OCA-git-bot merged 37 commits into
OCA:16.0from
jado95:16.0-mig-l10n_it_account_stamp
Nov 15, 2022
Merged

[16.0] [MIG] l10n_it_account_stamp#3021
OCA-git-bot merged 37 commits into
OCA:16.0from
jado95:16.0-mig-l10n_it_account_stamp

Conversation

@jado95

@jado95 jado95 commented Nov 10, 2022

Copy link
Copy Markdown
Contributor

Per la migrazione, nella creazione delle account.move.line(non righe fattura), ho dovuto aggiungere il 'display_type': 'cogs'.
Questo perchè se al display_type do il valore 'tax', non si riesce poi a riportare in bozza una fattura validata e con bollo applicato.

sergiocorato and others added 3 commits November 10, 2022 11:19
[FIX] clean

[FIX] clean

[FIX] pep8

[IMP] use tax obj instead of tax code

[FIX] icon path

[FIX] get product with lang context

[FIX] translation

[FIX] product name

[FIX] compute after unlink of invoice line
@jado95 jado95 force-pushed the 16.0-mig-l10n_it_account_stamp branch 4 times, most recently from c2c08f5 to 395ff2f Compare November 10, 2022 15:30
@jado95 jado95 mentioned this pull request Nov 10, 2022
81 tasks
@jado95 jado95 force-pushed the 16.0-mig-l10n_it_account_stamp branch 3 times, most recently from 65bf942 to a255ce8 Compare November 10, 2022 16:02

@SirTakobi SirTakobi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread l10n_it_account_stamp/readme/CONFIGURE.rst Outdated
Comment thread l10n_it_account_stamp/models/account_move.py Outdated
@jado95 jado95 force-pushed the 16.0-mig-l10n_it_account_stamp branch from a255ce8 to fed8e19 Compare November 11, 2022 10:21
eLBati and others added 17 commits November 11, 2022 11:53
…OCA#818)

This is needed as stamp line should be under VAT exemption
Currently translated at 100.0% (29 of 29 strings)

Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_account_stamp
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_account_stamp/it/
[FIX] extra blank line
[FIX] typos in source strings
[IMP] readme, adapt to v.12.0 and add italian section
[IMP] __manifest__.py, set ITA name and summary
Currently translated at 100.0% (29 of 29 strings)

Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_account_stamp
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_account_stamp/it/
Currently translated at 100.0% (29 of 29 strings)

Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_account_stamp
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_account_stamp/it/
[FIX] 2 euro image file
[IMP] image on invoice to display stamp application
      and revert checkbox to previous position
[FIX] show button in draft edit mode only
Currently translated at 100.0% (30 of 30 strings)

Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_account_stamp
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_account_stamp/it/
Currently translated at 100.0% (30 of 30 strings)

Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_account_stamp
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_account_stamp/it/
Currently translated at 100.0% (30 of 30 strings)

Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_account_stamp
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_account_stamp/it/
Test case:

 - Create a product setting VAT "fuori campo" (price 1)
 - Configure "Tax Stamp 2 euro" product to apply to "fuori campo"
 - Create an invoice, add a line selecting the previously created product and setting unit price = 100

tax_stamp field stays false
@jado95 jado95 force-pushed the 16.0-mig-l10n_it_account_stamp branch from fed8e19 to 626443c Compare November 11, 2022 10:54
@jado95

jado95 commented Nov 11, 2022

Copy link
Copy Markdown
Contributor Author

Grazie della PR! Puoi squashare i commit amministrativi come indicato in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0#tasks-to-do-in-the-migration?

@SirTakobi Dovrebbe essere tutto ok

@SirTakobi SirTakobi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solo revisione del codice, per me è ok

@marcelofrare marcelofrare left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

provato su runboat

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@primes2h

Copy link
Copy Markdown
Contributor

Vado con il merge.

P.S.
Giusto come promemoria.
In un'ottica di convergenza con i moduli di Odoo S.A. sarà necessario modficare il termine "tax stamp".
Per "imposta di bollo" in l10n_it_edi viene usato "stamp duty", che è più corretto (come da specifiche AdE).

Se ne era parlato anche un bel po' di tempo fa: es. #706 (comment) e
#706 (comment)

@primes2h

Copy link
Copy Markdown
Contributor

/ocabot merge nobump

@OCA-git-bot

Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-3021-by-primes2h-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit e4062d1 into OCA:16.0 Nov 15, 2022
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 7c59279. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.