[16.0][MIG] fiscal_epos_print by Borruso · Pull Request #3060 · OCA/l10n-italy

Borruso · 2022-11-22T15:44:35Z

Migrazione v16

--
Confermo di aver firmato il CLA https://odoo-community.org/page/cla e di aver letto le linee guida su https://odoo-community.org/page/contributing

stevech091 · 2022-11-22T15:49:41Z

@Borruso ma l'E-POS sulla V16 non lo sta facendo Odoo SA ?

tafaRU · 2023-01-19T13:38:12Z

/ocabot migration fiscal_epos_print

tafaRU · 2023-02-17T11:04:43Z

@Borruso riporto qui quanto deciso nella chiamata di stamattina.
Ripartire dalla versione ora presente sulla 14.0 aggiungendo parti nuove in un commit a parte rispetto a quello della migrazione. Grazie!

micheledic · 2023-05-05T14:04:40Z

ragazzi ci sono update in merito ?

are-agilebg · 2023-05-24T14:27:02Z

+                            JSON.stringify(tag_list_names) +
+                            "\n" +
+                            JSON.stringify(add_info);
+                        // TODO is push_orders or push_single_order


AFAIK push_single_order è più corretto in quanto esegue il flush soltanto di questo ordine particolare, mentre push_orders può anche essere eseguito passando un singolo ordine ma questo viene aggiunto al localStorage degli ordini locali che poi vengono sincronizzati in toto.

Dai test che abbiamo eseguito è piuttosto importante che venga ripristinata l'istruzione di push a questo punto altrimenti al termine di ogni emissione scontrino sul POS (dalla seconda in avanti, non alla prima) viene visualizzato il popup con conferma "Ordini non sincronizzati residui" che richiede intervento manuale dell'operatore (vedi il blocco finally all'interno di _finalizeValidation() in PaymentScreen.js di point_of_sale)

aggiornato la PR
@are-agilebg puoi riprovare a fare quel test?

TonyMasciI

Due note:

i commenti che ho lasciato "Eliminare" li ho messi perché dato che esiste la PR mi aspetto che quelle parti non sono servite, e per il caso dei paths dei file nel manifest mi apsetto che vengano eliminati
Magari serve sicuramente un'altra persona che controlli la parte JS che diciamo non mi fideri più di tanto di me ;)

TonyMasciI · 2023-10-05T14:51:00Z

+    # def _prepare_done_order_for_pos(self):
+    #     res = super(PosOrder, self)._prepare_done_order_for_pos()
+    #     res["lottery_code"] = self.lottery_code
+    #     res["refund_date"] = self.refund_date
+    #     res["refund_report"] = self.refund_report
+    #     res["refund_doc_num"] = self.refund_doc_num
+    #     res["refund_cash_fiscal_serial"] = self.refund_cash_fiscal_serial
+    #     res["fiscal_receipt_number"] = self.fiscal_receipt_number
+    #     res["fiscal_receipt_amount"] = self.fiscal_receipt_amount
+    #     res["fiscal_receipt_date"] = self.fiscal_receipt_date
+    #     res["fiscal_z_rep_number"] = self.fiscal_z_rep_number
+    #     res["fiscal_printer_serial"] = self.fiscal_printer_serial
+    #     res["fiscal_printer_debug_info"] = self.fiscal_printer_debug_info
+    #     return res


Se non serve eliminare

TonyMasciI · 2023-10-05T15:07:12Z

+            // TODO CONTROLLARE SE SERVE
+            //        compute_all(taxes, price_unit, quantity, currency_rounding, handle_price_include=true) {
+            //            var res = super.compute_all(...arguments);
+            //            var self = this;
+            //
+            //            var total_excluded = round_pr(price_unit * quantity, currency_rounding);
+            //            var total_included = total_excluded;
+            //            var base = total_excluded;
+            //            var list_taxes = res.taxes;
+            // Amount_type 'group' not handled (used only for purchases, in Italy)
+            // _(taxes).each(function(tax) {
+            //            _(taxes).each(function (tax, index) {
+            //                if (!no_map_tax) {
+            //                    tax = self._map_tax_fiscal_position(tax);
+            //                }
+            //                if (!tax) {
+            //                    return;
+            //                }
+            //                var tax_amount = self._compute_all(tax[0], base, quantity);
+            //                tax_amount = round_pr(tax_amount, currency_rounding);
+            //                if (!tax_amount) {
+            //                    // Intervene here: also add taxes with 0 amount
+            //                    if (tax[0].price_include) {
+            //                        total_excluded -= tax_amount;
+            //                        base -= tax_amount;
+            //                    } else {
+            //                        total_included += tax_amount;
+            //                    }
+            //                    if (tax[0].include_base_amount) {
+            //                        base += tax_amount;
+            //                    }
+            //                    var data = {
+            //                        id: tax[0].id,
+            //                        amount: tax_amount,
+            //                        name: tax[0].name,
+            //                    };
+            //                    list_taxes.push(data);
+            //                }
+            //            });
+            //            res.taxes = list_taxes;
+            //
+            //            return res;
+            //        }


TonyMasciI · 2023-10-05T15:07:23Z

+    //    Class FiscalEposPrintPosModel extends PosModel {
+    //        constructor(obj, options) {
+    //            super(...arguments);
+    //            var tax_model = _.find(this.models, function (model) {
+    //                return model.model === "account.tax";
+    //            });
+    //            tax_model.fields.push("fpdeptax");
+    //        }
+    //    }
+    //    Registries.Model.add(FiscalEposPrintPosModel);


TonyMasciI · 2023-10-05T15:09:56Z

+            # TODO is this necessary?
+            # "fiscal_epos_print/static/src/js/popups.js",
+            # "fiscal_epos_print/static/src/js/pos_order_mgmt.js",


TonyMasciI · 2023-10-05T15:10:05Z

+            # TODO To be converted with new components system
+            # "fiscal_epos_print/static/src/xml/pos.xml",
+            # "fiscal_epos_print/static/src/xml/lottery.xml",


Borruso · 2023-10-05T16:34:30Z

Due note:

i commenti che ho lasciato "Eliminare" li ho messi perché dato che esiste la PR mi aspetto che quelle parti non sono servite, e per il caso dei paths dei file nel manifest mi apsetto che vengano eliminati

Magari serve sicuramente un'altra persona che controlli la parte JS che diciamo non mi fideri più di tanto di me ;)

fatto

matteoopenf · 2023-10-25T07:56:59Z

ci sono novita'?

BitStab · 2023-11-18T07:55:40Z

Se volete date un'occhiata qui: https://github.com/BitStab/l10n-italy/tree/16.0-mig-fiscal_epos_print/fiscal_epos_print
È una versione già in uso, ma customizzata con operatori fiscali, void (annullamento) e refund (reso parziale) funzionanti. Ho corretto un paio di errori che saltavano ognitanto, quando si chiudeva un operazione.

PR verso repository di Borruso è già aperto.

Co-authored-by: francesco-ooops <55489873+francesco-ooops@users.noreply.github.com>

… defaulting to "1"! Tested - is working great on FP82III RT

…eso Merce). Added Fiscal Operator to User and Employee

…illing the splitted lines twice in the end.

…_price is send to epson ref OCA#3721

OCA-git-bot · 2024-09-19T07:00:03Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

sergiocorato · 2024-10-04T07:48:26Z

/ocabot merge nobump

OCA-git-bot · 2024-10-04T07:48:33Z

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-3060-by-sergiocorato-bump-nobump, awaiting test results.

Signed-off-by sergiocorato

OCA-git-bot · 2024-10-04T08:47:06Z

It looks like something changed on 16.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 16.0-ocabot-merge-pr-3060-by-sergiocorato-bump-nobump, awaiting test results.

Signed-off-by sergiocorato

OCA-git-bot · 2024-10-04T09:46:06Z

It looks like something changed on 16.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 16.0-ocabot-merge-pr-3060-by-sergiocorato-bump-nobump, awaiting test results.

Signed-off-by sergiocorato

OCA-git-bot · 2024-10-04T10:34:09Z

It looks like something changed on 16.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 16.0-ocabot-merge-pr-3060-by-sergiocorato-bump-nobump, awaiting test results.

OCA-git-bot · 2024-10-04T11:24:06Z

Congratulations, your PR was merged at bfae041. Thanks a lot for contributing to OCA. ❤️

SirTakobi mentioned this pull request Nov 25, 2022

[14.0][mig] fiscal_epos_print #2761

Merged

Borruso force-pushed the 16.0-mig-fiscal_epos_print branch from 160239a to 963c8f6 Compare December 12, 2022 07:46

OCA-git-bot added this to the 16.0 milestone Jan 19, 2023

OCA-git-bot mentioned this pull request Jan 19, 2023

Migration to version 16.0 #2967

Open

81 tasks

Borruso force-pushed the 16.0-mig-fiscal_epos_print branch from 963c8f6 to da8e7fe Compare February 22, 2023 16:12

are-agilebg reviewed May 24, 2023

View reviewed changes

Borruso force-pushed the 16.0-mig-fiscal_epos_print branch 7 times, most recently from dc3d939 to 35ac919 Compare October 5, 2023 12:52

TonyMasciI suggested changes Oct 5, 2023

View reviewed changes

Borruso force-pushed the 16.0-mig-fiscal_epos_print branch from 35ac919 to 134da6d Compare October 5, 2023 16:33

Borruso requested a review from TonyMasciI October 5, 2023 16:34

TonyMasciI approved these changes Oct 6, 2023

View reviewed changes

Borruso requested a review from are-agilebg October 6, 2023 12:45

Borruso force-pushed the 16.0-mig-fiscal_epos_print branch from 134da6d to 73ad49f Compare October 6, 2023 13:01

francesco-ooops added 16.0 migration labels Dec 20, 2023

Borruso added a commit to DinamicheAziendali/l10n-italy that referenced this pull request Jan 3, 2024

[ADD] fiscal_epos_print: aggiunta PR OCA#3060

f510b56

Borruso mentioned this pull request Jan 12, 2024

PR aggiunte v16 DinamicheAziendali/l10n-italy#1

Open

14 tasks

monen17 and others added 13 commits September 18, 2024 10:19

[FIX] fiscal_epos_print: Validate tax in batch

d3c43d6

[12.0][FIX] fiscal_epos_print, missing translation

8ee5a4a

[IMP] fiscal_epos_print: black, isort, prettier

b1b59a8

[MIG] fiscal_epos_print: Migration to 14.0

c2f957f

[FIX] eslint errors

b749d8d

Update fiscal_epos_print/readme/CONFIGURE.rst

4603c0f

Co-authored-by: francesco-ooops <55489873+francesco-ooops@users.noreply.github.com>

[IMP] fiscal_epos_print: pre-commit stuff

0481a4d

[MIG] fiscal_epos_print: Migration to 16.0

d979082

Fixed "order is unavailable" error after print. Added Fiscal Operator…

984bdd1

… defaulting to "1"! Tested - is working great on FP82III RT

Fixed full refund (VOID, ex annullamento) and partially refund (ex. R…

8d80e4b

…eso Merce). Added Fiscal Operator to User and Employee

Fixed Bug: Using split function on payment re-creats the old order, b…

fe301b8

…illing the splitted lines twice in the end.

[FIX] fiscal_epos_print: fix duplicazione ordine pos

07c918a

[FIX][fiscal_epos_print] resolve round of line of price when the full…

0f52ec2

…_price is send to epson ref OCA#3721

Borruso force-pushed the 16.0-mig-fiscal_epos_print branch from 553e4f1 to 0f52ec2 Compare September 18, 2024 08:27

OCA-git-bot added the ready to merge label Sep 19, 2024

SirAionTech removed the needs fixing Has conflicts or is failing mandatory CI checks label Sep 19, 2024

OCA-git-bot added a commit that referenced this pull request Oct 4, 2024

Merge PR #3060 into 16.0

bb89dbd

Signed-off-by sergiocorato

OCA-git-bot added the bot is merging ⏳ label Oct 4, 2024

OCA-git-bot added a commit that referenced this pull request Oct 4, 2024

Merge PR #3060 into 16.0

b24242d

Signed-off-by sergiocorato

OCA-git-bot added a commit that referenced this pull request Oct 4, 2024

Merge PR #3060 into 16.0

c68d11d

Signed-off-by sergiocorato

OCA-git-bot merged commit 1c50936 into OCA:16.0 Oct 4, 2024

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Oct 4, 2024

Uh oh!

Conversation

Borruso commented Nov 22, 2022

Uh oh!

stevech091 commented Nov 22, 2022

Uh oh!

tafaRU commented Jan 19, 2023

Uh oh!

tafaRU commented Feb 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

micheledic commented May 5, 2023

Uh oh!

are-agilebg May 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Borruso Oct 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TonyMasciI left a comment

Choose a reason for hiding this comment

Uh oh!

TonyMasciI Oct 5, 2023

Choose a reason for hiding this comment

Uh oh!

TonyMasciI Oct 5, 2023

Choose a reason for hiding this comment

Uh oh!

TonyMasciI Oct 5, 2023

Choose a reason for hiding this comment

Uh oh!

TonyMasciI Oct 5, 2023

Choose a reason for hiding this comment

Uh oh!

TonyMasciI Oct 5, 2023

Choose a reason for hiding this comment

Uh oh!

Borruso commented Oct 5, 2023

Uh oh!

matteoopenf commented Oct 25, 2023

Uh oh!

BitStab commented Nov 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OCA-git-bot commented Sep 19, 2024

Uh oh!

sergiocorato commented Oct 4, 2024

Uh oh!

OCA-git-bot commented Oct 4, 2024

Uh oh!

OCA-git-bot commented Oct 4, 2024

Uh oh!

OCA-git-bot commented Oct 4, 2024

Uh oh!

OCA-git-bot commented Oct 4, 2024

Uh oh!

OCA-git-bot commented Oct 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

tafaRU commented Feb 17, 2023 •

edited

Loading

are-agilebg May 24, 2023 •

edited

Loading

Borruso Oct 5, 2023 •

edited

Loading

BitStab commented Nov 18, 2023 •

edited

Loading