Skip to content

[16.0][MIG] l10n_it_pos_fiscalcode#3079

Merged
OCA-git-bot merged 7 commits into
OCA:16.0from
Borruso:16.0-mig-l10n_it_pos_fiscalcode
Oct 5, 2023
Merged

[16.0][MIG] l10n_it_pos_fiscalcode#3079
OCA-git-bot merged 7 commits into
OCA:16.0from
Borruso:16.0-mig-l10n_it_pos_fiscalcode

Conversation

@Borruso

@Borruso Borruso commented Dec 2, 2022

Copy link
Copy Markdown
Contributor

Migration l10n_it_pos_fiscalcode from 14.0 to 16.0

--
Confermo di aver firmato il CLA https://odoo-community.org/page/cla e di aver letto le linee guida su https://odoo-community.org/page/contributing

@Borruso Borruso mentioned this pull request Dec 2, 2022
Open
81 tasks
@TheMule71

TheMule71 commented Dec 2, 2022

Copy link
Copy Markdown
Contributor

/ocabot migration l10n_it_pos_fiscalcode

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Dec 2, 2022
TonyMasciI
TonyMasciI approved these changes Dec 6, 2022
View reviewed changes

@TonyMasciI TonyMasciI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revisione Tecnica:

  • Installazione OK

Revisione Funzionale (fatta solo perché ho notato una cosa):

  • Se si installa il modulo automaticamente Odoo installa l10n_it_edi (Penso sia il fatto che ha questa RIGA nel manifest) e si ha un doppio campo di codice fiscale:

immagine

immagino che con il convergere verso lo Odoo questo problema si risolverà

@marcelofrare

marcelofrare commented Sep 7, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • l10n_it_edi

quindi penso sia un NON problema:
Chi deciderà di tenersi e usare l10n_it_edi, non avrà bisogno di questo modulo.
Chi invece decide usare l10n_it_fatturapa deve disinstallare l10n_it_edi e installare questo modulo.

l10n-italy/l10n_it_fatturapa/__manifest__.py

Line 16 in a6d9cd4

"excludes": ["l10n_it_edi"],

marcelofrare
marcelofrare approved these changes Sep 7, 2023
View reviewed changes

@marcelofrare marcelofrare left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eLBati

eLBati commented Sep 7, 2023

Copy link
Copy Markdown
Member

Revisione Tecnica:

* Installazione OK

Revisione Funzionale (fatta solo perché ho notato una cosa):

* Se si installa il modulo automaticamente Odoo installa l10n_it_edi (Penso sia il fatto che ha questa [RIGA](https://github.com/odoo/odoo/blob/16.0/addons/l10n_it_edi/__manifest__.py#L15) nel manifest) e si ha un doppio campo di codice fiscale:

immagine

immagino che con il convergere verso lo Odoo questo problema si risolverà

Il campo del codice fiscale viene aggiunto da l10n_it_fiscalcode che quindi a questo punto andrebbe messo anche lui come incompatibile con l10n_it_edi

eLBati and others added 7 commits September 7, 2023 14:32
@eLBati @Borruso
ADD l10n_it_pos_fiscalcode
f693060 
The module adds fiscal code field to partner form within point of sale interface,
allowing to view and edit it

[UPD] Update l10n_it_pos_fiscalcode.pot

[UPD] README.rst
@eLBati @Borruso
Added translation using Weblate (Italian)
2421378
@eLBati @Borruso
Translated using Weblate (Italian)
3d8b8be 
Currently translated at 100.0% (2 of 2 strings)

Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_pos_fiscalcode
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_pos_fiscalcode/it/
@labaggio @Borruso
merge PR 1264 1717 1728 1737 1739
3f91aa2
@iwkse @Borruso
[14.0][MIG] l10n_it_pos_fiscalcode
d1e95fa
@Borruso
[IMP] l10n_it_pos_fiscalcode: pre-commit stuff
9e43007
@Borruso
[MIG] l10n_it_pos_fiscalcode: Migration to 16.0
c299a43
@Borruso Borruso force-pushed the 16.0-mig-l10n_it_pos_fiscalcode branch from 0ea1fd7 to c299a43 Compare September 7, 2023 12:35
andreampiovesana
andreampiovesana approved these changes Oct 5, 2023
View reviewed changes

@andreampiovesana andreampiovesana left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - test funzionale

image

@OpenCode

OpenCode commented Oct 5, 2023

Copy link
Copy Markdown
Contributor

/ocabot merge nobump

@OCA-git-bot

OCA-git-bot commented Oct 5, 2023

Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-3079-by-OpenCode-bump-nobump, awaiting test results.

@OCA-git-bot

OCA-git-bot commented Oct 5, 2023

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at ebc8d75. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot closed this Oct 5, 2023
@OCA-git-bot OCA-git-bot merged commit ea1da6e into OCA:16.0 Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@andreampiovesana andreampiovesana andreampiovesana approved these changes

@marcelofrare marcelofrare marcelofrare approved these changes

@TonyMasciI TonyMasciI TonyMasciI approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

16.0 approved merged 🎉 migration needs functional review

Projects

None yet

Milestone

16.0

Development

Successfully merging this pull request may close these issues.
⚡