Skip to content

[16.0][MIG] l10n_it_declaration_of_intent#3081

Merged
OCA-git-bot merged 14 commits into
OCA:16.0from
tafaRU:16.0-mig-l10n_it_declaration_of_intent
Dec 23, 2022
Merged

[16.0][MIG] l10n_it_declaration_of_intent#3081
OCA-git-bot merged 14 commits into
OCA:16.0from
tafaRU:16.0-mig-l10n_it_declaration_of_intent

Conversation

@tafaRU

@tafaRU tafaRU commented Dec 2, 2022

Copy link
Copy Markdown
Member

No description provided.

@tafaRU tafaRU force-pushed the 16.0-mig-l10n_it_declaration_of_intent branch 2 times, most recently from baf8320 to 482747e Compare December 2, 2022 19:05
@tafaRU tafaRU changed the title [16.0][MIG] l10n it declaration of intent [16.0][MIG] l10n_it_declaration_of_intent Dec 3, 2022
SimoRubi and others added 11 commits December 5, 2022 11:08
…ing optimizations available in 14.0.

Use common accounting methods for tests setup
Roadmap comment on currency
Shortcut for purchase and sale documents
Simplify amount computation for declaration lines
Check move_type only for short_type computation
Apply date filter only if there is a date
…eclaration_residual_amounts method and KeyError exception in check_declarations_amounts.
… execution such as following:

2022-02-08 08:10:43,744 111657 WARNING 14.0-test-pr2640 odoo.tests.common.onchange: The sequence format has changed. It was previously 'Test invoice 3' and it is now 'Test invoice no valid taxes'.

The sequence will never restart.
The incrementing number in this case is '0'.
2022-02-08 08:10:44,608 111657 WARNING 14.0-test-pr2640 odoo.tests.common.onchange: The sequence format has changed. It was previously 'Test invoice no valid taxes' and it is now 'Test invoice future'.

See https://github.com/OCA/l10n-italy/runs/5100117472?check_suite_focus=true#step:8:334 for further info
Currently translated at 95.9% (71 of 74 strings)

Translation: l10n-italy-14.0/l10n-italy-14.0-l10n_it_declaration_of_intent
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_declaration_of_intent/it/
Currently translated at 97.2% (72 of 74 strings)

Translation: l10n-italy-14.0/l10n-italy-14.0-l10n_it_declaration_of_intent
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_declaration_of_intent/it/
…voices' notes when an invoice is set back to draft and then validated again

Co-authored-by: SilvioGregorini <silviogregorini@openforce.it>
@tafaRU tafaRU force-pushed the 16.0-mig-l10n_it_declaration_of_intent branch 2 times, most recently from 06ef3c4 to 8536e11 Compare December 5, 2022 10:25
@tafaRU tafaRU marked this pull request as ready for review December 5, 2022 10:29
@tafaRU tafaRU force-pushed the 16.0-mig-l10n_it_declaration_of_intent branch from 8536e11 to 33f0ec4 Compare December 5, 2022 10:33
@elvise

elvise commented Dec 5, 2022

Copy link
Copy Markdown

@tafaRU puoi verificare il runboat ?

@francesco-ooops

Copy link
Copy Markdown
Contributor

@tafaRU puoi verificare il runboat ?

mi sembra un problema comune a molte PR, ho chiesto a sbidoul qui: https://discord.com/channels/737652535149592587/761225067798462465/1049309010148466749

@tafaRU

tafaRU commented Dec 5, 2022

Copy link
Copy Markdown
Member Author

ho chiesto a sbidoul qui: https://discord.com/channels/737652535149592587/761225067798462465/1049309010148466749

Grazie, attendiamo pertanto una sua risposta prima di provare a scatenare una nuova build.

@francesco-ooops

Copy link
Copy Markdown
Contributor

@tafaRU da discord: There was a certificate issue that I worked around yesterday evening. Please push something to retry and tell me if that works.

@tafaRU

tafaRU commented Dec 6, 2022

Copy link
Copy Markdown
Member Author

/ocabot rebase

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, PR rebased to 16.0.

@tafaRU tafaRU force-pushed the 16.0-mig-l10n_it_declaration_of_intent branch from 33f0ec4 to 47c4ce8 Compare December 6, 2022 07:50
@francesco-ooops

Copy link
Copy Markdown
Contributor

@elvise si può comunque accedere ai runboat da https://runboat.odoo-community.org/webui/builds.html?repo=OCA/l10n-italy&target_branch=16.0 (se reggono)

@tafaRU

tafaRU commented Dec 6, 2022

Copy link
Copy Markdown
Member Author

@francesco-ooops

(se reggono)

direi di no, purtroppo il log https://runboat.odoo-community.org/api/v1/builds/bfedf2679-9faf-401b-8341-803ef57fb6db/init-log resituisce Internal Server Error.

@andreampiovesana andreampiovesana left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File "/home/odoo-dev/odoo-dev16/PR/l10n_it_declaration_of_intent/models/sale.py", line 28, in onchange_partner_id
res = super(SaleOrder, self).onchange_partner_id()
AttributeError: 'super' object has no attribute 'onchange_partner_id'

@tafaRU tafaRU force-pushed the 16.0-mig-l10n_it_declaration_of_intent branch 3 times, most recently from 18ba99a to 1121999 Compare December 12, 2022 15:23
@tafaRU tafaRU force-pushed the 16.0-mig-l10n_it_declaration_of_intent branch from 1121999 to 5441620 Compare December 12, 2022 15:27
@tafaRU

tafaRU commented Dec 12, 2022

Copy link
Copy Markdown
Member Author

@andreampiovesana puoi ritestare?

@andreampiovesana

Copy link
Copy Markdown
Contributor

@andreampiovesana puoi ritestare?

OK

@andreampiovesana andreampiovesana left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
test funzionale ok

@marcelofrare marcelofrare left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runboat is OK

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@eLBati

eLBati commented Dec 23, 2022

Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot

Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-3081-by-eLBati-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 1165d32 into OCA:16.0 Dec 23, 2022
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 27405c0. Thanks a lot for contributing to OCA. ❤️

@tafaRU tafaRU deleted the 16.0-mig-l10n_it_declaration_of_intent branch December 23, 2022 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.