Skip to content

[16.0] [MIG] l10n_it_vat_statement_communication#3137

Merged
OCA-git-bot merged 28 commits into
OCA:16.0from
saydigital:16.0-mig-l10n_it_vat_statement_communication
Sep 12, 2023
Merged

[16.0] [MIG] l10n_it_vat_statement_communication#3137
OCA-git-bot merged 28 commits into
OCA:16.0from
saydigital:16.0-mig-l10n_it_vat_statement_communication

Conversation

@TonyMasciI

Copy link
Copy Markdown
Contributor

No description provided.

@TonyMasciI TonyMasciI mentioned this pull request Jan 16, 2023
81 tasks
@tafaRU

tafaRU commented Jan 16, 2023

Copy link
Copy Markdown
Member

/ocabot migration l10n_it_vat_statement_communication

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jan 16, 2023
@TonyMasciI TonyMasciI force-pushed the 16.0-mig-l10n_it_vat_statement_communication branch 2 times, most recently from 622865f to 6c91f06 Compare February 6, 2023 12:03
@TonyMasciI TonyMasciI marked this pull request as ready for review February 6, 2023 13:03
@andreampiovesana

Copy link
Copy Markdown
Contributor

l10n_it_vat_statement_communication.models.comunicazione_liquidazione is not overriding the create method in batch

@TonyMasciI

Copy link
Copy Markdown
Contributor Author

l10n_it_vat_statement_communication.models.comunicazione_liquidazione is not overriding the create method in batch

Intendi aggiungere il decoratore @api.model_create_multi ?

@andreampiovesana

Copy link
Copy Markdown
Contributor

puoi rinominare in:
[16.0] [MIG] l10n_it_vat_statement_communication

@andreampiovesana

Copy link
Copy Markdown
Contributor

l10n_it_vat_statement_communication.models.comunicazione_liquidazione is not overriding the create method in batch

Intendi aggiungere il decoratore @api.model_create_multi ?

si

@TonyMasciI

Copy link
Copy Markdown
Contributor Author

l10n_it_vat_statement_communication.models.comunicazione_liquidazione is not overriding the create method in batch

Intendi aggiungere il decoratore @api.model_create_multi ?

si

ok

@TonyMasciI TonyMasciI force-pushed the 16.0-mig-l10n_it_vat_statement_communication branch from 6c91f06 to 91f802f Compare June 9, 2023 07:33
@TonyMasciI TonyMasciI changed the title 16.0 mig l10n it vat statement communication [16.0] [MIG] l10n_it_vat_statement_communication Jun 9, 2023
@TonyMasciI TonyMasciI force-pushed the 16.0-mig-l10n_it_vat_statement_communication branch 2 times, most recently from 1940c1a to 08c4bb6 Compare June 9, 2023 08:26

@MaurizioPellegrinet MaurizioPellegrinet left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreampiovesana andreampiovesana left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@SirTakobi SirTakobi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie della PR!
Ci sono anche modifiche a l10n_it_declaration_of_intent, le puoi rimuovere?

Puoi schiacciare i commit dei bot come descritto in https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate?

@TonyMasciI TonyMasciI force-pushed the 16.0-mig-l10n_it_vat_statement_communication branch from 08c4bb6 to 460a0da Compare August 4, 2023 13:08
@TonyMasciI

Copy link
Copy Markdown
Contributor Author

Grazie della PR! Ci sono anche modifiche a l10n_it_declaration_of_intent, le puoi rimuovere?

Puoi schiacciare i commit dei bot come descritto in https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate?

@SirTakobi Puoi dare un occhio anche tu se non ci sono più commit dei bot, in caso possiamo andare avanti! Grazie!

@SirTakobi

Copy link
Copy Markdown
Contributor

@SirTakobi Puoi dare un occhio anche tu se non ci sono più commit dei bot, in caso possiamo andare avanti! Grazie!

Me la son segnata, quando ho tempo ci guardo

@tafaRU tafaRU left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commit dei bot ora son 👌

Comment thread l10n_it_vat_statement_communication/models/comunicazione_liquidazione.py Outdated
Comment thread l10n_it_vat_statement_communication/models/comunicazione_liquidazione.py Outdated
eLBati and others added 19 commits September 12, 2023 11:38
…l’art. 7 del d.P.R. 14 ottobre 1999, n.542, relativamente al 4° trimestre
Currently translated at 100.0% (135 of 135 strings)

Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_vat_statement_communication
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_vat_statement_communication/it/
…ion method" to be set when "Down payment due" is set
…bytes or unicode, got 'int'

l10n_it_vat_statement_communication/models/comunicazione_liquidazione.py", line 268, in _export_xml_get_frontespizio
    x1_2_1_5_UltimoMese.text = self.last_month
  File "src/lxml/lxml.etree.pyx", line 1031, in lxml.etree._Element.text.__set__ (src/lxml/lxml.etree.c:53218)
  File "src/lxml/apihelpers.pxi", line 715, in lxml.etree._setNodeText (src/lxml/lxml.etree.c:24413)
  File "src/lxml/apihelpers.pxi", line 703, in lxml.etree._createTextNode (src/lxml/lxml.etree.c:24276)
  File "src/lxml/apihelpers.pxi", line 1441, in lxml.etree._utf8 (src/lxml/lxml.etree.c:31470)
TypeError: Argument must be bytes or unicode, got 'int'
…ato per la liquidazione trimestrale ai sensi dell’art. 7 del D.P.R. n. 542/99 devono indicare “5” per il quarto trimestre
…code_company

File "/home/odoo/custom-addons/OCA/l10n-italy/l10n_it_vat_statement_communication/models/comunicazione_liquidazione.py", line 291, in _export_xml_get_frontespizio self.declarant_fiscalcode_company.code AttributeError: 'str' object has no attribute 'code'
Currently translated at 95.7% (135 of 141 strings)

Translation: l10n-italy-14.0/l10n-italy-14.0-l10n_it_vat_statement_communication
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_vat_statement_communication/it/
@TonyMasciI TonyMasciI force-pushed the 16.0-mig-l10n_it_vat_statement_communication branch from 9cbd219 to 9f773c4 Compare September 12, 2023 09:38
@TonyMasciI

Copy link
Copy Markdown
Contributor Author

@tafaRU puoi provare nuovamente il merge?

@tafaRU

tafaRU commented Sep 12, 2023

Copy link
Copy Markdown
Member

Solo una nota: per le prossime volte, quando fai una modifica e fai push force è preferibile non fare rebase altrimenti le tue modifiche si annegano con quelle provenienti da upstream rendendo la review più lunga e difficoltosa. Grazie.

/ocabot merge nobump

@OCA-git-bot

Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-3137-by-tafaRU-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d246bdc into OCA:16.0 Sep 12, 2023
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at f591b28. Thanks a lot for contributing to OCA. ❤️

@TonyMasciI

Copy link
Copy Markdown
Contributor Author

Solo una nota: per le prossime volte, quando fai una modifica e fai push force è preferibile non fare rebase altrimenti le tue modifiche si annegano con quelle provenienti da upstream rendendo la review più lunga e difficoltosa. Grazie.

/ocabot merge nobump

Ok va bene!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.