[FIX] assets_management: correct permission management#3281
Merged
Conversation
22 tasks
HekkiMelody
approved these changes
Jul 6, 2023
Contributor
|
Avrei proposto anche due livelli (user e manager) ma per ora partiamo così, meglio della situazione precedente. |
Contributor
|
@PicchiSeba puoi far ricostruire il runboat? |
PicchiSeba
force-pushed
the
14.0-assets
branch
from
50a3f4f to
9ff23cd
Compare
Contributor
|
This PR has the |
Contributor
|
/ocabot merge minor |
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
Congratulations, your PR was merged at 13c7bb3. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous version allowed
base.group_userto access the assets with full read/write permissions from their url even if they were hidden from them in the menus.With this PR we aim to correctly manage user permissions, already implemented but never used.
Also, child menu items were being used with redundant group permission already specified by the parent.