Skip to content

[MIG] l10n_it_pos_fatturapa: Migration to 14.0#3315

Closed
caiuka wants to merge 4 commits into
OCA:14.0from
berim-it:14.0-mig-l10n_it_pos_fatturapa
Closed

[MIG] l10n_it_pos_fatturapa: Migration to 14.0#3315
caiuka wants to merge 4 commits into
OCA:14.0from
berim-it:14.0-mig-l10n_it_pos_fatturapa

Conversation

@caiuka

@caiuka caiuka commented May 19, 2023

Copy link
Copy Markdown

Migrazione del modulo dalla v12 alla v14

@francesco-ooops francesco-ooops left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review ok!

@francesco-ooops

Copy link
Copy Markdown
Contributor

@robyf70 che ne pensi?

@francesco-ooops

Copy link
Copy Markdown
Contributor

possiamo aggiungere a #1905 ?

@OpenCode OpenCode mentioned this pull request May 25, 2023
76 tasks
@OpenCode

Copy link
Copy Markdown
Contributor

possiamo aggiungere a #1905 ?

Fatto

Comment on lines +9 to +11
constructor() {
super(...arguments);
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non mi pare sia strettamente necessario

@francesco-ooops

Copy link
Copy Markdown
Contributor

@robyf70 quando hai un momento ;)

@robyf70 robyf70 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il resto LGTM

@api.model
def create_from_ui(self, partner):
if "electronic_invoice_subjected" in partner:
electronic_invoice_subjected = bool(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La get() non ritorna un bool?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, ritorna un None

Comment on lines +9 to +11
constructor() {
super(...arguments);
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non necessario

@caiuka caiuka force-pushed the 14.0-mig-l10n_it_pos_fatturapa branch from 02b7ed3 to be4b8bb Compare June 8, 2023 06:30
@francesco-ooops

Copy link
Copy Markdown
Contributor

@robyf70 @GSLabIt ok ora?

@francesco-ooops

Copy link
Copy Markdown
Contributor

@caiuka rebase

@caiuka caiuka force-pushed the 14.0-mig-l10n_it_pos_fatturapa branch 3 times, most recently from 3b1cd83 to 321c236 Compare June 23, 2023 09:33
@caiuka caiuka closed this Jun 29, 2023
@caiuka caiuka deleted the 14.0-mig-l10n_it_pos_fatturapa branch June 29, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants