Skip to content

[16.0][MIG] l10n_it_intrastat_statement#3327

Merged
OCA-git-bot merged 43 commits into
OCA:16.0from
Borruso:16.0-mig-l10n_it_intrastat_statement
Oct 6, 2023
Merged

[16.0][MIG] l10n_it_intrastat_statement#3327
OCA-git-bot merged 43 commits into
OCA:16.0from
Borruso:16.0-mig-l10n_it_intrastat_statement

Conversation

@Borruso

@Borruso Borruso commented May 25, 2023

Copy link
Copy Markdown
Contributor

Migration l10n_it_intrastat_statement from 14.0 to 16.0

--
Confermo di aver firmato il CLA https://odoo-community.org/page/cla e di aver letto le linee guida su https://odoo-community.org/page/contributing

@Borruso Borruso mentioned this pull request May 25, 2023
81 tasks
@tafaRU

tafaRU commented May 25, 2023

Copy link
Copy Markdown
Member

/ocabot migration l10n_it_intrastat_statement

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone May 25, 2023
@Borruso Borruso force-pushed the 16.0-mig-l10n_it_intrastat_statement branch 3 times, most recently from f0e1064 to 3294771 Compare May 25, 2023 09:01
@Borruso Borruso force-pushed the 16.0-mig-l10n_it_intrastat_statement branch from 3294771 to c5e310a Compare July 21, 2023 12:24
@TheMule71

Copy link
Copy Markdown
Contributor

Pura curiosità, vedo https://github.com/Borruso/l10n-italy/blob/c5e310ae4fd0da8e941ed7ba6558bb3bce55755e/l10n_it_intrastat_statement/report/report_intrastat_mod1.xml#L7
che usano web.internal_layout, c'entra qualcosa con l10n_it_account.internal_layout e sarebbe meglio usare quello o non c'entra nulla?

@Borruso

Borruso commented Sep 8, 2023

Copy link
Copy Markdown
Contributor Author

Pura curiosità, vedo https://github.com/Borruso/l10n-italy/blob/c5e310ae4fd0da8e941ed7ba6558bb3bce55755e/l10n_it_intrastat_statement/report/report_intrastat_mod1.xml#L7 che usano web.internal_layout, c'entra qualcosa con l10n_it_account.internal_layout e sarebbe meglio usare quello o non c'entra nulla?

in realtà non ti so dire c'è la stessa cosa in v14

@SirAionTech SirAionTech left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I test sono ❌, puoi verificare?

@Borruso Borruso force-pushed the 16.0-mig-l10n_it_intrastat_statement branch from c5e310a to c1b5b6d Compare September 29, 2023 12:53
@Borruso

Borruso commented Sep 29, 2023

Copy link
Copy Markdown
Contributor Author

I test sono ❌, puoi verificare?

fatto rabase test rossi per dipendenza

@primes2h

Copy link
Copy Markdown
Contributor

@Borruso
ci sarebbe da aggiungere qeusto commit b92edb2

@Borruso

Borruso commented Sep 30, 2023

Copy link
Copy Markdown
Contributor Author

@Borruso ci sarebbe da aggiungere qeusto commit b92edb2

@primes2h ecco a te #3622
appena si mergia qui faccio un rebase

@primes2h

primes2h commented Oct 2, 2023

Copy link
Copy Markdown
Contributor

@Borruso ci sarebbe da aggiungere qeusto commit b92edb2

@primes2h ecco a te #3622 appena si mergia qui faccio un rebase

Grazie!

@SirAionTech SirAionTech left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie della PR!
Manca qualche commit di 14.0, tipo e7c3c5e, li potresti aggiungere?

Ci sono traduzioni consecutive dello stesso traduttore, ad esempio
image
, le potresti schiacciare come indicato in https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate?

Comment on lines +31 to +38
if self.env.ref(
"l10n_it_intrastat_statement.wizard_account_intrastat_export_file"
):
view_id = self.env.ref(
"l10n_it_intrastat_statement.wizard_account_intrastat_export_file"
).id
else:
view_id = False

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

È possibile evitare di cercare più volte lo stesso riferimento esterno? Va bene che sono nella cache ma è comunque un'operazione che si può evitare.
Penso che questo sia più vicino al codice del modulo prima della migrazione, cosa ne pensi?

Suggested change
if self.env.ref(
"l10n_it_intrastat_statement.wizard_account_intrastat_export_file"
):
view_id = self.env.ref(
"l10n_it_intrastat_statement.wizard_account_intrastat_export_file"
).id
else:
view_id = False
view = self.env.ref(
"l10n_it_intrastat_statement.wizard_account_intrastat_export_file"
)
view_id = view.id

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fatto

Lara Baggio and others added 13 commits October 3, 2023 08:19
Currently translated at 77.2% (149 of 193 strings)

Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_intrastat_statement
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_intrastat_statement/it/
Currently translated at 99.0% (191 of 193 strings)

Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_intrastat_statement
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_intrastat_statement/it/
Currently translated at 6.2% (12 of 193 strings)

Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_intrastat_statement
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_intrastat_statement/es/
Prevent following error when computing statement:
psycopg2.ProgrammingError: can't adapt type 'account.intrastat.transport'
Currently translated at 100.0% (193 of 193 strings)

Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_intrastat_statement
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_intrastat_statement/es/
@Borruso Borruso force-pushed the 16.0-mig-l10n_it_intrastat_statement branch from c1b5b6d to 501deea Compare October 3, 2023 06:20
@Borruso

Borruso commented Oct 3, 2023

Copy link
Copy Markdown
Contributor Author

Grazie della PR! Manca qualche commit di 14.0, tipo e7c3c5e, li potresti aggiungere?

Ci sono traduzioni consecutive dello stesso traduttore, ad esempio image , le potresti schiacciare come indicato in https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate?

fatto

@SirAionTech

Copy link
Copy Markdown
Contributor

Grazie della PR! Manca qualche commit di 14.0, tipo e7c3c5e, li potresti aggiungere?
Ci sono traduzioni consecutive dello stesso traduttore, ad esempio image , le potresti schiacciare come indicato in https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate?

fatto

Grazie, quando hai finito con le modifiche ricorda per favore di chiedermi di aggiornare la revisione in
image

@SirAionTech SirAionTech left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manca qualche commit di 14.0, tipo e7c3c5e, li potresti aggiungere?

@Borruso Borruso requested a review from SirAionTech October 5, 2023 13:51
@Borruso Borruso force-pushed the 16.0-mig-l10n_it_intrastat_statement branch from cba2e82 to a7d7a99 Compare October 5, 2023 14:01

@andreampiovesana andreampiovesana left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - functional test ok

@MaurizioPellegrinet MaurizioPellegrinet left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tafaRU

tafaRU commented Oct 6, 2023

Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-3327-by-tafaRU-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 04e7b0b into OCA:16.0 Oct 6, 2023
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 61d271e. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.