Skip to content

[14.0][FIX] assets_management get only not null dates #3346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OCA-git-bot merged 1 commit into from
Feb 28, 2024
Merged

[14.0][FIX] assets_management get only not null dates #3346

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions assets_management/wizard/account_move_manage_asset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,15 +513,19 @@ def get_partial_dismiss_asset_vals(self):
fund_amt = self.depreciated_fund_amount
purchase_amt = self.asset_purchase_amount

max_date = max(asset.depreciation_ids.mapped("last_depreciation_date"))
if max_date and max_date > dismiss_date:
raise ValidationError(
_(
"Cannot dismiss an asset earlier than the last depreciation"
" date.\n"
"(Dismiss date: {}, last depreciation date: {})."
).format(dismiss_date, max_date)
)
last_depreciation_dates = asset.depreciation_ids.filtered(
"last_depreciation_date"
).mapped("last_depreciation_date")
if last_depreciation_dates:
max_date = max(last_depreciation_dates)
if max_date > dismiss_date:
raise ValidationError(
_(
"Cannot dismiss an asset earlier than the last depreciation"
" date.\n"
"(Dismiss date: {}, last depreciation date: {})."
).format(dismiss_date, max_date)
)

move = self.move_line_ids.mapped("move_id")
move_nums = move.name
Expand Down
⚡