[16.0] [MIG] l10n_it_website_portal_fatturapa by Borruso · Pull Request #3406 · OCA/l10n-italy

Borruso · 2023-06-26T12:45:18Z

Migration l10n_it_website_portal_fatturapa 12.0 to 16.0

--
Confermo di aver firmato il CLA https://odoo-community.org/page/cla e di aver letto le linee guida su https://odoo-community.org/page/contributing

tafaRU · 2023-06-26T12:47:32Z

/ocabot migration l10n_it_website_portal_fatturapa

SirAionTech

Grazie della PR!
Puoi schiacciare i commit come descritto in https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate?

SirAionTech · 2023-10-05T13:52:45Z

+    "author": "Odoo Community Association (OCA)",
+    "category": "Localization/Italy",
+    "website": "https://github.com/OCA/l10n-italy"
+    "/tree/12.0/l10n_it_website_portal_fatturapa",


Suggested change

"/tree/12.0/l10n_it_website_portal_fatturapa",

"/tree/16.0/l10n_it_website_portal_fatturapa",

La modifica andrebbe nel commit di migrazione

SirAionTech · 2023-10-05T14:50:59Z

+            country_italy = request.env.ref("base.it", raise_if_not_found=False)
+            country_id = data.get("country_id", False)
+            if country_id and country_italy and int(country_id) != country_italy.id:
+                data["codice_destinatario"] = "XXXXXXX"
+            elif data.get("codice_destinatario") == "XXXXXXX":
+                data["codice_destinatario"] = "0000000"


Queste modifiche sono necessarie per la migrazione alla 16.0?
Se non è così, sarebbero da spostare in un commit a parte, o anche in una PR a parte, e ci sarebbe da aprire la issue di tracciamento come descritto in https://github.com/OCA/l10n-italy/wiki/Team-di-sviluppo#apertura-issue

Giusto per completezza, vengono da #2520 (comment)

fatta issue #3644

SirAionTech · 2023-10-05T14:51:10Z

+    "author": "Odoo Community Association (OCA)",
+    "category": "Localization/Italy",
+    "website": "https://github.com/OCA/l10n-italy"
+    "/tree/12.0/l10n_it_website_portal_fatturapa",


La modifica andrebbe nel commit di migrazione

SirAionTech · 2023-10-05T14:58:02Z

-            if (!$is_pa[0].checked) {
-                $codice_destinatario_div.show();
-                $pec_destinatario_div.show();
-            } else {
-                $codice_destinatario_div.hide();
-                $pec_destinatario_div.hide();
+                var compute_destinatario_fields_visibility = function () {
+                    if ($is_pa[0].checked) {
+                        $codice_destinatario_div.hide();
+                        $pec_destinatario_div.hide();
+                    } else {
+                        $codice_destinatario_div.show();
+                        $pec_destinatario_div.show();


Questa è l'unica modifica necessaria per far contento pre-commit, che altrimenti dice:

l10n_it_website_portal_fatturapa/static/src/js/l10n_it_website_portal_fatturapa.js
40:13 warning Unexpected negated condition no-negated-condition

per il resto del file puoi ripristinare il codice che c'era prima?

fatto ma questa riga ho dovuto eliminarla perché in ogni pagnia del sitoweb esce questo errore DOM doesn't contain o_portal_details

andreampiovesana

LGTM - functional review ocaboat

MaurizioPellegrinet

LGTM

OpenCode · 2023-10-06T10:33:56Z

/ocabot merge nobump

OCA-git-bot · 2023-10-06T10:34:03Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-3406-by-OpenCode-bump-nobump, awaiting test results.

Signed-off-by OpenCode

OCA-git-bot · 2023-10-06T10:58:49Z

@OpenCode your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-3406-by-OpenCode-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

FIX l10n_it_website_portal_fatturapa: Cannot read property 'checked' of undefined when not in /my/home page

Otherwise, when installed directly: File "odoo/addons/base/models/ir_model.py", line 1380, in xmlid_lookup raise ValueError('External ID not found in the system: %s' % xmlid) odoo.tools.convert.ParseError: "External ID not found in the system: website.assets_frontend" while parsing None:8, near <data inherit_id="website.assets_frontend" name="Website Portal Electronic Invoice"> <xpath expr="." position="inside"> <script type="text/javascript" src="/l10n_it_website_portal_fatturapa/static/src/js/l10n_it_website_portal_fatturapa.js"/> </xpath> </data>

Currently translated at 100.0% (7 of 7 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_website_portal_fatturapa Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_website_portal_fatturapa/it/

…jected they are also obliged

SirAionTech · 2023-10-06T12:50:50Z

/ocabot merge nobump

@OpenCode puoi riprovare ora che la dipendenza è mergiata?

OpenCode · 2023-10-06T12:53:11Z

/ocabot merge nobump

OCA-git-bot · 2023-10-06T12:53:17Z

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-3406-by-OpenCode-bump-nobump, awaiting test results.

OCA-git-bot · 2023-10-06T13:16:21Z

Congratulations, your PR was merged at 7a84e65. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot added this to the 16.0 milestone Jun 26, 2023

OCA-git-bot mentioned this pull request Jun 26, 2023

Migration to version 16.0 #2967

Open

81 tasks

DinamicheAziendali mentioned this pull request Jun 29, 2023

PR aggiunte v16 DinamicheAziendali/l10n-italy#1

Open

14 tasks

Borruso force-pushed the 16.0-mig-l10n_it_website_portal_fatturapa branch 2 times, most recently from 165f95a to a09db94 Compare October 5, 2023 09:16

SirAionTech suggested changes Oct 5, 2023

View reviewed changes

Borruso force-pushed the 16.0-mig-l10n_it_website_portal_fatturapa branch from d0bfc79 to 8bbad01 Compare October 5, 2023 14:10

Borruso requested a review from SirAionTech October 5, 2023 14:10

SirAionTech reviewed Oct 5, 2023

View reviewed changes

SirAionTech suggested changes Oct 5, 2023

View reviewed changes

Borruso force-pushed the 16.0-mig-l10n_it_website_portal_fatturapa branch 2 times, most recently from 925c37e to 3d3d997 Compare October 5, 2023 16:06

andreampiovesana approved these changes Oct 5, 2023

View reviewed changes

Borruso requested a review from SirAionTech October 5, 2023 16:26

MaurizioPellegrinet approved these changes Oct 5, 2023

View reviewed changes

This comment was marked as duplicate.

Sign in to view

SirAionTech approved these changes Oct 6, 2023

View reviewed changes

OCA-git-bot added the approved label Oct 6, 2023

OCA-git-bot added the bot is merging ⏳ label Oct 6, 2023

OCA-git-bot added a commit that referenced this pull request Oct 6, 2023

Merge PR #3406 into 16.0

e18a156

Signed-off-by OpenCode

OCA-git-bot removed the bot is merging ⏳ label Oct 6, 2023

monen17 and others added 5 commits October 6, 2023 14:35

[ADD] l10n_it_website_portal_fatturapa

397efc1

porting l10n_it_website_portal_fatturapa to 12

f48419d

FIX l10n_it_website_portal_fatturapa: Cannot read property 'checked' of undefined when not in /my/home page

[IMP] l10n_it_website_portal_fatturapa: Add PA check, IPA and EORI code

87c3178

[FIX] l10n_it_website_portal_fatturapa: Fix electronic invoice label

4b48a1c

eLBati and others added 8 commits October 6, 2023 14:35

Added translation using Weblate (Italian)

f8e30d7

merge PR 1264 1717 1728 1737 1739

a6328d3

IMP l10n_it_website_portal_fatturapa: when customers set they are sub…

5997b3c

…jected they are also obliged

Reformatted after template update

4da1820

Manually fix manifest website key

e20fee1

[IMP] l10n_it_website_portal_fatturapa: pre-commit stuff

5dc8183

[MIG] l10n_it_website_portal_fatturapa: Migration to 16.0

23584ff

Borruso force-pushed the 16.0-mig-l10n_it_website_portal_fatturapa branch from 3d3d997 to 23584ff Compare October 6, 2023 12:35

OCA-git-bot added the bot is merging ⏳ label Oct 6, 2023

OCA-git-bot merged commit b5db082 into OCA:16.0 Oct 6, 2023

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Oct 6, 2023

francesco-ooops mentioned this pull request Dec 20, 2023

l10n_it_website_portal_fatturapa: implementazione gestione utente dal portale #3644

Closed

2 tasks

francesco-ooops linked an issue Dec 20, 2023 that may be closed by this pull request

l10n_it_website_portal_fatturapa: implementazione gestione utente dal portale #3644

Closed

2 tasks

	"/tree/12.0/l10n_it_website_portal_fatturapa",
	"/tree/16.0/l10n_it_website_portal_fatturapa",

Uh oh!

Conversation

Borruso commented Jun 26, 2023

Uh oh!

tafaRU commented Jun 26, 2023

Uh oh!

SirAionTech left a comment

Choose a reason for hiding this comment

Uh oh!

SirAionTech Oct 5, 2023

Choose a reason for hiding this comment

Uh oh!

Borruso Oct 5, 2023

Choose a reason for hiding this comment

Uh oh!

SirAionTech Oct 5, 2023

Choose a reason for hiding this comment

Uh oh!

SirAionTech Oct 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Borruso Oct 5, 2023

Choose a reason for hiding this comment

Uh oh!

SirAionTech Oct 5, 2023

Choose a reason for hiding this comment

Uh oh!

SirAionTech Oct 5, 2023

Choose a reason for hiding this comment

Uh oh!

Borruso Oct 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

andreampiovesana left a comment

Choose a reason for hiding this comment

Uh oh!

MaurizioPellegrinet left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as duplicate.

Uh oh!

OpenCode commented Oct 6, 2023

Uh oh!

OCA-git-bot commented Oct 6, 2023

Uh oh!

OCA-git-bot commented Oct 6, 2023

Uh oh!

SirAionTech commented Oct 6, 2023

Uh oh!

OpenCode commented Oct 6, 2023

Uh oh!

OCA-git-bot commented Oct 6, 2023

Uh oh!

OCA-git-bot commented Oct 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

SirAionTech Oct 5, 2023 •

edited

Loading

Borruso Oct 5, 2023 •

edited

Loading