16.0 mig l10n it withholding tax payment by odooNextev · Pull Request #3507 · OCA/l10n-italy

odooNextev · 2023-07-28T08:54:54Z

No description provided.

MaurizioPellegrinet

LGTM

andreampiovesana

LGTM

SirTakobi

Grazie della PR!
Potresti rimuovere i commit dei bot come descritto in https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate?

Ci sono anche due commit di migrazione e manca il commit con le modifiche di pre-commit, puoi aiutarti con https://github.com/OCA/odoo-module-migrator

odooNextev · 2023-08-04T10:09:41Z

Ma intendi rimuovere tutti quelli fatti dai bot o squashare quelli uguali in un unico come dice la guida? quindi per esempio questi: 3e7ad46 con bb89a2b

SirTakobi · 2023-08-04T10:13:28Z

Ma intendi rimuovere tutti quelli fatti dai bot o squashare quelli uguali in un unico come dice la guida? quindi per esempio questi: 3e7ad46 con bb89a2b

Va benissimo se fai come dice la guida

SirAionTech

La revisione #3507 (review) non è risolta, ad esempio c'è ancora il commit 94f98b8.

tafaRU

I commit di pre-commit e di migrazione sono da rivedere, sono mescolati.
Inoltre ci sono da schiacciare i commit amministrativi. Grazie!

tafaRU · 2023-09-08T09:36:24Z

@odooNextev i test falliscono, vedi https://github.com/OCA/l10n-italy/actions/runs/6119460806/job/16609428469?pr=3507#step:8:443

andreampiovesana · 2023-09-08T10:53:36Z

@odooNextev bisogna sistemare i dati di test x multicompany

SirAionTech

C'è ancora il commit 122790b di @oca-transbot.
Sono stati rimossi commit che non andavano rimossi:

Mancano i commit:

dcc884b (che andrebbe schiacciato perché è di un bot)
a57ebf9

andreampiovesana · 2023-09-08T12:58:17Z

@tafaRU e @SirTakobi adesso potete fare review?

SirAionTech · 2023-09-08T13:27:11Z

@tafaRU e @SirTakobi adesso potete fare review?

Se i test falliscono la PR non si può mergiare quindi è inutile fare review

andreampiovesana · 2023-09-22T08:45:26Z

come possiamo sbloccare la situazione?

[FIX] 10.0 api compat First beta Travis check Ref name [FIX] Compute WT only if the invoice has wt lines Added feature to unreconcile the wt move created by payment, and after it possible to re-reconcile

[FIX] add display_name on class withholding.tax.move withholding.tax.statement [FIX] add display_name on class withholding.tax.move withholding.tax.statement [FIX] removed select on class l10n_it_withholding_tax l10n_it_withholding_tax_payment [FIX] add README

Disabled delete from tree view of wt statements and wt moves Rates required Disabled delete from tree view of wt statements and wt moves Fix conflicts and changed code with new standards

FIX l10n_it_withholding_tax (OCA#416) Gli oggetti withholding.tax.move, withholding.tax.statement e withholding.tax.move.payment si possono eliminare dalla vista elendo dei relativi menu

check wt_moves Added rules Show payment move after generation from wt moves More check for payment unreconciliation Company readonly in payment wt Company readonly in payment wt Fix conflict with translation

* [FIX] Travis check and readonly on company_id * [FIX] Travis check and readonly on company_id

odoo/tools/translate.py", line 539, in next raise Exception("malformed file: bad line: %s" % line) Exception: malformed file: bad line: # * l10n_it_withholding_tax Restore l10n_it_withholding_tax_payment/i18n/lt.po

Currently translated at 74.5% (35 of 47 strings) Translation: l10n-italy-11.0/l10n-italy-11.0-l10n_it_withholding_tax_payment Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-11-0/l10n-italy-11-0-l10n_it_withholding_tax_payment/it/

Fix manifest ir_sequence.get() and ir_sequence.get_id() are deprecated. Please use ir_sequence.next_by_code() or ir_sequence.next_by_id(). The model wizard.wt.move.payment.create has no access rules, consider adding one. RedirectWarning method 'post()' is a deprecated alias to 'action_post()' or _post() The method '_company_default_get' on res.company is deprecated and shouldn't be used anymore ValueError: invalid literal for int() with base 10: 'wizard_wt_move_payment_create_view'

…mpany

Currently translated at 34.7% (16 of 46 strings) Translation: l10n-italy-14.0/l10n-italy-14.0-l10n_it_withholding_tax_payment Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_withholding_tax_payment/sl/

odooNextev · 2023-09-22T12:56:56Z

I test sono passati, come posso recuperare i commits che dovevano rimanere?

SirAionTech

I test sono passati, come posso recuperare i commits che dovevano rimanere?

Rifai il processo di migrazione.
Visto che siamo nel code sprint ho tempo di portarla avanti quindi la prendo in carico per correggere i punti aperti.

odooNextev mentioned this pull request Jul 28, 2023

[16.0][MIG] l10n_it_withholding_tax_payment #3459

Closed

tafaRU mentioned this pull request Jul 28, 2023

Migration to version 16.0 #2967

Open

81 tasks

MaurizioPellegrinet approved these changes Aug 3, 2023

View reviewed changes

andreampiovesana approved these changes Aug 4, 2023

View reviewed changes

OCA-git-bot added the approved label Aug 4, 2023

SirTakobi suggested changes Aug 4, 2023

View reviewed changes

OCA-git-bot removed the approved label Aug 4, 2023

odooNextev force-pushed the 16.0-mig-l10n_ita_withholding_tax_payment branch 3 times, most recently from 672851c to 251975e Compare August 4, 2023 13:44

Borruso mentioned this pull request Aug 24, 2023

PR aggiunte v16 DinamicheAziendali/l10n-italy#1

Open

14 tasks

odooNextev requested a review from SirTakobi September 7, 2023 14:10

SirAionTech suggested changes Sep 7, 2023

View reviewed changes

tafaRU requested changes Sep 7, 2023

View reviewed changes

odooNextev force-pushed the 16.0-mig-l10n_ita_withholding_tax_payment branch 3 times, most recently from 9bb1ef2 to 9fe85ea Compare September 8, 2023 08:24

odooNextev force-pushed the 16.0-mig-l10n_ita_withholding_tax_payment branch from 9fe85ea to 47211e0 Compare September 8, 2023 09:59

SirAionTech suggested changes Sep 8, 2023

View reviewed changes

odooNextev force-pushed the 16.0-mig-l10n_ita_withholding_tax_payment branch from 47211e0 to 850d221 Compare September 8, 2023 11:33

alessandrocamilli and others added 3 commits September 22, 2023 14:40

WT move and account move creation from reconcile

af67aa0

[FIX] 10.0 api compat First beta Travis check Ref name [FIX] Compute WT only if the invoice has wt lines Added feature to unreconcile the wt move created by payment, and after it possible to re-reconcile

Rates required

b4c8757

Disabled delete from tree view of wt statements and wt moves Rates required Disabled delete from tree view of wt statements and wt moves Fix conflicts and changed code with new standards

eLBati and others added 15 commits September 22, 2023 14:40

FIX l10n_it_withholding_tax metadata

59774e1

FIX l10n_it_withholding_tax (OCA#416) Gli oggetti withholding.tax.move, withholding.tax.statement e withholding.tax.move.payment si possono eliminare dalla vista elendo dei relativi menu

OCA Transbot updated translations from Transifex

666f524

Multicompany

2a9cd82

check wt_moves Added rules Show payment move after generation from wt moves More check for payment unreconciliation Company readonly in payment wt Company readonly in payment wt Fix conflict with translation

[FIX] Travis check and readonly on company_id (OCA#25)

5bf16ee

* [FIX] Travis check and readonly on company_id * [FIX] Travis check and readonly on company_id

FIX l10n_it_withholding_tax

6e89272

odoo/tools/translate.py", line 539, in next raise Exception("malformed file: bad line: %s" % line) Exception: malformed file: bad line: # * l10n_it_withholding_tax Restore l10n_it_withholding_tax_payment/i18n/lt.po

porting l10n_it_withholding_tax to v11

69dcad6

[MIG] l10n_it_withholding_tax_payment: Migration to 12.0

1a610a9

merge PR 1264 1717 1728 1737 1739

4d74fd2

[IMP] l10n_it_withholding_tax_payment: black, isort, prettier

f37fdf9

[MIG] l10n_it_withholding_tax_payment: Fix security rule for multi-co…

74d17d4

…mpany

[IMP] l10n_it_withholding_tax_payment: Readme

61e67b2

[FIX] l10n_it_withholding_tax_payment: fix test tags

e5ef40d

odooNextev force-pushed the 16.0-mig-l10n_ita_withholding_tax_payment branch from 564be34 to 0b949d7 Compare September 22, 2023 12:40

matteo.tognini added 2 commits September 25, 2023 12:15

[IMP] l10n_it_withholding_tax_payment: pre-commit stuff

c2f34b3

[MIG] l10n_it_withholding_tax_payment: Migration to 16.0

7d53ca3

odooNextev force-pushed the 16.0-mig-l10n_ita_withholding_tax_payment branch from 0b949d7 to 7d53ca3 Compare September 25, 2023 10:16

SirAionTech suggested changes Oct 5, 2023

View reviewed changes

SirAionTech mentioned this pull request Oct 5, 2023

[MIG] l10n_it_withholding_tax_payment #3637

Merged

tafaRU closed this Oct 5, 2023

Uh oh!

Conversation

odooNextev commented Jul 28, 2023

Uh oh!

MaurizioPellegrinet left a comment

Choose a reason for hiding this comment

Uh oh!

andreampiovesana left a comment

Choose a reason for hiding this comment

Uh oh!

SirTakobi left a comment

Choose a reason for hiding this comment

Uh oh!

odooNextev commented Aug 4, 2023

Uh oh!

SirTakobi commented Aug 4, 2023

Uh oh!

SirAionTech left a comment

Choose a reason for hiding this comment

Uh oh!

tafaRU left a comment

Choose a reason for hiding this comment

Uh oh!

tafaRU commented Sep 8, 2023

Uh oh!

andreampiovesana commented Sep 8, 2023

Uh oh!

SirAionTech left a comment

Choose a reason for hiding this comment

Uh oh!

andreampiovesana commented Sep 8, 2023

Uh oh!

SirAionTech commented Sep 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andreampiovesana commented Sep 22, 2023

Uh oh!

odooNextev commented Sep 22, 2023

Uh oh!

SirAionTech left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

SirAionTech commented Sep 8, 2023 •

edited

Loading