[MIG] l10n_it_vat_registries by SirAionTech · Pull Request #3564 · OCA/l10n-italy

SirAionTech · 2023-09-07T14:04:34Z

Sostituisce #3080.

tafaRU · 2023-09-07T15:12:48Z

Le review funzionali rimangono valide dalla #3080

tafaRU · 2023-09-07T15:31:42Z

/ocabot migration l10n_it_vat_registries

OCA-git-bot · 2023-09-07T15:31:50Z

The migration issue (#2967) has not been updated to reference the current pull request because a previous pull request (#3080) is not closed.
Perhaps you should check that there is no duplicate work.
CC @Borruso

tafaRU · 2023-09-07T15:33:46Z

/ocabot migration l10n_it_vat_registries

MarcoCalcagni

test funzionali OK

scigghia

LGTM

marcelofrare

LGTM

andreampiovesana · 2023-09-08T10:02:29Z

andreampiovesana · 2023-09-08T10:02:56Z

@tafaRU merge?

tafaRU · 2023-09-08T10:08:02Z

Provando a stamapare una liquidazione iva sul runboat ottengo il pdf allegato
Print Vat Period End Statement.pdf

tafaRU

#3564 (comment)

SirAionTech · 2023-09-08T10:26:10Z

#3564 (comment)

🤔 dev'essere per 4473385, quando riesco ci guardo, oppure ci può guardare @Borruso che ha fatto la modifica?

tafaRU · 2023-09-08T10:44:59Z

🤔 dev'essere per 4473385

eh sì per quello ho fatto quel test 😉

Borruso · 2023-09-08T11:05:54Z

🤔 dev'essere per 4473385

eh sì per quello ho fatto quel test 😉

per il problema della visualizzazione togli le modifiche collegate al header

Currently translated at 75.0% (45 of 60 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_vat_registries Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_vat_registries/it/

Currently translated at 95.0% (57 of 60 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_vat_registries Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_vat_registries/it/ Translated using Weblate (Italian) Currently translated at 96.7% (58 of 60 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_vat_registries Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_vat_registries/it/ Translated using Weblate (Italian) Currently translated at 96.7% (58 of 60 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_vat_registries Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_vat_registries/it/

SirAionTech · 2023-09-08T14:22:23Z

Provando a stamapare una liquidazione iva sul runboat ottengo il pdf allegato Print Vat Period End Statement.pdf

Ho provato entrambe le stampe (allegate) in runboat e mi sembrano a posto, puoi verificare?
Print Vat Period End Statement.pdf
Invoices VAT Registry.pdf

marcelofrare

LGTM le stampe dopo le modifiche di @SirAionTech
Grazie

TheMule71 · 2023-09-08T15:28:48Z

visto che acfa01c disfa molto di c12e250, io li squasherei, tanto gli autori sono già giusti, e vediamo cosa rimane

Co-authored-by: SirAionTech <simone.rubino@aion-tech.it>

SirAionTech · 2023-09-11T08:23:28Z

visto che acfa01c disfa molto di c12e250, io li squasherei, tanto gli autori sono già giusti, e vediamo cosa rimane

Ho ripulito un po' i commit, visto che ho dovuto ripartire da 0 per capire cosa stesse andando storto in account_vat_period_end_statement e l10n_it_account mi sono preso l'authorship di quel commit.
Ho anche incluso il resto delle modifiche (c'era qualcosa anche in c12e250) nel commit di migrazione quindi mi sono messo come co-autore.
@Borruso fammi sapere se per te è ok

Borruso · 2023-09-12T07:36:11Z

visto che acfa01c disfa molto di c12e250, io li squasherei, tanto gli autori sono già giusti, e vediamo cosa rimane

Ho ripulito un po' i commit, visto che ho dovuto ripartire da 0 per capire cosa stesse andando storto in account_vat_period_end_statement e l10n_it_account mi sono preso l'authorship di quel commit. Ho anche incluso il resto delle modifiche (c'era qualcosa anche in c12e250) nel commit di migrazione quindi mi sono messo come co-autore. @Borruso fammi sapere se per te è ok

per me ok

andreampiovesana · 2023-09-13T18:47:00Z

good news?

OCA-git-bot · 2023-09-14T07:16:29Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

tafaRU · 2023-09-14T07:16:44Z

/ocabot merge patch

OCA-git-bot · 2023-09-14T07:16:52Z

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-3564-by-tafaRU-bump-patch, awaiting test results.

OCA-git-bot · 2023-09-14T07:34:28Z

Congratulations, your PR was merged at 602dc87. Thanks a lot for contributing to OCA. ❤️

TheMule71 · 2024-03-11T13:52:05Z

@@ -1,5 +1,5 @@
 table {


@SirAionTech
Ciao, questo CSS interferisce con le classi standard di Odoo tipo table-bordered, che, dopo aver installato l10n_it_account perdono i bordi.

Ti ricordi il perché di questo !important e non sarebbe meglio associarlo ad una classe apposita invece "colpire" tutte le table indiscriminatamente?

👋 ricordo che avevo tolto un po' di cose da 9694c33, probabilmente questo l'ho lasciato così perché è un modo per mantenere lo stesso comportamento che c'era in 14.0.
Concordo che sarebbe meglio usare una classe apposta, anche in 14.0.

@TheMule71 c'è già una issue o puoi aprirla?

@francesco-ooops
Eh, devo costruire un es. apposta...

SirAionTech marked this pull request as ready for review September 7, 2023 14:06

SirAionTech marked this pull request as draft September 7, 2023 14:08

SirAionTech marked this pull request as ready for review September 7, 2023 14:18

SirAionTech mentioned this pull request Sep 7, 2023

[16.0][MIG] l10n_it_vat_registries #3080

Closed

michelerusti approved these changes Sep 7, 2023

View reviewed changes

OCA-git-bot added this to the 16.0 milestone Sep 7, 2023

OCA-git-bot mentioned this pull request Sep 7, 2023

Migration to version 16.0 #2967

Open

81 tasks

MarcoCalcagni approved these changes Sep 7, 2023

View reviewed changes

OCA-git-bot added the approved label Sep 7, 2023

scigghia approved these changes Sep 8, 2023

View reviewed changes

marcelofrare approved these changes Sep 8, 2023

View reviewed changes

tafaRU requested changes Sep 8, 2023

View reviewed changes

OCA-git-bot removed the approved label Sep 8, 2023

eLBati and others added 7 commits September 8, 2023 15:19

copy l10n_it_vat_registries from 10.0 branch due to conflits with git AM

bcf2d5a

porting l10n_it_vat_registries to 11.0

90db7f3

IMP l10n_it_vat_registries README (OCA#479) and tests

054344e

[MIG] l10n_it_vat_registries: Migration to 12.0

22ce04b

IMP l10n_it_vat_registries translations

e8858dd

Translated using Weblate (Italian)

b2492a7

Currently translated at 75.0% (45 of 60 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_vat_registries Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_vat_registries/it/

SirAionTech force-pushed the 16.0-mig-l10n_it_vat_registries branch from cd26d44 to acfa01c Compare September 8, 2023 14:14

SirAionTech marked this pull request as ready for review September 8, 2023 14:14

SirAionTech requested a review from tafaRU September 8, 2023 14:14

marcelofrare approved these changes Sep 8, 2023

View reviewed changes

SirAionTech marked this pull request as draft September 11, 2023 08:15

SirAionTech force-pushed the 16.0-mig-l10n_it_vat_registries branch from acfa01c to 12c917e Compare September 11, 2023 08:15

Borruso and others added 2 commits September 11, 2023 10:18

[MIG] l10n_it_vat_registries: Migration to 16.0

fbcf72a

Co-authored-by: SirAionTech <simone.rubino@aion-tech.it>

[FIX] l10n_it_account: Use report layout

a2fb57e

SirAionTech force-pushed the 16.0-mig-l10n_it_vat_registries branch from 12c917e to a2fb57e Compare September 11, 2023 08:18

SirAionTech marked this pull request as ready for review September 11, 2023 08:19

tafaRU approved these changes Sep 14, 2023

View reviewed changes

OCA-git-bot added approved ready to merge labels Sep 14, 2023

OCA-git-bot added the bot is merging ⏳ label Sep 14, 2023

OCA-git-bot merged commit f6dde34 into OCA:16.0 Sep 14, 2023

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Sep 14, 2023

Borruso mentioned this pull request Sep 14, 2023

PR aggiunte v16 DinamicheAziendali/l10n-italy#1

Open

14 tasks

francesco-ooops added the migration label Jan 10, 2024

TheMule71 reviewed Mar 11, 2024

View reviewed changes

SirAionTech mentioned this pull request Mar 13, 2024

[16.0] l10n_it_account - layout 'Boxed' loose table border left/bottom on all print #4047

Closed

Uh oh!

Conversation

SirAionTech commented Sep 7, 2023

Uh oh!

tafaRU commented Sep 7, 2023

Uh oh!

tafaRU commented Sep 7, 2023

Uh oh!

OCA-git-bot commented Sep 7, 2023

Uh oh!

tafaRU commented Sep 7, 2023

Uh oh!

MarcoCalcagni left a comment

Choose a reason for hiding this comment

Uh oh!

scigghia left a comment

Choose a reason for hiding this comment

Uh oh!

marcelofrare left a comment

Choose a reason for hiding this comment

Uh oh!

andreampiovesana commented Sep 8, 2023

Uh oh!

andreampiovesana commented Sep 8, 2023

Uh oh!

tafaRU commented Sep 8, 2023

Uh oh!

tafaRU left a comment

Choose a reason for hiding this comment

Uh oh!

SirAionTech commented Sep 8, 2023

Uh oh!

tafaRU commented Sep 8, 2023

Uh oh!

Borruso commented Sep 8, 2023

Uh oh!

SirAionTech commented Sep 8, 2023

Uh oh!

marcelofrare left a comment

Choose a reason for hiding this comment

Uh oh!

TheMule71 commented Sep 8, 2023

Uh oh!

SirAionTech commented Sep 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Borruso commented Sep 12, 2023

Uh oh!

andreampiovesana commented Sep 13, 2023

Uh oh!

OCA-git-bot commented Sep 14, 2023

Uh oh!

tafaRU commented Sep 14, 2023

Uh oh!

OCA-git-bot commented Sep 14, 2023

Uh oh!

OCA-git-bot commented Sep 14, 2023

Uh oh!

TheMule71 Mar 11, 2024

Choose a reason for hiding this comment

Uh oh!

SirAionTech Mar 11, 2024

Choose a reason for hiding this comment

Uh oh!

francesco-ooops Mar 11, 2024

Choose a reason for hiding this comment

Uh oh!

TheMule71 Mar 11, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

SirAionTech commented Sep 11, 2023 •

edited

Loading