Skip to content

[16.0][mig]l10n_it_fiscalcode_sale#3567

Merged
OCA-git-bot merged 6 commits into
OCA:16.0from
odooNextev:16-0-mig-l10n_it_fiscalcode_sale
Sep 22, 2023
Merged

[16.0][mig]l10n_it_fiscalcode_sale#3567
OCA-git-bot merged 6 commits into
OCA:16.0from
odooNextev:16-0-mig-l10n_it_fiscalcode_sale

Conversation

@odooNextev

@odooNextev odooNextev commented Sep 8, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@odooNextev odooNextev mentioned this pull request Sep 8, 2023
Closed
@tafaRU

tafaRU commented Sep 11, 2023

Copy link
Copy Markdown
Member

/ocabot migration l10n_it_fiscalcode_sale

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Sep 11, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Sep 11, 2023
Open
81 tasks
tafaRU
tafaRU requested changes Sep 11, 2023
View reviewed changes
Comment thread l10n_it_fiscalcode_sale/__manifest__.py Outdated
"auto_install": True,
"depends": [
"sale_management",
"sale",

@tafaRU tafaRU Sep 11, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Come mai questa modifica e poi perché qui e non nel commit di migrazione?

@primes2h primes2h Sep 11, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Come mai questa modifica e poi perché qui e non nel commit di migrazione?

@odooNextev
Perché questa modifica della dipendenza?
I preventivi vengono aggiunti installando sale_management, non sale.

Comment thread l10n_it_fiscalcode_sale/__manifest__.py
@odooNextev odooNextev force-pushed the 16-0-mig-l10n_it_fiscalcode_sale branch from 735b1a0 to 2225d23 Compare September 15, 2023 12:37
@odooNextev

odooNextev commented Sep 15, 2023

Copy link
Copy Markdown
Contributor Author

Dovrei aver modificato i commits distinguendo tra pre commit e migrazione

@tafaRU

tafaRU commented Sep 15, 2023

Copy link
Copy Markdown
Member

Grazie! Ultima cosa: schiacciare i commit amministrativi.

@odooNextev odooNextev force-pushed the 16-0-mig-l10n_it_fiscalcode_sale branch from 2225d23 to aeeabd2 Compare September 15, 2023 15:19
@odooNextev

odooNextev commented Sep 15, 2023

Copy link
Copy Markdown
Contributor Author

Dovrei aver fatto lo squash dei commit.

andreampiovesana
andreampiovesana approved these changes Sep 21, 2023
View reviewed changes

@andreampiovesana andreampiovesana left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot

OCA-git-bot commented Sep 21, 2023

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@tafaRU

tafaRU commented Sep 22, 2023

Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot

OCA-git-bot commented Sep 22, 2023

Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-3567-by-tafaRU-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit db57507 into OCA:16.0 Sep 22, 2023
@OCA-git-bot

OCA-git-bot commented Sep 22, 2023

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at f92f0a9. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@primes2h primes2h primes2h left review comments

@tafaRU tafaRU tafaRU approved these changes

+1 more reviewer

@andreampiovesana andreampiovesana andreampiovesana approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 migration ready to merge

Projects

None yet

Milestone

16.0

Development

Successfully merging this pull request may close these issues.

8 participants

@odooNextev @tafaRU @OCA-git-bot @primes2h @andreampiovesana @francesco-ooops @eLBati @SirTakobi
⚡