Skip to content

[MIG] l10n_it_fatturapa_import_zip#3584

Merged
OCA-git-bot merged 10 commits into
OCA:16.0from
SirAionTech:16.0-mig-l10n_it_fatturapa_import_zip
Oct 5, 2023
Merged

[MIG] l10n_it_fatturapa_import_zip#3584
OCA-git-bot merged 10 commits into
OCA:16.0from
SirAionTech:16.0-mig-l10n_it_fatturapa_import_zip

Conversation

@SirAionTech

@SirAionTech SirAionTech commented Sep 18, 2023

Copy link
Copy Markdown
Contributor

Sostituisce #3511.
Implementa #3510 per 16.0.

SirTakobi and others added 10 commits September 18, 2023 16:52
The test's user like real users is logged in only one company at a time.
That company is implicitly used in `search`es thanks to multi-company record rules.
Also allow to create withholding taxes in other tests
Do not assume there is a `/tmp` directory or that path separator is `/` so that this can also work in other FileSystems than Linux's
Override exposed methods instead of duplicating
Reuse common tests data
Sometimes the file that is being read still hasn't been written completely so it is not recognized as a zip file during parsing and raises exception "BadZipfile: File is not a zip file".
@SirAionTech SirAionTech marked this pull request as ready for review September 18, 2023 15:06
@SirAionTech

Copy link
Copy Markdown
Contributor Author

@micheledic qui ho riportato qualche fix di cui abbiamo parlato in #3511 (review), quando puoi mi dici se va bene o se trovi ancora problemi?

Non avevo visto il tuo commento sul flush ma durante le prove ho iniziato a incontrare anche io il problema e l'ho risolto in altro modo.

Comment thread l10n_it_fatturapa_import_zip/wizards/wizard_import_fatturapa.py
@tafaRU tafaRU mentioned this pull request Sep 19, 2023
76 tasks
@tafaRU

tafaRU commented Sep 19, 2023

Copy link
Copy Markdown
Member

/ocabot migration l10n_it_fatturapa_import_zip

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Sep 19, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Sep 19, 2023
81 tasks

@Borruso Borruso left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@andreampiovesana andreampiovesana left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eLBati

eLBati commented Oct 5, 2023

Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-3584-by-eLBati-bump-nobump, awaiting test results.

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 4ba3aee. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants