[14.0][IMP] assets_management multicompany by odooNextev · Pull Request #3614 · OCA/l10n-italy

odooNextev · 2023-09-28T12:51:03Z

Questa PR serve per mostrare sia in lettura che in scrittura i record relativi alle company consentite all'utente (solo quelle selezionate nel menu in alto a destra).

Sono state quindi modificate tutte le regole di accesso dei modelli dei cespiti passando da:
['|',('company_id','=',False),('company_id','child_of',[user.company_id.id])]
|
V
['|',('company_id','=',False),('company_id','in',company_ids)]

Ho aggiunto il reset dei campi legati alle aziende alla modifica del campo company_id.

Per completare ho aggiunto il seguente dominio nei campi legati alle aziende nelle viste:
domain="[('company_id', '=', company_id)]"

rif #3651

francesco-ooops · 2023-09-28T13:24:24Z

@sergiocorato al di là della forma, ti sembra un'implementazione corretta?

francesco-ooops · 2023-09-29T15:48:35Z

@sergiocorato dovremmo esserci, che ne pensi?

francesco-ooops · 2023-10-03T09:12:57Z

@matteoopenf che ne pensi?

francesco-ooops

Funzionale ok!

OCA-git-bot · 2023-10-11T09:59:50Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

odooNextev · 2023-10-13T12:30:09Z

@SirAionTech @TheMule71 @eLBati ho rivisto i commit come dicevamo stamattina

matteoopenf

review del codice ok

matteoopenf · 2023-10-13T12:42:07Z

@matteoopenf che ne pensi?

per me ok, se non c'e' altro potremmo procedere

francesco-ooops · 2023-10-17T08:40:46Z

@sergiocorato buona per te?

francesco-ooops · 2023-10-24T07:56:58Z

@sergiocorato gentile reminder :)

odooNextev · 2023-10-31T09:31:14Z

@tafaRU come faccio a far ripartire i test dopo le modifiche di pre-commit?
Ho fatto un rebase e push, ma mi dice (ovviamente) che non ci sono modifiche dal mio lato e quindi non posso far assimilare la modifica.

OpenCode · 2023-10-31T09:53:55Z

@tafaRU come faccio a far ripartire i test dopo le modifiche di pre-commit? Ho fatto un rebase e push, ma mi dice (ovviamente) che non ci sono modifiche dal mio lato e quindi non posso far assimilare la modifica.

Ho rilanciato il job

HekkiMelody · 2023-10-31T10:03:53Z

@tafaRU come faccio a far ripartire i test dopo le modifiche di pre-commit? Ho fatto un rebase e push, ma mi dice (ovviamente) che non ci sono modifiche dal mio lato e quindi non posso far assimilare la modifica.

Se ti dice che non ci sono modifiche, vuol dire che non hai fatto rebase correttamente. Altrimenti, dopo il rebase, il tuo git status dovrebbe farti vedere qualcosa tipo:

Your branch and '<remote branch name>' have diverged,
and have 34 and 1 different commits each, respectively.

Hai fatto un fetch prima?

francesco-ooops · 2024-01-26T08:56:38Z

@sergiocorato

renda-dev · 2024-01-30T16:14:01Z

+    @api.onchange("company_id")
+    def onchange_company_id(self):


nitpick:

Suggested change

@api.onchange("company_id")

def onchange_company_id(self):

@api.onchange("company_id")

def _onchange_company_id(self):

https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#L901

renda-dev · 2024-01-30T16:18:26Z

+        <record id="asset_multicompany_rule" model="ir.rule">
+            <field name="name">Asset multi company rule</field>
+            <field name="model_id" ref="model_asset_asset" />
+            <field name="global" eval="True" />
+            <field name="domain_force">
+                ['|',('company_id','=',False),('company_id','in',company_ids)]
+            </field>
+        </record>


nitpick: magari mi sbaglio, ma questo file mi risulta un tab troppo avanti

renda-dev · 2024-01-30T16:34:29Z

+                            readonly="1"
                            groups="base.group_multi_company"
-                            options="{'no_open':1, 'no_create_edit': True}"
+                            options="{'no_open':1, 'no_create': True, 'no_create_edit': True}"


question: non basta già no_create_edit a non permettere entrambi?

Oltretutto, se il campo è impostato come readonly non ci dovrebbere essere bisogno di nessuno dei due, giusto?

esatto, il readonly è stato inserito dopo e le opzioni non servono più

renda-dev · 2024-01-30T16:39:29Z

+            {"company_id": cls.company2.id}
+        )
+        # Asset categories
+        cls.asset_category_1_company1 = cls.env["asset.category"].create(


nitpick: Preferisco personalmente avere i nomi delle variabili più consistenti tra di loro, potresti mettere gli underscore anche per i numeri?

https://peps.python.org/pep-0008/#function-and-variable-names

renda-dev

Code Review, LGTM

francesco-ooops · 2024-02-06T08:01:28Z

@sergiocorato fatta ulteriore review, se gentilmente puoi verificare anche te arriviamo alla chiusura. Grazie!

HekkiMelody

Code review: ok

quibble (non-blocking): c'è parecchia duplicazione, ad esempio tutti i campi company_id sono impostati come readonly sia lato python che lato .xml. Per pulizia e chiarezza si potrebbe togliere il readonly lato .xml e lasciare quello impostato sul model.

HekkiMelody · 2024-02-13T13:53:04Z

+    @api.onchange("company_id")
+    def _onchange_company_id(self):
+        if self.company_id:
+            self.update(
+                {
+                    "type_ids": False,
+                    "journal_id": False,
+                    "asset_account_id": False,
+                    "fund_account_id": False,
+                    "depreciation_account_id": False,
+                    "gain_account_id": False,
+                    "loss_account_id": False,
+                    "tag_ids": False,
+                }
+            )


question (non-blocking): non mi è chiaro quando questa onchange si attivi, visto che company_id è readonly

sono stati fatti molti cambiamenti da quando è stata creata questa PR e probabilmente serviva all'inizio, poi è stato messo readonly nel modello ed ora è inutile 👍

francesco-ooops · 2024-02-13T15:04:24Z

@stenext si son rotti i test

odooNextev · 2024-02-13T15:40:36Z

@stenext si son rotti i test

ora c'è qualcosa con l10n_it_bill_of_entry

HekkiMelody · 2024-02-20T10:05:19Z

                                    name="company_id"
                                    options="{'no_open':1, 'no_create_edit': True}"
-                                    invisible="1"
                                    readonly="1"


Qui, a differenza di tutti gli altri, è stato lasciato il readonly e tolto l'invisible, è voluto?

Probabilmente era per testarlo perchè lasciandolo invisible non avrei avuto la prova immediata.
Per le move lines sono tutti campi visibili, ma readonly, per me è uguale seguire questa linea anche per l'azienda o lasciarlo invisibile, ditemi voi cosa è meglio.

L'avevo evidenziato perché era l'unica modifica diversa dalle altre https://github.com/OCA/l10n-italy/compare/78caca0394e0c74f4a86946d032019fd106da10f..e9d0a5e216d9ff7015543fe9561e9b2b61f3753d

alla fine mi sono reso conto che sia currency_id che company_id sono già in sola lettura da modello perciò l'ho tolto da XML ed ho lasciato invisible
cosa ne pensi?

Mi sembra ok!

HekkiMelody · 2024-02-20T10:06:34Z

A parte, quella piccola cosa, LGTM.

HekkiMelody

Code review

francesco-ooops · 2024-02-23T08:37:06Z

@OCA/local-italy-maintainers buongiorno, abbiamo 5 approvazioni, si può mergiare?

eLBati · 2024-02-23T08:56:04Z

https://discord.com/channels/753902328494424064/753902328494424070/1210507781422190602

eLBati · 2024-02-23T08:57:51Z

/ocabot merge minor

OCA-git-bot · 2024-02-23T08:58:01Z

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-3614-by-eLBati-bump-minor, awaiting test results.

OCA-git-bot · 2024-02-23T09:12:13Z

Congratulations, your PR was merged at 2129e67. Thanks a lot for contributing to OCA. ❤️

GSLabIt reviewed Sep 28, 2023

View reviewed changes

Comment thread assets_management/views/asset_category.xml Outdated

Comment thread assets_management/views/asset_depreciation_line.xml Outdated

Comment thread assets_management/views/asset.xml

odooNextev force-pushed the 14.0-imp-assets_management-multicompany branch from 708de86 to 0412e30 Compare September 28, 2023 15:59

odooNextev force-pushed the 14.0-imp-assets_management-multicompany branch from 9b40439 to 59c7113 Compare October 2, 2023 06:59

odooNextev requested a review from GSLabIt October 2, 2023 07:14

GSLabIt approved these changes Oct 3, 2023

View reviewed changes

odooNextev mentioned this pull request Oct 6, 2023

[assets_management] creazione e configurazione cespiti con utente multicompany #3651

Open

3 tasks

francesco-ooops approved these changes Oct 11, 2023

View reviewed changes

OCA-git-bot added approved ready to merge labels Oct 11, 2023

odooNextev force-pushed the 14.0-imp-assets_management-multicompany branch 2 times, most recently from 388e036 to 9f6036f Compare October 13, 2023 12:27

matteoopenf approved these changes Oct 13, 2023

View reviewed changes

sergiocorato requested changes Oct 24, 2023

View reviewed changes

Comment thread assets_management/tests/test_assets_common.py Outdated

Comment thread assets_management/models/asset_category.py Outdated

OCA-git-bot removed approved ready to merge labels Oct 24, 2023

odooNextev force-pushed the 14.0-imp-assets_management-multicompany branch from 9f6036f to a3b158c Compare October 27, 2023 12:33

odooNextev requested a review from sergiocorato October 27, 2023 12:34

renda-dev suggested changes Jan 30, 2024

View reviewed changes

stenext force-pushed the 14.0-imp-assets_management-multicompany branch from 34b8341 to 78caca0 Compare February 1, 2024 09:32

odooNextev requested a review from renda-dev February 1, 2024 10:02

renda-dev approved these changes Feb 2, 2024

View reviewed changes

francesco-ooops requested a review from SirAionTech February 2, 2024 09:03

HekkiMelody approved these changes Feb 13, 2024

View reviewed changes

stenext force-pushed the 14.0-imp-assets_management-multicompany branch from 78caca0 to e9d0a5e Compare February 13, 2024 14:53

stenext force-pushed the 14.0-imp-assets_management-multicompany branch from e9d0a5e to 5ad335f Compare February 13, 2024 15:13

stenext force-pushed the 14.0-imp-assets_management-multicompany branch 2 times, most recently from c205415 to ac4c41a Compare February 15, 2024 10:51

HekkiMelody reviewed Feb 20, 2024

View reviewed changes

HekkiMelody approved these changes Feb 20, 2024

View reviewed changes

[IMP] assets_management: avoid multicompany issues on records creation

73721ae

stenext force-pushed the 14.0-imp-assets_management-multicompany branch from ac4c41a to 73721ae Compare February 20, 2024 14:52

OCA-git-bot added the bot is merging ⏳ label Feb 23, 2024

OCA-git-bot merged commit 329796d into OCA:14.0 Feb 23, 2024

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Feb 23, 2024

francesco-ooops mentioned this pull request Feb 23, 2024

[MIG] assets_management -> l10n_it_asset_management: Migration to 16.0 #3776

Merged

renda-dev mentioned this pull request Mar 13, 2024

[14.0] [FIX] assets_management: missing rule migration script #4046

Merged

Uh oh!

Conversation

odooNextev commented Sep 28, 2023 • edited by eLBati Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

francesco-ooops commented Sep 28, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

francesco-ooops commented Sep 29, 2023

Uh oh!

francesco-ooops commented Oct 3, 2023

Uh oh!

francesco-ooops left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Oct 11, 2023

Uh oh!

odooNextev commented Oct 13, 2023

Uh oh!

matteoopenf left a comment

Choose a reason for hiding this comment

Uh oh!

matteoopenf commented Oct 13, 2023

Uh oh!

francesco-ooops commented Oct 17, 2023

Uh oh!

francesco-ooops commented Oct 24, 2023

Uh oh!

Uh oh!

Uh oh!

odooNextev commented Oct 31, 2023

Uh oh!

OpenCode commented Oct 31, 2023

Uh oh!

HekkiMelody commented Oct 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

francesco-ooops commented Jan 26, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

renda-dev left a comment

Choose a reason for hiding this comment

Uh oh!

francesco-ooops commented Feb 6, 2024

Uh oh!

HekkiMelody left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

francesco-ooops commented Feb 13, 2024

Uh oh!

odooNextev commented Feb 13, 2024

Uh oh!

HekkiMelody Feb 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

odooNextev Feb 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HekkiMelody Feb 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

odooNextev commented Sep 28, 2023 •

edited by eLBati

Loading

HekkiMelody commented Oct 31, 2023 •

edited

Loading

HekkiMelody Feb 20, 2024 •

edited

Loading

odooNextev Feb 20, 2024 •

edited

Loading

HekkiMelody Feb 20, 2024 •

edited

Loading