Skip to content

[16.0][MIG] l10n_it_delivery_note_batch#3636

Merged
OCA-git-bot merged 6 commits into
OCA:16.0from
OpenCode:16.0-mig-l10n_it_delivery_note_batch
Oct 5, 2023
Merged

[16.0][MIG] l10n_it_delivery_note_batch#3636
OCA-git-bot merged 6 commits into
OCA:16.0from
OpenCode:16.0-mig-l10n_it_delivery_note_batch

Conversation

@OpenCode

@OpenCode OpenCode commented Oct 5, 2023

Copy link
Copy Markdown
Contributor

Sostituisce #3032

@OpenCode OpenCode mentioned this pull request Oct 5, 2023
Closed
@OpenCode OpenCode force-pushed the 16.0-mig-l10n_it_delivery_note_batch branch from ae3cb6f to 3310eb1 Compare October 5, 2023 09:53
TonyMasciI
TonyMasciI suggested changes Oct 5, 2023
View reviewed changes

@TonyMasciI TonyMasciI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ripulire la storia dei commit:

https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate

@OpenCode OpenCode force-pushed the 16.0-mig-l10n_it_delivery_note_batch branch from 3310eb1 to 658ced2 Compare October 5, 2023 10:49
andreampiovesana
andreampiovesana approved these changes Oct 5, 2023
View reviewed changes

@andreampiovesana andreampiovesana left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - test funzionale

@OpenCode OpenCode force-pushed the 16.0-mig-l10n_it_delivery_note_batch branch from 658ced2 to a1b89c1 Compare October 5, 2023 11:02
@OpenCode OpenCode force-pushed the 16.0-mig-l10n_it_delivery_note_batch branch from a1b89c1 to 53e2473 Compare October 5, 2023 11:05
@OpenCode

OpenCode commented Oct 5, 2023

Copy link
Copy Markdown
Contributor Author

@tafaRU Sull'altra PR ti eri preso l'onore di squashare i commit. Qui ho fatto io. Vuoi dare un'occhiata?

MaurizioPellegrinet
MaurizioPellegrinet approved these changes Oct 5, 2023
View reviewed changes

@MaurizioPellegrinet MaurizioPellegrinet left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Borruso Borruso mentioned this pull request Oct 5, 2023
Closed
2 tasks
@OCA-git-bot

OCA-git-bot commented Oct 5, 2023

Copy link
Copy Markdown
Contributor

Sorry @andreampiovesana you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

Borruso
Borruso suggested changes Oct 5, 2023
View reviewed changes
Comment thread l10n_it_delivery_note_batch/models/stock_picking_batch.py Outdated
@OpenCode OpenCode force-pushed the 16.0-mig-l10n_it_delivery_note_batch branch from 53e2473 to 92b04e1 Compare October 5, 2023 14:33
Borruso
Borruso approved these changes Oct 5, 2023
View reviewed changes

@Borruso Borruso left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreampiovesana

andreampiovesana commented Oct 5, 2023

Copy link
Copy Markdown
Contributor

merge?

@OpenCode

OpenCode commented Oct 5, 2023

Copy link
Copy Markdown
Contributor Author

/ocabot merge nobumps

@OCA-git-bot

OCA-git-bot commented Oct 5, 2023

Copy link
Copy Markdown
Contributor

Hi @OpenCode. Your command failed:

Invalid options for command merge: nobumps.

Ocabot commands

  • ocabot merge major|minor|patch|nobump
  • ocabot rebase
  • ocabot migration {MODULE_NAME}

More information

@OpenCode

OpenCode commented Oct 5, 2023

Copy link
Copy Markdown
Contributor Author

/ocabot merge nobump

@OCA-git-bot

OCA-git-bot commented Oct 5, 2023

Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-3636-by-OpenCode-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 5, 2023
@OCA-git-bot
Merge PR #3636 into 16.0
7321850 
Signed-off-by OpenCode
@OCA-git-bot

OCA-git-bot commented Oct 5, 2023

Copy link
Copy Markdown
Contributor

It looks like something changed on 16.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 16.0-ocabot-merge-pr-3636-by-OpenCode-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 5, 2023
@OCA-git-bot
Merge PR #3636 into 16.0
80f34c1 
Signed-off-by OpenCode
@tafaRU

tafaRU commented Oct 5, 2023

Copy link
Copy Markdown
Member

/ocabot migration l10n_it_delivery_note_batch

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Oct 5, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 5, 2023
Open
81 tasks
@OCA-git-bot

OCA-git-bot commented Oct 5, 2023

Copy link
Copy Markdown
Contributor

It looks like something changed on 16.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 16.0-ocabot-merge-pr-3636-by-OpenCode-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 977d4c6 into OCA:16.0 Oct 5, 2023
@OCA-git-bot

OCA-git-bot commented Oct 5, 2023

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at bc9855b. Thanks a lot for contributing to OCA. ❤️

@OpenCode OpenCode deleted the 16.0-mig-l10n_it_delivery_note_batch branch October 5, 2023 17:19
@francesco-ooops francesco-ooops linked an issue Dec 20, 2023 that may be closed by this pull request
Filtraggio picking e pulsate Crea DdT in modulo l10n_it_delivery_note_batch #3639
Closed
2 tasks
@francesco-ooops francesco-ooops removed a link to an issue Jan 10, 2024
Filtraggio picking e pulsate Crea DdT in modulo l10n_it_delivery_note_batch #3639
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers

@andreampiovesana andreampiovesana andreampiovesana approved these changes

@TonyMasciI TonyMasciI TonyMasciI approved these changes

@Borruso Borruso Borruso approved these changes

@MaurizioPellegrinet MaurizioPellegrinet MaurizioPellegrinet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

16.0 approved merged 🎉 migration

Projects

None yet

Milestone

16.0

Development

Successfully merging this pull request may close these issues.

9 participants

@OpenCode @OCA-git-bot @andreampiovesana @tafaRU @TonyMasciI @Borruso @MaurizioPellegrinet @fredzamoabg @mymage
⚡