Skip to content

[16.0] [MIG] currency_rate_update_boi#3643

Merged
OCA-git-bot merged 9 commits into
OCA:16.0from
Borruso:16.0-mig-currency_rate_update_boi
Dec 20, 2023
Merged

[16.0] [MIG] currency_rate_update_boi#3643
OCA-git-bot merged 9 commits into
OCA:16.0from
Borruso:16.0-mig-currency_rate_update_boi

Conversation

@Borruso

@Borruso Borruso commented Oct 5, 2023

Copy link
Copy Markdown
Contributor

Migration currency_rate_update_boi 14.0 to 16.0

--
Confermo di aver firmato il CLA https://odoo-community.org/page/cla e di aver letto le linee guida su https://odoo-community.org/page/contributing

@Borruso Borruso force-pushed the 16.0-mig-currency_rate_update_boi branch from 69e2716 to ca1f3d7 Compare October 5, 2023 15:33
@Borruso Borruso mentioned this pull request Oct 5, 2023
Open
81 tasks
@tafaRU

tafaRU commented Oct 5, 2023

Copy link
Copy Markdown
Member

/ocabot migration currency_rate_update_boi

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Oct 5, 2023
@Borruso Borruso force-pushed the 16.0-mig-currency_rate_update_boi branch 2 times, most recently from 995b4f5 to 66e61ec Compare October 5, 2023 15:45
SirAionTech
SirAionTech approved these changes Oct 5, 2023
View reviewed changes

@SirAionTech SirAionTech left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie della PR!
Ho fatto revisione della storia dei commit, del codice e l'ho provato in locale: per me è ok.

La copertura dei test è un po' bassa ma non lo vedo come bloccante per il merge.

eLBati and others added 8 commits October 6, 2023 10:34
@eLBati @Borruso
ADD currency_rate_update_boi - Currency Rate Update: Bank of Italy
9910de2
@sergiocorato @Borruso
Added translation using Weblate (Italian)
c21789d
@sergiocorato @Borruso
Translated using Weblate (Italian)
0b727e4 
Currently translated at 100.0% (4 of 4 strings)

Translation: l10n-italy-12.0/l10n-italy-12.0-currency_rate_update_boi
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-currency_rate_update_boi/it/
@SirTakobi @Borruso
currency_rate_update_boi: Add missing key in manifest
df82bb6 
Pre-commit error is:
Error: website key not found in manifest in currency_rate_update_boi.
@SirTakobi @Borruso
Manually fix manifest website key
89ad227
@robyf70 @Borruso
[14.0][MIG] currency_rate_update_boi: Migration to 14.0
c6d8d14
@mymage @Borruso
Translated using Weblate (Italian)
a297984 
Currently translated at 100.0% (6 of 6 strings)

Translation: l10n-italy-14.0/l10n-italy-14.0-currency_rate_update_boi
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-currency_rate_update_boi/it/
@Borruso
[IMP] currency_rate_update_boi: pre-commit stuff
4a9ebb1
@Borruso Borruso force-pushed the 16.0-mig-currency_rate_update_boi branch from 66e61ec to 3198c24 Compare October 6, 2023 08:34
qs2-Leo
qs2-Leo approved these changes Oct 6, 2023
View reviewed changes

@qs2-Leo qs2-Leo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review OK!

@tafaRU

tafaRU commented Oct 9, 2023

Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot

OCA-git-bot commented Oct 9, 2023

Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-3643-by-tafaRU-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 9, 2023
@OCA-git-bot
Merge PR #3643 into 16.0
3391c6c 
Signed-off-by tafaRU
@OCA-git-bot

OCA-git-bot commented Oct 9, 2023

Copy link
Copy Markdown
Contributor

@tafaRU your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-3643-by-tafaRU-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@tafaRU

tafaRU commented Oct 9, 2023

Copy link
Copy Markdown
Member

@Borruso puoi verificare gli errori sollevati in https://github.com/OCA/l10n-italy/actions/runs/6453424689/job/17516975924?

@OCA-git-bot

OCA-git-bot commented Oct 10, 2023

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@andreampiovesana

andreampiovesana commented Oct 11, 2023

Copy link
Copy Markdown
Contributor

news?

@Borruso Borruso force-pushed the 16.0-mig-currency_rate_update_boi branch from 3198c24 to 0e07872 Compare October 13, 2023 08:55
@Borruso

Borruso commented Oct 13, 2023

Copy link
Copy Markdown
Contributor Author

@Borruso puoi verificare gli errori sollevati in https://github.com/OCA/l10n-italy/actions/runs/6453424689/job/17516975924?

fatto, la chiamata a BOI nel weekend non restituisce dati creata funzione nei per verificare se data è sabato o domenica.

@Borruso Borruso requested a review from tafaRU October 13, 2023 08:57
@SirAionTech

SirAionTech commented Dec 7, 2023

Copy link
Copy Markdown
Contributor

@Borruso puoi verificare gli errori sollevati in https://github.com/OCA/l10n-italy/actions/runs/6453424689/job/17516975924?

fatto, la chiamata a BOI nel weekend non restituisce dati creata funzione nei per verificare se data è sabato o domenica.

@tafaRU potresti riprovare il merge?
Da quanto scrive @Borruso gli errori della prima prova #3643 (comment) dovrebbero essere risolti

@francesco-ooops

francesco-ooops commented Dec 19, 2023

Copy link
Copy Markdown
Contributor

@tafaRU riproviamo il merge?

@tafaRU

tafaRU commented Dec 20, 2023

Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot

OCA-git-bot commented Dec 20, 2023

Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-3643-by-tafaRU-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 5cc1bae into OCA:16.0 Dec 20, 2023
@OCA-git-bot

OCA-git-bot commented Dec 20, 2023

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 0450551. Thanks a lot for contributing to OCA. ❤️

@SirAionTech SirAionTech mentioned this pull request Dec 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tafaRU tafaRU Awaiting requested review from tafaRU

3 more reviewers

@OpenCode OpenCode OpenCode approved these changes

@qs2-Leo qs2-Leo qs2-Leo approved these changes

@SirAionTech SirAionTech SirAionTech approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

16.0 approved merged 🎉 migration needs functional review ready to merge

Projects

None yet

Milestone

16.0

Development

Successfully merging this pull request may close these issues.
⚡