[14.0][FIX]assets_management: properly open wizard#4345
Merged
Conversation
francesco-ooops
added
14.0
missing issue
2 tasks
2 tasks
francesco-ooops
removed
the
missing issue
GSLabIt
approved these changes
Aug 30, 2024
Contributor
|
@SirAionTech che ne pensi? |
SirAionTech
suggested changes
Aug 30, 2024
SirAionTech
left a comment
SirAionTech
left a comment
Contributor
There was a problem hiding this comment.
Grazie della PR!
Revisione del codice, per me è ok.
È possibile aggiungere un test? Così si evitano regressioni.
PicchiSeba
force-pushed
the
14.0-fix-asset-wiz-access-error
branch
from
0baf75b to
1828745
Compare
Contributor
Author
|
@SirAionTech Ho aggiunto il test richiesto |
PicchiSeba
force-pushed
the
14.0-fix-asset-wiz-access-error
branch
from
1828745 to
859e978
Compare
SirAionTech
suggested changes
Sep 2, 2024
PicchiSeba
changed the title
PicchiSeba
force-pushed
the
14.0-fix-asset-wiz-access-error
branch
from
859e978 to
d0861e5
Compare
Contributor
Author
|
@SirAionTech , aggiunta la parte mancante del test |
Contributor
|
@SirAionTech mi dai l'ok per il merge? :) |
SirAionTech
suggested changes
Sep 10, 2024
SirAionTech
reviewed
Sep 10, 2024
PicchiSeba
force-pushed
the
14.0-fix-asset-wiz-access-error
branch
from
d0861e5 to
5f8d66e
Compare
PicchiSeba
force-pushed
the
14.0-fix-asset-wiz-access-error
branch
from
5f8d66e to
95acfa7
Compare
Contributor
Author
|
@SirAionTech dovremmo esserci |
SirAionTech
approved these changes
Sep 10, 2024
SirAionTech
left a comment
SirAionTech
left a comment
Contributor
There was a problem hiding this comment.
Grazie
/ocabot merge patch
Contributor
|
What a great day to merge this nice PR. Let's do it! |
Contributor
|
Congratulations, your PR was merged at d1bb00f. Thanks a lot for contributing to OCA. ❤️ |
35 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR, the action is properly fetched, solving access errors for non-admin users