Skip to content

[16.0][FIX] l10n_it_central_journal_reportlab: escape Paragraph content#4400

Merged
OCA-git-bot merged 1 commit into
OCA:16.0from
TheMule71:16.0-fix-reportlab-escape
Oct 18, 2024
Merged

[16.0][FIX] l10n_it_central_journal_reportlab: escape Paragraph content#4400
OCA-git-bot merged 1 commit into
OCA:16.0from
TheMule71:16.0-fix-reportlab-escape

Conversation

@TheMule71

@TheMule71 TheMule71 commented Oct 11, 2024

Copy link
Copy Markdown
Contributor

Paragraph() prende un simil-HTML, un markup con varie direttive tipo <para> ecc.

passandogli dei dati, meglio fare l'escape di tutto.

Fixes: #4396
Fixes: #4153

@OCA-git-bot

OCA-git-bot commented Oct 11, 2024

Copy link
Copy Markdown
Contributor

Hi @Borruso, @MarcoCalcagni,
some modules you are maintaining are being modified, check this out!

@TheMule71 TheMule71 force-pushed the 16.0-fix-reportlab-escape branch from 8fcf223 to b4a5f1f Compare October 11, 2024 08:21
This was referenced Oct 11, 2024
Closed
Closed
Closed
@francesco-ooops

francesco-ooops commented Oct 11, 2024

Copy link
Copy Markdown
Contributor

@TheMule71 la #4153 risulta già fixata per la 16, non è così?

@TheMule71

TheMule71 commented Oct 11, 2024

Copy link
Copy Markdown
Contributor Author

@TheMule71 la #4153 risulta già fixata per la 16, non è così?

Si ma era estremamente parziale, solo per un campo e solo per i caratteri '<' e '>'.

Il problema si ripropone potenzialmente su altri campi e per altri caratteri (per es. prob interpreta & e &) ecc.

La mia fix dovrebbe essere generica, usa una libreria XML per fare l'escape delle direttive, e la applico su tutti i valori che sono potenzialmente dinamici (non prefissati nei sorgenti).

@francesco-ooops francesco-ooops mentioned this pull request Oct 11, 2024
Closed
2 tasks
Borruso
Borruso approved these changes Oct 18, 2024
View reviewed changes

@Borruso Borruso left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@MarcoCalcagni puoi mergiare

@MarcoCalcagni

MarcoCalcagni commented Oct 18, 2024

Copy link
Copy Markdown

/ocabot merge patch

@OCA-git-bot

OCA-git-bot commented Oct 18, 2024

Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-4400-by-MarcoCalcagni-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d47afea into OCA:16.0 Oct 18, 2024
@OCA-git-bot

OCA-git-bot commented Oct 18, 2024

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 11b63c5. Thanks a lot for contributing to OCA. ❤️

@TheMule71 TheMule71 mentioned this pull request Jan 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Borruso Borruso Borruso approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

merged 🎉

Projects

None yet

Milestone

No milestone

5 participants

@TheMule71 @OCA-git-bot @francesco-ooops @MarcoCalcagni @Borruso
⚡