[MIG] l10n_it_account_stamp: Migrazione a 18.0 by SirAionTech · Pull Request #4402 · OCA/l10n-italy

SirAionTech · 2024-10-11T13:54:18Z

Sostituisce #4373.

SirAionTech · 2024-10-11T14:06:10Z

/ocabot migration l10n_it_account_stamp

MaurizioPellegrinet

Test funzionale: OK

[FIX] clean [FIX] clean [FIX] pep8 [IMP] use tax obj instead of tax code [FIX] icon path [FIX] get product with lang context [FIX] translation [FIX] product name [FIX] compute after unlink of invoice line

…nal items

…OCA#818) This is needed as stamp line should be under VAT exemption

Currently translated at 100.0% (29 of 29 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_account_stamp Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_account_stamp/it/

[FIX] extra blank line [FIX] typos in source strings [IMP] readme, adapt to v.12.0 and add italian section [IMP] __manifest__.py, set ITA name and summary

Currently translated at 100.0% (29 of 29 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_account_stamp Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_account_stamp/it/

[FIX] 2 euro image file [IMP] image on invoice to display stamp application and revert checkbox to previous position [FIX] show button in draft edit mode only

Currently translated at 100.0% (30 of 30 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_account_stamp Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_account_stamp/it/

Test case: - Create a product setting VAT "fuori campo" (price 1) - Configure "Tax Stamp 2 euro" product to apply to "fuori campo" - Create an invoice, add a line selecting the previously created product and setting unit price = 100 tax_stamp field stays false

This reverts commit 112146d.

If stamp line can be added (invoice in draft): show button to add stamp line. If stamp line can't be added (invoice not in draft): show message explaining why it can't be added. If stamp line has already been added: show message saying it has already been added (useful if invoice has many lines). Button and messages update live while updating the invoice. Better messages to user for charging stamp to customer Co-authored-by: Simone Rubino <simone.rubino@aion-tech.it>

Currently translated at 100.0% (35 of 35 strings) Translation: l10n-italy-16.0/l10n-italy-16.0-l10n_it_account_stamp Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-16-0/l10n-italy-16-0-l10n_it_account_stamp/it/

primes2h

Per me è ok.

Manca solo un revisione degli script di migrazione, non posso autorevisionarmeli. 😉

OCA-git-bot · 2024-10-24T15:00:01Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Align with Odoo standard terminology Co-authored-by: Sergio Zanchetta <primes2h@gmail.com>

SirAionTech

Per me è ok.

Manca solo un revisione degli script di migrazione, non posso autorevisionarmeli. 😉

Li ho guardati e secondo me vanno bene ma non posso autoapprovarmi la PR; ci accorgeremo di cosa abbiamo sbagliato quando si potranno usare.

Ho fatto le modifiche che avevamo detto in #4402 (comment), se vuoi darci un occhio così poi mergiamo 🚀

MarcoCalcagni

Ok funzionale

primes2h · 2024-12-15T19:28:06Z

Per me è ok.
Manca solo un revisione degli script di migrazione, non posso autorevisionarmeli. 😉

Li ho guardati e secondo me vanno bene ma non posso autoapprovarmi la PR; ci accorgeremo di cosa abbiamo sbagliato quando si potranno usare.

Ho fatto le modifiche che avevamo detto in #4402 (comment), se vuoi darci un occhio così poi mergiamo 🚀

Perfetto, grazie!

primes2h

LGTM

primes2h · 2024-12-15T19:29:00Z

/ocabot merge nobump

OCA-git-bot · 2024-12-15T19:29:07Z

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-4402-by-primes2h-bump-nobump, awaiting test results.

OCA-git-bot · 2024-12-15T19:33:32Z

Congratulations, your PR was merged at ed47cc3. Thanks a lot for contributing to OCA. ❤️

odooNextev · 2025-03-18T15:35:31Z

Non bisognerebbe nascondere il campo l10n_it_stamp_duty di l10n_it_edi dalla vista per evitare confusione all'utente?
Anche perchè se un utente imposta il campo ed aggiunge il prodotto bollo nelle righe quale dei 2 importi viene inserito nel XML?

SirAionTech marked this pull request as ready for review October 11, 2024 13:56

OCA-git-bot added this to the 18.0 milestone Oct 11, 2024

OCA-git-bot mentioned this pull request Oct 11, 2024

Migration to version 18.0 #4392

Open

46 tasks

MaurizioPellegrinet approved these changes Oct 17, 2024

View reviewed changes

francesco-ooops added 18.0 migration labels Oct 18, 2024

sergiocorato and others added 23 commits October 18, 2024 12:58

[8.0] add account stamp management

c066529

[FIX] clean [FIX] clean [FIX] pep8 [IMP] use tax obj instead of tax code [FIX] icon path [FIX] get product with lang context [FIX] translation [FIX] product name [FIX] compute after unlink of invoice line

porting l10n_it_account_stamp to 10

c826c2c

REF l10n_it_account_stamp with invoice bool, add line button and jour…

8284d70

…nal items

porting l10n_it_account_stamp and l10n_it_fatturapa_out_stamp to 12

5c7a7ab

[FIX] add default product stamp in company (OCA#799)

f5a0b70

[FIX] use stamp in invoicing environment (OCA#801)

238008f

FIX l10n_it_account_stamp: recompute taxes when adding stamp to lines (…

af1a501

…OCA#818) This is needed as stamp line should be under VAT exemption

Translated using Weblate (Italian)

da9fad5

Currently translated at 100.0% (29 of 29 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_account_stamp Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_account_stamp/it/

[FIX] move stamp checkbox to avoid misleading

729a9a6

[FIX] extra blank line [FIX] typos in source strings [IMP] readme, adapt to v.12.0 and add italian section [IMP] __manifest__.py, set ITA name and summary

Translated using Weblate (Italian)

3619ed3

Currently translated at 100.0% (29 of 29 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_account_stamp Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_account_stamp/it/

Translated using Weblate (Italian)

3d8f6af

Currently translated at 100.0% (29 of 29 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_account_stamp Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_account_stamp/it/

[IMP] l10n_account_stamp add manual mode

2fd59ca

[FIX] 2 euro image file [IMP] image on invoice to display stamp application and revert checkbox to previous position [FIX] show button in draft edit mode only

[FIX] decree month in source string

321bf90

Translated using Weblate (Italian)

2f76207

Currently translated at 100.0% (30 of 30 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_account_stamp Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_account_stamp/it/

Translated using Weblate (Italian)

4da328c

Currently translated at 100.0% (30 of 30 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_account_stamp Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_account_stamp/it/

Translated using Weblate (Italian)

317ed73

Currently translated at 100.0% (30 of 30 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_account_stamp Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_account_stamp/it/

merge PR 1264 1717 1728 1737 1739

9a13b4c

[FIX] show stamp duty parameters in manual mode

1598071

FIX l10n_it_account_stamp when auto_compute_stamp is False

5ee105b

Revert "[FIX] show stamp duty parameters in manual mode"

c2cf7aa

This reverts commit 112146d.

[IMP] l10n_it_account_stamp: black, isort, prettier

1ff4a9d

[MIG] l10n_it_account_stamp: Migration to 14.0

6fa3260

SirAionTech and others added 3 commits October 18, 2024 12:58

[REF] l10n_it_account_stamp: Reformatted after template update

d1389bd

Translated using Weblate (Italian)

2515728

Currently translated at 100.0% (35 of 35 strings) Translation: l10n-italy-16.0/l10n-italy-16.0-l10n_it_account_stamp Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-16-0/l10n-italy-16-0-l10n_it_account_stamp/it/

SirAionTech force-pushed the 18.0-mig-l10n_it_account_stamp branch from 6340163 to dff90a8 Compare October 18, 2024 11:01

primes2h requested changes Oct 24, 2024

View reviewed changes

Comment thread l10n_it_account_stamp/migrations/18.0.1.0.0/pre-migrate.py Outdated

SirAionTech force-pushed the 18.0-mig-l10n_it_account_stamp branch from dff90a8 to a6d100f Compare October 24, 2024 14:40

SirAionTech requested a review from primes2h October 24, 2024 14:41

primes2h approved these changes Oct 24, 2024

View reviewed changes

OCA-git-bot added approved ready to merge labels Oct 24, 2024

SirAionTech marked this pull request as draft October 24, 2024 15:19

This comment was marked as resolved.

Sign in to view

[MIG] l10n_it_account_stamp: Migration to 18.0

4bd4fc5

Align with Odoo standard terminology Co-authored-by: Sergio Zanchetta <primes2h@gmail.com>

SirAionTech force-pushed the 18.0-mig-l10n_it_account_stamp branch from a6d100f to 4bd4fc5 Compare October 30, 2024 16:52

SirAionTech marked this pull request as ready for review October 30, 2024 16:56

SirAionTech commented Oct 30, 2024

View reviewed changes

SirAionTech requested a review from primes2h October 30, 2024 17:00

MarcoCalcagni approved these changes Dec 13, 2024

View reviewed changes

primes2h approved these changes Dec 15, 2024

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Dec 15, 2024

OCA-git-bot merged commit e2c3b5f into OCA:18.0 Dec 15, 2024

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Dec 15, 2024

odooNextev mentioned this pull request Mar 18, 2025

[RFC] Imposta di bollo in odoo/odoo #3941

Closed

Uh oh!

Conversation

SirAionTech commented Oct 11, 2024

Uh oh!

SirAionTech commented Oct 11, 2024

Uh oh!

MaurizioPellegrinet left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

primes2h left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Oct 24, 2024

Uh oh!

This comment was marked as resolved.

SirAionTech left a comment

Choose a reason for hiding this comment

Uh oh!

MarcoCalcagni left a comment

Choose a reason for hiding this comment

Uh oh!

primes2h commented Dec 15, 2024

Uh oh!

primes2h left a comment

Choose a reason for hiding this comment

Uh oh!

primes2h commented Dec 15, 2024

Uh oh!

OCA-git-bot commented Dec 15, 2024

Uh oh!

OCA-git-bot commented Dec 15, 2024

Uh oh!

odooNextev commented Mar 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

16 participants