[16.0][MIG]l10n_it_riba_sale_commission: migration to v16 by matteotognini · Pull Request #4403 · OCA/l10n-italy

matteotognini · 2024-10-14T10:05:17Z

No description provided.

SirAionTech · 2024-10-14T10:37:38Z

/ocabot migration l10n_it_riba_sale_commission

SirAionTech

Grazie della PR!
Ho verificato che migrando da 14.0 con OpenUpgrade i dati vengono preservati.

Ho notato che alcuni commit di 14.0 mancano, tipo ead038a, potresti includerli? Se possibile andrebbero messi nel punto giusto della storia, quindi prima dei commit di migrazione

Puoi schiacciare i commit dei bot come indicato in https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate?

SirAionTech · 2024-11-15T09:51:00Z

@odooNextev, @aleuffre, @renda-dev, @PicchiSeba visto che mantenete il modulo in 14.0, potete guardare se va bene questa migrazione? Credo abbiate anche potere di merge con ocabot

SirAionTech · 2024-12-05T15:07:52Z

+    "application": False,
+    "installable": True,
+    "depends": [
+        "sale_commission",


Questa dipendenza è stata splittata in 15.0 (vedi OCA/commission#387) in diversi moduli, ora dovrebbe essere sufficiente account_commission.

Grazie, ero partito da un branch non aggiornato e quindi non ero correttamente allineato alle ultime modifiche. Il modulo dipende da OCA/commission#561 che al momento è in attesa di reviews. Nei prossimi giorni provo a verificare quanto rimane da correggere su questa pr.

SirAionTech · 2024-12-05T16:04:17Z

@@ -0,0 +1 @@
+odoo16-addon-commission@git+https://github.com/OCA/commission/pull/561/head#subdirectory=setup/commission


I test non si stanno eseguendo per questo errore

fatal: repository 'OCA/commission#561' not found

(da https://github.com/OCA/l10n-italy/actions/runs/12182965960/job/33983246738?pr=4403#step:4:192)

probabile che sia perché questo è da correggere:

Suggested change

odoo16-addon-commission@git+https://github.com/OCA/commission/pull/561/head#subdirectory=setup/commission

odoo-addon-commission @ git+https://github.com/OCA/commission.git@refs/pull/561/head#subdirectory=setup/commission

(vedi https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference(s)-to-another-pull-request(s))

Qualche test fallirà comunque per #4461, ma almeno il resto dei test verranno eseguiti.

SirAionTech · 2024-12-09T13:20:32Z

/ocabot rebase

OCA-git-bot · 2024-12-09T13:20:44Z

Congratulations, PR rebased to 16.0.

labour-angus

Ok funzionale

MaurizioPellegrinet

Test funzionale: OK

SirAionTech · 2024-12-19T13:40:47Z

+            ]
+            if dates:
+                return date_payment_to < max(dates)
+        return super()._skip_future_payments(date_payment_to)


Non trovo questo metodo in super, puoi controllare?
Ho fatto qualche ricerca ed era stato introdotto in 14.0 da OCA/commission#441 ma in 16.0 non lo vedo, e non vedo nemmeno delle PR per portare OCA/commission#441 in 16.0.

Grazie della review, si, effettivamente il metodo non è presente nella 16. Mi consigli di proporre una pr per portare la pr in account_commission oppure rimuovo il metodo?
@francesco-ooops cosa ne pensi?

Grazie della review, si, effettivamente il metodo non è presente nella 16. Mi consigli di proporre una pr per portare la pr in account_commission oppure rimuovo il metodo?

Da quello che sto capendo di questi moduli questo override è un punto cardine del funzionamento di questo modulo, e se non esiste in super probabilmente vuole anche dire che non viene chiamato quando dovrebbe: secondo me sarebbe da portare OCA/commission#441 a 16.0.

Mi stupisce anche un po' che i test passino senza che questo metodo sia in super, quindi magari mi sto perdendo qualche pezzo.

Ho proposto questa pr: OCA/commission#588

Marianna-Marasco · 2025-03-27T08:46:14Z

Ciao, si può testare questa PR?

francesco-ooops · 2025-03-27T10:27:16Z

@Marianna-Marasco la versione che abbiamo utilizzato in v14 ha dei grossi problemi i cui fix speriamo di riportare in OCA al più presto, comunque ti lancio un rebase se vuoi testare

francesco-ooops · 2025-03-27T10:27:52Z

/ocabot rebase

Currently translated at 100.0% (8 of 8 strings) Translation: l10n-italy-14.0/l10n-italy-14.0-l10n_it_riba_sale_commission Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_riba_sale_commission/it/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: l10n-italy-14.0/l10n-italy-14.0-l10n_it_riba_sale_commission Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_riba_sale_commission/

Currently translated at 100.0% (9 of 9 strings) Translation: l10n-italy-14.0/l10n-italy-14.0-l10n_it_riba_sale_commission Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_riba_sale_commission/it/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: l10n-italy-14.0/l10n-italy-14.0-l10n_it_riba_sale_commission Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_riba_sale_commission/

Currently translated at 100.0% (9 of 9 strings) Translation: l10n-italy-14.0/l10n-italy-14.0-l10n_it_riba_sale_commission Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_riba_sale_commission/it/

…n the documentation

OCA-git-bot · 2025-03-27T10:28:08Z

Congratulations, PR rebased to 16.0.

github-actions · 2025-07-27T12:45:37Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

OCA-git-bot added this to the 16.0 milestone Oct 14, 2024

OCA-git-bot mentioned this pull request Oct 14, 2024

Migration to version 16.0 #2967

Open

81 tasks

francesco-ooops added 16.0 migration labels Oct 18, 2024

SirAionTech suggested changes Nov 15, 2024

View reviewed changes

SirAionTech reviewed Dec 5, 2024

View reviewed changes

matteotognini force-pushed the 16.0-mig-l10n_it_riba_sale_commission branch from c5faa0f to 75f7b12 Compare December 5, 2024 15:33

SirAionTech reviewed Dec 5, 2024

View reviewed changes

OCA-git-bot force-pushed the 16.0-mig-l10n_it_riba_sale_commission branch from 083a7f0 to 7949bbe Compare December 9, 2024 13:20

SirAionTech mentioned this pull request Dec 9, 2024

[IMP] Regolare commissioni per fatture pagate con RiBa alla scadenza della RiBa #4495

Closed

1 task

francesco-ooops mentioned this pull request Dec 9, 2024

Regolare commissioni per fatture pagate con RiBa alla scadenza della RiBa #4494

Closed

2 tasks

labour-angus approved these changes Dec 9, 2024

View reviewed changes

MaurizioPellegrinet approved these changes Dec 9, 2024

View reviewed changes

SirAionTech reviewed Dec 19, 2024

View reviewed changes

odooNextev and others added 9 commits March 27, 2025 10:28

[14.0][ADD] l10n_it_riba_sale_commission

dd40adb

[UPD] Update l10n_it_riba_sale_commission.pot

b1e052f

[UPD] README.rst

0a7585b

Translated using Weblate (Italian)

4ee9fde

Currently translated at 100.0% (8 of 8 strings) Translation: l10n-italy-14.0/l10n-italy-14.0-l10n_it_riba_sale_commission Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_riba_sale_commission/it/

Translated using Weblate (Italian)

0622a59

Currently translated at 100.0% (8 of 8 strings) Translation: l10n-italy-14.0/l10n-italy-14.0-l10n_it_riba_sale_commission Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_riba_sale_commission/it/

[UPD] README.rst

82133d1

[IMP]l10n_it_riba_sale_commission: use payment date

0539774

[UPD] Update l10n_it_riba_sale_commission.pot

9fd596d

[BOT] post-merge updates

885f6ba

weblate and others added 15 commits March 27, 2025 10:28

Translated using Weblate (Italian)

1ea41f7

Currently translated at 100.0% (9 of 9 strings) Translation: l10n-italy-14.0/l10n-italy-14.0-l10n_it_riba_sale_commission Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_riba_sale_commission/it/

Translated using Weblate (Italian)

ed46c89

Currently translated at 100.0% (9 of 9 strings) Translation: l10n-italy-14.0/l10n-italy-14.0-l10n_it_riba_sale_commission Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_riba_sale_commission/it/

[IMP]l10n_it_riba_sale_commission:partial commission settlement

5738414

[BOT] post-merge updates

f673f5c

[IMP] l10n_it_riba_sale_commission: use wizard's payment date

b33f78a

[IMP] l10n_it_riba_sale_commission: add maintainers

cfdc55a

[UPD] Update l10n_it_riba_sale_commission.pot

4616f32

[BOT] post-merge updates

e1c8d0f

Translated using Weblate (Italian)

2676e8e

Currently translated at 100.0% (9 of 9 strings) Translation: l10n-italy-14.0/l10n-italy-14.0-l10n_it_riba_sale_commission Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_riba_sale_commission/it/

[IMP]l10n_it_riba_sale_commission: cherry pick

9b2d7c1

[MIG]l10n_it_riba_sale_commission: migrazion to v16

083e5d9

[IMP]l10n_it_riba_sale_commission:fix tests

507d84d

[IMP]l10n_it_riba_sale_commission:fix test-requirements as provided i…

1afb88a

…n the documentation

OCA-git-bot force-pushed the 16.0-mig-l10n_it_riba_sale_commission branch from 7949bbe to 1afb88a Compare March 27, 2025 10:28

github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 27, 2025

github-actions Bot closed this Aug 31, 2025

		@@ -0,0 +1 @@
		odoo16-addon-commission@git+https://github.com/OCA/commission/pull/561/head#subdirectory=setup/commission

	odoo16-addon-commission@git+https://github.com/OCA/commission/pull/561/head#subdirectory=setup/commission
	odoo-addon-commission @ git+https://github.com/OCA/commission.git@refs/pull/561/head#subdirectory=setup/commission

Uh oh!

Conversation

matteotognini commented Oct 14, 2024

Uh oh!

SirAionTech commented Oct 14, 2024

Uh oh!

SirAionTech left a comment

Choose a reason for hiding this comment

Uh oh!

SirAionTech commented Nov 15, 2024

Uh oh!

SirAionTech Dec 5, 2024

Choose a reason for hiding this comment

Uh oh!

matteotognini Dec 5, 2024

Choose a reason for hiding this comment

Uh oh!

SirAionTech Dec 5, 2024

Choose a reason for hiding this comment

Uh oh!

SirAionTech commented Dec 9, 2024

Uh oh!

OCA-git-bot commented Dec 9, 2024

Uh oh!

labour-angus left a comment

Choose a reason for hiding this comment

Uh oh!

MaurizioPellegrinet left a comment

Choose a reason for hiding this comment

Uh oh!

SirAionTech Dec 19, 2024

Choose a reason for hiding this comment

Uh oh!

matteotognini Dec 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SirAionTech Dec 19, 2024

Choose a reason for hiding this comment

Uh oh!

matteotognini Dec 20, 2024

Choose a reason for hiding this comment

Uh oh!

Marianna-Marasco commented Mar 27, 2025

Uh oh!

francesco-ooops commented Mar 27, 2025

Uh oh!

francesco-ooops commented Mar 27, 2025

Uh oh!

OCA-git-bot commented Mar 27, 2025

Uh oh!

github-actions Bot commented Jul 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

matteotognini Dec 19, 2024 •

edited

Loading