Skip to content

[FIX] l10n_it_withholding_tax, l10n_it_financial_statements_report: fix for payment_reference cannot be located in parent view, fix for KeyError 'grouped_key'#4486

Merged
OCA-git-bot merged 2 commits into
OCA:16.0from
stesi:16.0_fix_payment_reference_view
Dec 6, 2024
Merged

Conversation

@micheledic

@micheledic micheledic commented Dec 6, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fix per
Element '<xpath expr="//group/group/field[@name='payment_reference']">' cannot be located in parent view
e
fix for KeyError 'grouped_key'

presente su tutte le ultime PR e si presenta se si installa account_payment_order prima di l10n_it_withholding_tax

Fixes #4487
Fixes #4461

@micheledic

micheledic commented Dec 6, 2024

Copy link
Copy Markdown
Contributor Author

sono in loop questa PR e #4485 .
Per andare in ok la 4485 ho bisogno di questa e per far andare in OK questa ho bisogno dell'altra

@SirAionTech

SirAionTech commented Dec 6, 2024

Copy link
Copy Markdown
Contributor

sono in loop questa PR e #4485 . Per andare in ok la 4485 ho bisogno di questa e per far andare in OK questa ho bisogno dell'altra

Puoi mettere entrambi i commit nella stessa PR e chiudere l'altra.

@micheledic micheledic changed the title [FIX] l10n_it_withholding_tax: fix for payment_reference cannot be located in parent view [FIX] l10n_it_withholding_tax, l10n_it_financial_statements_report: fix for payment_reference cannot be located in parent view, fix for KeyError 'grouped_key' Dec 6, 2024
@micheledic

micheledic commented Dec 6, 2024

Copy link
Copy Markdown
Contributor Author

sono in loop questa PR e #4485 . Per andare in ok la 4485 ho bisogno di questa e per far andare in OK questa ho bisogno dell'altra

Puoi mettere entrambi i commit nella stessa PR e chiudere l'altra.

fatto!

eLBati
eLBati approved these changes Dec 6, 2024
View reviewed changes

@eLBati eLBati left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Grazie

This was referenced Dec 6, 2024
Closed
Closed
Closed
primes2h
primes2h approved these changes Dec 6, 2024
View reviewed changes

@primes2h primes2h left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie!

@primes2h

primes2h commented Dec 6, 2024

Copy link
Copy Markdown
Contributor

/ocabot merge patch

@OCA-git-bot

OCA-git-bot commented Dec 6, 2024

Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-4486-by-primes2h-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit e0314e9 into OCA:16.0 Dec 6, 2024
@OCA-git-bot

OCA-git-bot commented Dec 6, 2024

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at e095f39. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@primes2h primes2h primes2h approved these changes

@eLBati eLBati eLBati approved these changes

Assignees

No one assigned

Labels

approved merged 🎉

Projects

None yet

Milestone

No milestone

5 participants

@micheledic @SirAionTech @primes2h @OCA-git-bot @eLBati
⚡