Skip to content

[18.0][MIG] l10n_it_intrastat#4718

Merged
OCA-git-bot merged 83 commits into
OCA:18.0from
tafaRU:18.0-mig-l10n_it_intrastat
Jul 21, 2025
Merged

[18.0][MIG] l10n_it_intrastat#4718
OCA-git-bot merged 83 commits into
OCA:18.0from
tafaRU:18.0-mig-l10n_it_intrastat

Conversation

@tafaRU

@tafaRU tafaRU commented Apr 11, 2025

Copy link
Copy Markdown
Member

No description provided.

Lara Baggio and others added 30 commits April 11, 2025 15:10
Currently translated at 0.4% (42 of 10990 strings)

Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_intrastat
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_intrastat/it/
Currently translated at 14.5% (1595 of 10982 strings)

Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_intrastat
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_intrastat/it/
Currently translated at 14.5% (1595 of 10982 strings)

Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_intrastat
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_intrastat/it/
Investigating an issue reported by Sergio Zanchetta.
Currently translated at 14.5% (1593 of 10990 strings)

Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_intrastat
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_intrastat/it/
Currently translated at 14.6% (1601 of 10988 strings)

Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_intrastat
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_intrastat/it/
Currently translated at 0.5% (56 of 10988 strings)

Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_intrastat
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_intrastat/es/
…n't adapt type 'account.intrastat.transaction.nature' + test
Pre-commit issues:
l10n_it_intrastat/models/account.py:304:5: C901 'AccountInvoice.compute_intrastat_lines' is too complex (17)
l10n_it_intrastat/models/account.py:540: [C8108(method-compute), AccountInvoiceIntrastat] Name of compute method should start with "_compute_"
l10n_it_intrastat/models/account.py:170:96: B950 line too long (95 > 80 characters)
l10n_it_intrastat/models/account.py:176:100: B950 line too long (99 > 80 characters)
l10n_it_intrastat/models/account.py:189:92: B950 line too long (91 > 80 characters)
l10n_it_intrastat/models/account.py:303:43: E741 ambiguous variable name 'l'
l10n_it_intrastat/models/account.py:373:21: B007 Loop control variable 'key' not used within the loop body. If this is intended, start the name with an underscore.
l10n_it_intrastat/models/account.py:380:25: B007 Loop control variable 'key' not used within the loop body. If this is intended, start the name with an underscore.
l10n_it_intrastat/models/account.py:397:17: B007 Loop control variable 'key' not used within the loop body. If this is intended, start the name with an underscore.
l10n_it_intrastat/models/account.py:409:13: E741 ambiguous variable name 'l'
l10n_it_intrastat/tests/test_intrastat.py:74:35: E741 ambiguous variable name 'l'

Migrate old invoice fields and fix tests
- views do no more inherit from anything, otherwise following error might occur:
  Element '<tree string="Codes">' cannot be located in parent view

  View name: views.tree.report.intrastat.code
  Error context:
   view: ir.ui.view(2275,)
   xmlid: view_tree_report_intrastat_code
   view.model: report.intrastat.code
   view.parent: ir.ui.view(2269,)
   file: /path/to/odoo/addons/l10n_it_intrastat/views/intrastat.xml

- intrastat codes might have been moved by enterprise module account_intrastat
Otherwise the following warning is raised:
unknown parameter 'size', if this is an actual parameter you may want to override the method _valid_field_parameter on the relevant model in order to allow it
Currently translated at 14.5% (1601 of 10988 strings)

Translation: l10n-italy-14.0/l10n-italy-14.0-l10n_it_intrastat
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_intrastat/it/
Currently translated at 14.5% (1603 of 10988 strings)

Translation: l10n-italy-14.0/l10n-italy-14.0-l10n_it_intrastat
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_intrastat/it/
@OCA-git-bot OCA-git-bot mentioned this pull request Apr 11, 2025
46 tasks
@tafaRU tafaRU force-pushed the 18.0-mig-l10n_it_intrastat branch from 955b720 to 4d7dffb Compare April 11, 2025 13:23
Borruso added a commit to DinamicheAziendali/l10n-italy that referenced this pull request Apr 18, 2025
@tafaRU

tafaRU commented May 30, 2025

Copy link
Copy Markdown
Member Author

/ocabot rebase

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, PR rebased to 18.0.

@OCA-git-bot OCA-git-bot force-pushed the 18.0-mig-l10n_it_intrastat branch from 4d7dffb to 2c0c7da Compare May 30, 2025 08:01

@MaurizioPellegrinet MaurizioPellegrinet left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manca sul prodotto il codice "nomenclatura combinata", non è visibile.
Sembra che la chiave (era good è diventata goods?) sia cambiata
image

@tafaRU tafaRU force-pushed the 18.0-mig-l10n_it_intrastat branch from 2c0c7da to 21c28e7 Compare June 17, 2025 10:13
@tafaRU

tafaRU commented Jun 17, 2025

Copy link
Copy Markdown
Member Author

@MaurizioPellegrinet puoi riprovare grazie.

@MaurizioPellegrinet MaurizioPellegrinet left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test funzionale: OK

Comment thread l10n_it_intrastat/models/account.py Outdated
class AccountFiscalPosition(models.Model):
_inherit = "account.fiscal.position"

intrastat = fields.Boolean(string="Subject to Intrastat")

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eLBati

anche eventualmente altri

potresti essere più preciso? :)

@tafaRU tafaRU Jul 18, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fatto in 3b2444f

Borruso added a commit to DinamicheAziendali/l10n-italy that referenced this pull request Jul 14, 2025
@tafaRU tafaRU force-pushed the 18.0-mig-l10n_it_intrastat branch from f148374 to 3b2444f Compare July 17, 2025 14:25
@eLBati

eLBati commented Jul 18, 2025

Copy link
Copy Markdown
Member

Abbiamo deciso di modificare solo i nomi dei campi che sappiamo avere problemi. Gli altri ce li possiamo tenere come sono.

Ovviamente per i nuovi moduli useremo il prefisso l10n_it_oca

@eLBati eLBati left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eLBati

eLBati commented Jul 21, 2025

Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot

Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-4718-by-eLBati-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8d412ac into OCA:18.0 Jul 21, 2025
5 of 7 checks passed
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 29e2316. Thanks a lot for contributing to OCA. ❤️

@tafaRU tafaRU deleted the 18.0-mig-l10n_it_intrastat branch July 21, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.