[FIX] l10n_it_fatturapa_out: fix for uom with more than 10 characters(for example the Units uom in German)#4780
[FIX] l10n_it_fatturapa_out: fix for uom with more than 10 characters(for example the Units uom in German)#4780micheledic wants to merge 1 commit into
Conversation
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
Bot
added
the
stale
micheledic
force-pushed
the
16.0_fix_uom_length
branch
from
3d65516 to
5ba5b0f
Compare
|
@OCA/local-italy-maintainers ping |
francesco-ooops
added
no stale
|
@OCA/local-italy-maintainers ping |
monen17
left a comment
monen17
left a comment
There was a problem hiding this comment.
Grazie della PR!
Puoi aggiungere un test? Dalle linee guida https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#6tests:
As a general rule, a bug fix should come with a unittest which would fail without the fix itself. This is to assure that regression will not happen in the future. It also is a good way to show that the fix works in all cases.
… (for example the Units uom in German)
micheledic
force-pushed
the
16.0_fix_uom_length
branch
from
5ba5b0f to
b57af1c
Compare
fatto |
monen17
left a comment
monen17
left a comment
There was a problem hiding this comment.
Grazie della PR! Puoi aggiungere un test? Dalle linee guida https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#6tests:
As a general rule, a bug fix should come with a unittest which would fail without the fix itself. This is to assure that regression will not happen in the future. It also is a good way to show that the fix works in all cases.
fatto
Ottimo grazie 🎉
Potresti mica anche accorciare il titolo del commit b57af1c? Ora è
e come vedi viene tagliato.
Il titolo dovrebbe essere abbastanza breve da essere tutto visibile, nella descrizione invece ti puoi sbizzarrire!
È uno dei punti indicati nelle linee guida sulla struttura del commit sono in https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#71commit-message:
please check if the commit message is cut with ellipsis.
| # "account_id": self.a_recv.id, | ||
| "invoice_payment_term_id": self.account_payment_term.id, | ||
| # "user_id": self.user_demo.id, |
There was a problem hiding this comment.
Questi commenti non servono a chiarire il comportamento del codice, si possono rimuovere?
|
@francesco-ooops dici che possiamo chiudere o almeno togliere |
francesco-ooops
removed
the
no stale
|
@monen17 certo, anzi per me i no stale dalle PR puoi levarli, tanto anche da chiuse restano linkate nelle issues e se qualcuno vuole riprenderle in mano si riaprono tranquillamente |
4 participants
Fixes #4781