[18.0][MIG] l10n_it_financial_statements_report: Migration to 18.0 by micheledic · Pull Request #4789 · OCA/l10n-italy

micheledic · 2025-06-03T06:48:15Z

No description provided.

micheledic · 2025-06-03T08:48:32Z

Ho introdotto con questa PR anche un metodo per il campo account_ids che sulla 18.0 restituisce "cannot be searchable" Issue OCA/account-financial-reporting#1306
Lo stesso l'ho proposto sul modulo originario, quindi nel caso venisse approvato tolgo e ripunto ad account_ids
OCA/account-financial-reporting#1327

eLBati

Grazie!

micheledic · 2025-06-05T08:44:50Z

/ocabot migration

OCA-git-bot · 2025-06-05T08:44:53Z

Hi @micheledic. Your command failed:

Invalid options for command migration: .

Ocabot commands

ocabot merge major|minor|patch|nobump
ocabot rebase
ocabot migration {MODULE_NAME}

More information

ocabot documentation
OCA guidelines, specially the "Version Numbers" section.

micheledic · 2025-06-05T08:45:22Z

/ocabot migration l10n_it_financial_statements_report

OCA-git-bot · 2025-06-05T08:45:35Z

Sorry @micheledic you are not allowed to mark the addon to be migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

micheledic · 2025-06-05T08:46:16Z

@eLBati puoi tu ?

francesco-ooops · 2025-06-05T08:46:21Z

/ocabot migration l10n_it_financial_statements_report

monen17

Grazie della PR!
Ci sono diverse cose che non mi tornano sul segno dei gruppi di conti ma sono uguali a com'è in 16.0 quindi non è questo il momento di cambiarle, anche se qui il codice viene proprio aggiunto e non migrato perché è stato rimosso da df6d0e5.

Puoi schiacciare i commit come descritto in https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate? Al momento diversi commit portati sono dei bot:

Potresti anche togliere [18.0] dal commit di migrazione? Al momento è

Ma i commit dovrebbero seguire https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#71commit-message, quindi iniziare con un tag che in questo caso è [MIG].
Occhio anche al typo nel nome del modulo 😉
Ti consiglio di usare https://github.com/OCA/odoo-module-migrator che automatizza la creazione del commit e diversi passaggi per la migrazione.

micheledic · 2025-07-07T10:34:38Z

@monen17 ho squashato i commit del bot, fixato nome commit e alcuni attributi, aggiunto anche test-requirementst.txt per far dipendere dalla PR fix di account_financial_report (è corretto fare così giusto?
Per il css avevo già provato a usare
<t t-call="account_financial_report.html_container">

ma non viene proprio stampato il bundle asset backend.
Ho verificato proprio l'html generato che viene poi passato a wkhtml e c'è solo report asset bundle

Report XLSX: the syntax "if isinstance(value, int | float)" can be used on Python 3.10 and above versions. 16.0 code should be compatible with Python>=3.7 tho.

Currently translated at 100.0% (70 of 70 strings) Translation: l10n-italy-16.0/l10n-italy-16.0-l10n_it_financial_statements_report Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-16-0/l10n-italy-16-0-l10n_it_financial_statements_report/it/

…key'

Currently translated at 100.0% (71 of 71 strings) Translation: l10n-italy-16.0/l10n-italy-16.0-l10n_it_financial_statements_report Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-16-0/l10n-italy-16-0-l10n_it_financial_statements_report/it/

micheledic · 2025-10-03T14:56:12Z

fatto rebase, penso non manchi nulla per il merge
riuscite a rifare review e successivamente il merge? @eLBati @mrcast @andreampiovesana

andreampiovesana

LGTM

eLBati · 2025-10-07T13:43:22Z

@monen17 i tuoi punti sono OK?

VBNext

Funzionale OK

micheledic · 2025-10-08T09:44:38Z

Funziona, segnalo solo che non è presente nel menu la voce "gruppo di conto"

Come indicato anche nel task https://www.odoo-italia.org/web?debug=assets#id=899&cids=1&menu_id=206&action=328&active_id=18&model=project.task&view_type=form è normale... c'è un modulo a parte OCA che mostra la voce menù se non si utilizza l'enterprise

micheledic · 2025-10-14T10:17:10Z

@OCA/local-italy-developers @monen17 ping

eLBati · 2025-10-15T08:57:06Z

@monen17 i tuoi punti sono OK?

Mi sembra di sì. Procedo

/ocabot merge nobump

Grazie a tutti

OCA-git-bot · 2025-10-15T08:57:13Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-4789-by-eLBati-bump-nobump, awaiting test results.

OCA-git-bot · 2025-10-15T09:12:25Z

Congratulations, your PR was merged at ccfd3db. Thanks a lot for contributing to OCA. ❤️

micheledic force-pushed the 18.0_mig_l10n_it_financial_statements_report branch 2 times, most recently from e1793e5 to 04d7fb0 Compare June 3, 2025 06:52

micheledic marked this pull request as draft June 3, 2025 07:10

micheledic force-pushed the 18.0_mig_l10n_it_financial_statements_report branch from 04d7fb0 to 78694fe Compare June 3, 2025 08:35

micheledic marked this pull request as ready for review June 3, 2025 08:47

micheledic force-pushed the 18.0_mig_l10n_it_financial_statements_report branch 3 times, most recently from addc917 to 2555cb4 Compare June 3, 2025 09:15

francesco-ooops added 18.0 migration labels Jun 4, 2025

eLBati reviewed Jun 4, 2025

View reviewed changes

micheledic force-pushed the 18.0_mig_l10n_it_financial_statements_report branch from 2555cb4 to b33173d Compare June 4, 2025 10:30

micheledic requested review from eLBati and francesco-ooops June 4, 2025 13:07

odooNextev mentioned this pull request Jun 4, 2025

Migration to version 18.0 #4392

Open

46 tasks

OCA-git-bot added this to the 18.0 milestone Jun 5, 2025

Borruso mentioned this pull request Jun 13, 2025

PR aggiunte v18 DinamicheAziendali/l10n-italy#2

Open

10 tasks

Borruso added a commit to DinamicheAziendali/l10n-italy that referenced this pull request Jun 13, 2025

[ADD] l10n_it_financial_statements_report: aggiunta PR OCA#4789

27e39b6

monen17 requested changes Jul 4, 2025

View reviewed changes

micheledic force-pushed the 18.0_mig_l10n_it_financial_statements_report branch 2 times, most recently from 1bdeda0 to 39c908e Compare July 7, 2025 10:31

micheledic force-pushed the 18.0_mig_l10n_it_financial_statements_report branch from 39c908e to 81ff7a5 Compare July 7, 2025 10:53

SirAionTech and others added 12 commits October 3, 2025 12:55

Updated from template

bb27a82

[FIX] l10n_it_financial_statements_report: Prepayments are assets

255616a

[FIX]l10n_it_financial_statements_report: Syntax compatibility

bf102d2

Report XLSX: the syntax "if isinstance(value, int | float)" can be used on Python 3.10 and above versions. 16.0 code should be compatible with Python>=3.7 tho.

FIX l10n_it_financial_statements_report: use landscape format for PDF

d3d4b26

[FIX] l10n_it_financial_statements_report: fix for KeyError 'grouped_…

60e80ea

…key'

[IMP] l10n_it_financial_statements_report: add company header

3a8eb1f

[IMP] l10n_it_financial_statements_report: pre-commit stuff

6ecf593

[MIG] l10n_it_financial_statements_report: Migration to 18.0

7c0ecca

micheledic force-pushed the 18.0_mig_l10n_it_financial_statements_report branch from 75a46cc to 7c0ecca Compare October 3, 2025 10:55

micheledic requested review from andreampiovesana and mrcast October 3, 2025 14:55

andreampiovesana approved these changes Oct 7, 2025

View reviewed changes

VBNext approved these changes Oct 8, 2025

View reviewed changes

francesco-ooops removed request for francesco-ooops and mrcast October 14, 2025 10:23

OCA-git-bot added the bot is merging ⏳ label Oct 15, 2025

OCA-git-bot merged commit eded601 into OCA:18.0 Oct 15, 2025
5 of 7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Oct 15, 2025

Uh oh!

Conversation

micheledic commented Jun 3, 2025

Uh oh!

micheledic commented Jun 3, 2025

Uh oh!

eLBati left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

micheledic commented Jun 5, 2025

Uh oh!

OCA-git-bot commented Jun 5, 2025

Uh oh!

micheledic commented Jun 5, 2025

Uh oh!

OCA-git-bot commented Jun 5, 2025

Uh oh!

micheledic commented Jun 5, 2025

Uh oh!

francesco-ooops commented Jun 5, 2025

Uh oh!

monen17 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

micheledic commented Jul 7, 2025

Uh oh!

micheledic commented Oct 3, 2025

Uh oh!

andreampiovesana left a comment

Choose a reason for hiding this comment

Uh oh!

eLBati commented Oct 7, 2025

Uh oh!

VBNext left a comment

Choose a reason for hiding this comment

Uh oh!

micheledic commented Oct 8, 2025

Uh oh!

micheledic commented Oct 14, 2025

Uh oh!

eLBati commented Oct 15, 2025

Uh oh!

OCA-git-bot commented Oct 15, 2025

Uh oh!

Uh oh!

OCA-git-bot commented Oct 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants