Skip to content

[18.0][IMP] l10n_it_accompanying_invoice: handler for adding transport data in XML#4985

Open
Borruso wants to merge 1 commit into
OCA:18.0from
Borruso:18.0-imp-l10n_it_accompanying_invoice-dati_trasporto
Open

[18.0][IMP] l10n_it_accompanying_invoice: handler for adding transport data in XML#4985
Borruso wants to merge 1 commit into
OCA:18.0from
Borruso:18.0-imp-l10n_it_accompanying_invoice-dati_trasporto

Conversation

@Borruso

@Borruso Borruso commented Nov 6, 2025

Copy link
Copy Markdown
Contributor

@eLBati

eLBati commented Nov 6, 2025

Copy link
Copy Markdown
Member

Grazie.
Un testino? 🙏

@Borruso Borruso force-pushed the 18.0-imp-l10n_it_accompanying_invoice-dati_trasporto branch 2 times, most recently from 75c6c29 to d63cdd9 Compare November 7, 2025 08:32

@eLBati eLBati left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Abbiamo detto che , per i campi non obbligatori, bisogna controllare che siano valorizzati

@Borruso Borruso force-pushed the 18.0-imp-l10n_it_accompanying_invoice-dati_trasporto branch from d63cdd9 to 63a370b Compare November 7, 2025 11:35
@francesco-ooops

Copy link
Copy Markdown
Contributor

@Borruso @eLBati questa non serve per 16/14 giusto?

@eLBati

eLBati commented Nov 18, 2025

Copy link
Copy Markdown
Member

@francesco-ooops giusto

@monen17

monen17 commented Feb 13, 2026

Copy link
Copy Markdown
Contributor

/ocabot rebase

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, PR rebased to 18.0.

@OCA-git-bot OCA-git-bot force-pushed the 18.0-imp-l10n_it_accompanying_invoice-dati_trasporto branch from 63a370b to c648697 Compare February 13, 2026 11:38

@monen17 monen17 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie della PR!
In buona parte va bene, non mi torna molto però che i nuovi nodi non vengano valorizzati nel XML dei test, puoi verificare?

Puoi anche aggiornare la documentazione?

</t>
</Anagrafica>
</DatiAnagraficiVettore>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perché non c'è anche MezzoTrasporto? Penso sia il campo delivery_transport_method_id

t-out="record.delivery_packages"
/>

<Descrizione

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Qui manca

Suggested change
<Descrizione
<!-- 2.1.9.5 -->
<Descrizione

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oltra ai nodi che ho segnalato, mancano anche:

  • DataOraRitiro
  • DataOraConsegna

Non so però se abbiamo il dato da poterci mettere o se lo vogliamo mettere in generale, mi rimetto al parere dei funzionali 🙏

<Comune>Napoli</Comune>
<Nazione>IT</Nazione>
</IndirizzoResa>
</DatiTrasporto>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La maggior parte dei nuovi nodi aggiunti non vengono inseriti nel XML anche se nel test vengono assegnati:

        italian_partner.default_transport_condition_id = self.env.ref(
            "l10n_it_delivery_note.transport_condition_PF"
        )
        italian_partner.default_goods_appearance_id = self.env.ref(
            "l10n_it_delivery_note.goods_appearance_CAR"
        )
        italian_partner.default_transport_reason_id = self.env.ref(
            "l10n_it_delivery_note.transport_reason_VEN"
        )
        italian_partner.default_transport_method_id = self.env.ref(
            "l10n_it_delivery_note.transport_method_MIT"
        )

Manca anche tutto DatiAnagraficiVettore, li puoi aggiungere?

Comment on lines +1 to +2
# Copyright 2023 Simone Rubino - Aion Tech
# Copyright 2025 Simone Rubino

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Come mai questi in un nuovo file? Sei partito da qualcosa di esistente?

@Borruso Borruso force-pushed the 18.0-imp-l10n_it_accompanying_invoice-dati_trasporto branch from c648697 to 53efef8 Compare February 15, 2026 10:21
@Borruso Borruso force-pushed the 18.0-imp-l10n_it_accompanying_invoice-dati_trasporto branch from 53efef8 to 7192ae0 Compare February 15, 2026 10:48
@tafaRU

tafaRU commented Jun 5, 2026

Copy link
Copy Markdown
Member

@monen17 @eLBati potreste aggiornare la vostra review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants