[18.0][IMP] l10n_it_edi_extension: add AltriDatiGestionali (2.2.1.16) export support for XML invoices by VBNext · Pull Request #5025 · OCA/l10n-italy

VBNext · 2025-12-05T14:38:27Z

Aggiunta nelle righe fattura di un campo per l'inserimento di altri dati gestionali

MaurizioPellegrinet

Test funzionale: OK

TheMule71 · 2025-12-12T10:03:24Z

+    on account.move.line records and exported into the FatturaPA XML.
+    """
+
+    _name = "l10n_it_edi.move.line.other.data"


fc571b2

aggiunge già l10n_it_edi.line_other_data

fc571b2

aggiunge già l10n_it_edi.line_other_data

Ho creato un nuovo modello collegato direttamente a account.move.line (NON a l10n_it_edi.line) perchè
l10n_it_edi.line_other_data viene utilizzato per VISUALIZZARE dati importati (readonly)
l10n_it_edi.move.line.other.data serve per INSERIRE dati da esportare (editabile)

OK, abbiamo detto di usare l10n_it_edi.line_other_data anche per l'esportazione

eLBati · 2026-02-12T14:04:58Z

+
+    _name = "l10n_it_edi.move.line.other.data"
+    _description = "Invoice Line Other Data for Export"
+    _rec_name = "display_name"


Visto che abbiamo già il campo name, come mai impostare display_name? Non rompe name_search() e name_get()?

name è soltanto il TipoDato e da quello non si capisce bene cosa rappresenti la riga

Per modificare cosa viene mostrato nei campi relazionali che fanno riferimento a questi record, si fa override di _compute_display_name.
Per modificare cosa viene ritornato dalla ricerca in questi campi relazionali, si fa override di name_search

_rec_name si usa tipicamente quando non c'è un campo name e si vuole usare un altro campo in sua vece

eLBati · 2026-02-12T14:09:12Z

+        <field name="arch" type="xml">
+            <list editable="bottom">
+                <field name="move_line_id" column_invisible="1" />
+                <field name="name" string="Tipo Dato" />


Qui come in altri punti: non mettiamo in inglese?

Rimosso string

eLBati · 2026-02-12T14:10:50Z

                <field name="l10n_it_edi_admin_ref" optional="hide" />
+                <field
+                    name="l10n_it_edi_other_data_ids"
+                    widget="many2many_tags"


Come mai many2many_tags? Gestisce correttamente la creazione/scrittura/eliminazione dei record?

è l'unico modo per visualizzare un one2many in un altro one2many ed è per questo che ho personalizzato il nome visualizzato, altrimenti non si sarebbero visti i dettagli della riga

non ho capito se funzionano creazione/scrittura/eliminazione

Forse il problema è collegato alla necessità di avere def action_delete?

non ho capito se funzionano creazione/scrittura/eliminazione

Probabilmente no:

The many2many_tags widget in Odoo 18 declares supportedTypes: ["many2many"] — it is explicitly designed only for Many2many fields.

Odoo's field registry does not enforce supportedTypes at runtime. So putting widget="many2many_tags" on a One2many field won't throw an error at load time. The tags may even render visually.

The Many2ManyTagsField component internally uses useX2ManyCrud() with fieldType: "many2many" hardcoded. Many2many and One2many have different CRUD semantics:

Many2many: link/unlink operations (commands (3, id) and (4, id))

One2many: create/delete operations (commands (0, 0, vals) and (2, id))

So operations like adding/removing tags will likely produce the wrong ORM commands, leading to silent data corruption or errors on save.

Prova ad aprire il runboat, ho aggiunto un bottoncino per permettere di aggiungere, modificare ed eliminare i record, il widget effettivamente serve solo per la visualizzazione

eLBati · 2026-02-12T14:11:38Z

+                    column_invisible="parent.country_code != 'IT'"
+                />
+                <button
+                    name="action_open_other_data"


Meglio renderlo eseguibile solo in bozza?

Va bene anche dopo la conferma, verifico che vengano riportati nell'xml anche se messi in fattura confermata

Allora almeno impedirlo per gli XML generati

Sì, ci sta

l'ho nascosto anche per in_invoice e in_refund

eLBati · 2026-02-12T14:12:59Z

+    @api.constrains("name")
+    def _check_name_length(self):
+        for record in self:
+            if record.name and len(record.name) > 10:


Non possiamo usare size=10 sul campo?

seguendo questo commento, verrà risolto: #5025 (comment)

eLBati · 2026-02-12T14:13:11Z

+    @api.constrains("text_ref")
+    def _check_text_ref_length(self):
+        for record in self:
+            if record.text_ref and len(record.text_ref) > 60:


Non possiamo usare size=60 sul campo?

seguendo questo commento, verrà risolto: #5025 (comment)

eLBati · 2026-02-24T14:17:11Z

+
    _name = "l10n_it_edi.line_other_data"
    _description = "E-invoice line other data"
+    _rec_name = "display_name"


Qui vedo sempre display_name (#5025 (comment))

eLBati · 2026-02-26T13:56:42Z

+        digits=(16, 8),
+        help="RiferimentoNumero: Numeric reference (up to 8 decimal places)",
+    )
+    date_ref = fields.Date(


Questo ha bisogno di script di upgrade immagino

Perchè ho tolto readonly?

Perchè passa da char a date

@odooNextev @eLBati #5157

eLBati · 2026-02-26T13:59:26Z

+                    column_invisible="parent.country_code != 'IT'"
+                />
+                <button
+                    name="action_open_other_data"


Allora almeno impedirlo per gli XML generati

eLBati · 2026-02-26T14:01:53Z

                <field name="l10n_it_edi_admin_ref" optional="hide" />
+                <field
+                    name="l10n_it_edi_other_data_ids"
+                    widget="many2many_tags"


Forse il problema è collegato alla necessità di avere def action_delete?

eLBati · 2026-02-26T14:06:28Z

                <field name="l10n_it_edi_admin_ref" optional="hide" />
+                <field
+                    name="l10n_it_edi_other_data_ids"
+                    widget="many2many_tags"


non ho capito se funzionano creazione/scrittura/eliminazione

Probabilmente no:

The many2many_tags widget in Odoo 18 declares supportedTypes: ["many2many"] — it is explicitly designed only for Many2many fields.

Odoo's field registry does not enforce supportedTypes at runtime. So putting widget="many2many_tags" on a One2many field won't throw an error at load time. The tags may even render visually.

The Many2ManyTagsField component internally uses useX2ManyCrud() with fieldType: "many2many" hardcoded. Many2many and One2many have different CRUD semantics:

Many2many: link/unlink operations (commands (3, id) and (4, id))

One2many: create/delete operations (commands (0, 0, vals) and (2, id))

So operations like adding/removing tags will likely produce the wrong ORM commands, leading to silent data corruption or errors on save.

…t support for XML invoices

andreampiovesana

LGTM

eLBati

Grazie

TheMule71

LGTM

OCA-git-bot · 2026-03-17T19:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

eLBati · 2026-03-18T10:08:50Z

/ocabot merge minor

OCA-git-bot · 2026-03-18T10:09:01Z

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-5025-by-eLBati-bump-minor, awaiting test results.

OCA-git-bot · 2026-03-18T10:28:23Z

Congratulations, your PR was merged at c7fc9ea. Thanks a lot for contributing to OCA. ❤️

stenext force-pushed the 18.0-imp-l10n_it_edi_extension-altridatigest branch from 48a416e to af47b34 Compare December 5, 2025 15:07

MaurizioPellegrinet approved these changes Dec 5, 2025

View reviewed changes

VBNext changed the title ~~[IMP] l10n_it_edi_extension: add AltriDatiGestionali (2.2.1.16) expor…~~ [IMP] l10n_it_edi_extension: add AltriDatiGestionali (2.2.1.16) export support for XML invoices Dec 5, 2025

stenext force-pushed the 18.0-imp-l10n_it_edi_extension-altridatigest branch from e76c7c6 to da099be Compare December 5, 2025 16:25

VBNext changed the title ~~[IMP] l10n_it_edi_extension: add AltriDatiGestionali (2.2.1.16) export support for XML invoices~~ [18.0][IMP] l10n_it_edi_extension: add AltriDatiGestionali (2.2.1.16) export support for XML invoices Dec 5, 2025

stenext force-pushed the 18.0-imp-l10n_it_edi_extension-altridatigest branch 2 times, most recently from 463c060 to d303351 Compare December 9, 2025 10:16

TheMule71 requested changes Dec 12, 2025

View reviewed changes

monen17 added the missing issue PRs must be linked to an issue. See the wiki. label Jan 9, 2026

riccardoFus approved these changes Feb 10, 2026

View reviewed changes

eLBati requested changes Feb 12, 2026

View reviewed changes

This was referenced Feb 13, 2026

[WIP] Run pre-commit hooks and squash commits in branch odooNextev/l10n-italy#14

Closed

[WIP] Run pre-commit hooks and squash all commits into one odooNextev/l10n-italy#15

Closed

odooNextev force-pushed the 18.0-imp-l10n_it_edi_extension-altridatigest branch from a491335 to e6ef3e3 Compare February 13, 2026 15:21

stenext force-pushed the 18.0-imp-l10n_it_edi_extension-altridatigest branch 5 times, most recently from de0e11b to 6c4905c Compare February 20, 2026 14:41

VBNext requested review from TheMule71 and eLBati February 20, 2026 15:04

eLBati requested changes Feb 24, 2026

View reviewed changes

stenext force-pushed the 18.0-imp-l10n_it_edi_extension-altridatigest branch 2 times, most recently from 97611eb to 8ed5d92 Compare February 26, 2026 11:10

eLBati requested changes Feb 26, 2026

View reviewed changes

stenext force-pushed the 18.0-imp-l10n_it_edi_extension-altridatigest branch 3 times, most recently from 5759ced to 72f3777 Compare February 26, 2026 17:04

[IMP] l10n_it_edi_extension: add AltriDatiGestionali (2.2.1.16) expor…

0ee8a1a

…t support for XML invoices

stenext force-pushed the 18.0-imp-l10n_it_edi_extension-altridatigest branch from 72f3777 to 0ee8a1a Compare March 13, 2026 11:14

andreampiovesana approved these changes Mar 13, 2026

View reviewed changes

VBNext requested a review from eLBati March 13, 2026 14:00

eLBati approved these changes Mar 16, 2026

View reviewed changes

TheMule71 approved these changes Mar 17, 2026

View reviewed changes

OCA-git-bot added approved ready to merge labels Mar 17, 2026

OCA-git-bot added the bot is merging ⏳ label Mar 18, 2026

OCA-git-bot merged commit 7137f1b into OCA:18.0 Mar 18, 2026
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Mar 18, 2026

francesco-ooops mentioned this pull request Mar 18, 2026

[19.0][MIG] l10n_it_edi_extension: Migration to 19.0 #5083

Open

HekkiMelody mentioned this pull request Mar 30, 2026

[18.0] Errore migrazione l10n_it_edi: l10n_it_edi_line_other_data #5157

Closed

1 task

Uh oh!

Conversation

VBNext commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MaurizioPellegrinet left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

VBNext Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

andreampiovesana left a comment

Choose a reason for hiding this comment

Uh oh!

eLBati left a comment

Choose a reason for hiding this comment

Uh oh!

VBNext commented Dec 5, 2025 •

edited

Loading

VBNext Dec 12, 2025 •

edited

Loading