[10.0] FIX l10n_it_ricevute_bancarie reconciliation by eLBati · Pull Request #507 · OCA/l10n-italy

eLBati · 2018-06-11T16:21:21Z

include accreditation move lines in reconciliation process

SimoRubi

Just code review.
Also check Travis

SimoRubi · 2018-06-12T08:18:48Z

+class AccountBankStatementLine(models.Model):
+    _inherit = 'account.bank.statement.line'
+
+    def get_move_lines_for_reconciliation(


Here (https://github.com/odoo/odoo/blob/9032617120138848c63b3cfa5d1913c5e5ad76db/addons/account/models/account_bank_statement.py#L546) it is api.multi, should keep the decorator

@SimoRubi you looked at the wrong method: https://github.com/odoo/odoo/blob/9032617120138848c63b3cfa5d1913c5e5ad76db/addons/account/models/account_bank_statement.py#L557

oh you are right, my bad

SimoRubi · 2018-06-12T08:23:23Z

 {
    'name': "Ricevute Bancarie",
-    'version': "10.0.1.1.0",
+    'version': "10.0.1.2.0",


If this is just a fix, increase version accordingly

it seems ok to me accordingly to https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#version-numbers, isn'it?

If this is just a fix, the new version should be 10.0.1.1.1

@SimoRubi
added a new field riba_accredited_ids and a new method. It's not just a few lines bugfix: I prefer to increase y

jackjack82 · 2018-06-12T09:05:27Z

@eLBati sicuro che serva questa modifica? ho appena scoperto che si può riconciliare una riga di estratto conto bancaria con una scrittura contabile già esistente. Questo un flusso di esempio:

creo fattura vendita verso cliente
dalla fattura clicco su "paga fattura" e creo il pagamento, la fattura è chiusa e riconciliata
creo nell'estratto conto bancario una riga di incasso dello stesso valore con lo stesso partner
clicco su "riconcilia" e vedo la scrittura contabile esistente in blu. clicco li sopra e su "valida" e la riga bancaria è riconciliata senza che sia creata una nuova scrittura.

immagino il sezionale della scrittura al punto 2 debba essere lo stesso della banca.

Giacomo

eLBati · 2018-06-12T09:57:59Z

@jackjack82 il flusso che descrivi è infatti quello usato per "riconciliare" le registrazioni di accredito riba con le righe dell'estratto conto. Operazione che nella maggior parte dei casi funziona già.
Se però, per qualche motivo, ad esempio se l'importo della riga di estratto conto che si vuole associare all'accredito riba combacia per importo con un'altra registrazione, in fase di riconciliazione odoo propone automaticamente di riconciliare la riga di estratto conto ad un altra move.line allora la move.line di accredito riba non è più selezionabile.
Questa modifica serve a poter deselezionare l'associazione proposta e selezionare la riga di accredito riba

Senza questa modifica la riga in blu non comparirebbe

eLBati · 2018-06-12T10:30:59Z

travis 💚

include accreditation and unsolved move lines in reconciliation process

eLBati · 2018-06-22T06:48:06Z

@jackjack82 ok per te?

jackjack82

@eLBati non chiarissimo ma testato e riesco a selezionare la riga riba da chiudere per riconciliazione. quindi ok.

jackjack82 · 2018-06-27T14:59:54Z

@eLBati fatti ancora un paio di test ed effettivamente senza questa modifica non vedo le righe riba. approvato.

include accreditation and unsolved move lines in reconciliation process

eLBati force-pushed the 10.0-fix-riba-reconciliation branch from 2be8ad8 to 5624b96 Compare June 11, 2018 16:34

SimoRubi suggested changes Jun 12, 2018

View reviewed changes

SimoRubi reviewed Jun 12, 2018

View reviewed changes

eLBati force-pushed the 10.0-fix-riba-reconciliation branch from 5624b96 to 055c55a Compare June 12, 2018 10:02

FIX l10n_it_ricevute_bancarie:

3bbe1f0

include accreditation and unsolved move lines in reconciliation process

eLBati force-pushed the 10.0-fix-riba-reconciliation branch from 055c55a to 3bbe1f0 Compare June 18, 2018 12:09

jackjack82 approved these changes Jun 27, 2018

View reviewed changes

eLBati merged commit 8e7a5d0 into OCA:10.0 Jul 3, 2018

eLBati mentioned this pull request Jul 3, 2018

[11.0][MIG] l10n it ricevute bancarie: Migration to 11.0 #526

Closed

robyf70 pushed a commit to LevelPrime/l10n-italy that referenced this pull request Jul 16, 2018

FIX l10n_it_ricevute_bancarie: (OCA#507)

b0f74c8

include accreditation and unsolved move lines in reconciliation process

SimoRubi pushed a commit to SimoRubi/l10n-italy that referenced this pull request Aug 7, 2019

FIX l10n_it_ricevute_bancarie: (OCA#507)

5db3d24

include accreditation and unsolved move lines in reconciliation process

tafaRU pushed a commit to tafaRU/l10n-italy that referenced this pull request Dec 20, 2019

FIX l10n_it_ricevute_bancarie: (OCA#507)

381c428

include accreditation and unsolved move lines in reconciliation process

tafaRU pushed a commit to tafaRU/l10n-italy that referenced this pull request Jan 3, 2020

FIX l10n_it_ricevute_bancarie: (OCA#507)

6f7d8bb

include accreditation and unsolved move lines in reconciliation process

Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request Feb 26, 2021

FIX l10n_it_ricevute_bancarie: (OCA#507)

32907b2

include accreditation and unsolved move lines in reconciliation process

Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request Apr 30, 2021

FIX l10n_it_ricevute_bancarie: (OCA#507)

1768037

include accreditation and unsolved move lines in reconciliation process

Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request May 6, 2021

FIX l10n_it_ricevute_bancarie: (OCA#507)

76d1734

include accreditation and unsolved move lines in reconciliation process

Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request May 21, 2021

FIX l10n_it_ricevute_bancarie: (OCA#507)

a9bac91

include accreditation and unsolved move lines in reconciliation process

Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request Jun 4, 2021

FIX l10n_it_ricevute_bancarie: (OCA#507)

b6ab51b

include accreditation and unsolved move lines in reconciliation process

TheMule71 pushed a commit to odoo-italia/l10n-italy that referenced this pull request Jun 6, 2021

FIX l10n_it_ricevute_bancarie: (OCA#507)

5f35922

include accreditation and unsolved move lines in reconciliation process

TheMule71 pushed a commit to odoo-italia/l10n-italy that referenced this pull request Jun 18, 2021

FIX l10n_it_ricevute_bancarie: (OCA#507)

832ccf6

include accreditation and unsolved move lines in reconciliation process

TheMule71 pushed a commit to odoo-italia/l10n-italy that referenced this pull request Jun 18, 2021

FIX l10n_it_ricevute_bancarie: (OCA#507)

49a40fb

include accreditation and unsolved move lines in reconciliation process

TheMule71 pushed a commit to odoo-italia/l10n-italy that referenced this pull request Jul 2, 2021

FIX l10n_it_ricevute_bancarie: (OCA#507)

42c9a5d

include accreditation and unsolved move lines in reconciliation process

TheMule71 pushed a commit to odoo-italia/l10n-italy that referenced this pull request Jul 2, 2021

FIX l10n_it_ricevute_bancarie: (OCA#507)

fcecb9d

include accreditation and unsolved move lines in reconciliation process

TheMule71 pushed a commit to odoo-italia/l10n-italy that referenced this pull request Jul 2, 2021

FIX l10n_it_ricevute_bancarie: (OCA#507)

dc0ee6c

include accreditation and unsolved move lines in reconciliation process

TheMule71 pushed a commit to odoo-italia/l10n-italy that referenced this pull request Jul 2, 2021

FIX l10n_it_ricevute_bancarie: (OCA#507)

4ff77ff

include accreditation and unsolved move lines in reconciliation process

TheMule71 pushed a commit to odoo-italia/l10n-italy that referenced this pull request Jul 30, 2021

FIX l10n_it_ricevute_bancarie: (OCA#507)

8a1f5b3

include accreditation and unsolved move lines in reconciliation process

TheMule71 pushed a commit to odoo-italia/l10n-italy that referenced this pull request Aug 6, 2021

FIX l10n_it_ricevute_bancarie: (OCA#507)

e290c21

include accreditation and unsolved move lines in reconciliation process

TheMule71 pushed a commit to odoo-italia/l10n-italy that referenced this pull request Aug 9, 2021

FIX l10n_it_ricevute_bancarie: (OCA#507)

082c11b

include accreditation and unsolved move lines in reconciliation process

TheMule71 pushed a commit to odoo-italia/l10n-italy that referenced this pull request Aug 20, 2021

FIX l10n_it_ricevute_bancarie: (OCA#507)

e5ff6ac

include accreditation and unsolved move lines in reconciliation process

TheMule71 pushed a commit to odoo-italia/l10n-italy that referenced this pull request Sep 3, 2021

FIX l10n_it_ricevute_bancarie: (OCA#507)

20d7be4

include accreditation and unsolved move lines in reconciliation process

TheMule71 pushed a commit to odoo-italia/l10n-italy that referenced this pull request Sep 17, 2021

FIX l10n_it_ricevute_bancarie: (OCA#507)

297f64e

include accreditation and unsolved move lines in reconciliation process

Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request Oct 1, 2021

FIX l10n_it_ricevute_bancarie: (OCA#507)

f42da59

include accreditation and unsolved move lines in reconciliation process

TheMule71 pushed a commit to odoo-italia/l10n-italy that referenced this pull request Oct 1, 2021

FIX l10n_it_ricevute_bancarie: (OCA#507)

1619fea

include accreditation and unsolved move lines in reconciliation process

TheMule71 pushed a commit to odoo-italia/l10n-italy that referenced this pull request Oct 8, 2021

FIX l10n_it_ricevute_bancarie: (OCA#507)

badeef0

include accreditation and unsolved move lines in reconciliation process

Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request Oct 15, 2021

FIX l10n_it_ricevute_bancarie: (OCA#507)

6c8d1cc

include accreditation and unsolved move lines in reconciliation process

TheMule71 pushed a commit to odoo-italia/l10n-italy that referenced this pull request Oct 15, 2021

FIX l10n_it_ricevute_bancarie: (OCA#507)

9547173

include accreditation and unsolved move lines in reconciliation process

TonyMasciI pushed a commit to saydigital/l10n-italy that referenced this pull request Jan 5, 2023

FIX l10n_it_ricevute_bancarie: (OCA#507)

1275015

include accreditation and unsolved move lines in reconciliation process

TonyMasciI pushed a commit to saydigital/l10n-italy that referenced this pull request Jan 9, 2023

FIX l10n_it_ricevute_bancarie: (OCA#507)

c601cef

include accreditation and unsolved move lines in reconciliation process

TonyMasciI pushed a commit to saydigital/l10n-italy that referenced this pull request Jan 13, 2023

FIX l10n_it_ricevute_bancarie: (OCA#507)

b2bca97

include accreditation and unsolved move lines in reconciliation process

TonyMasciI pushed a commit to saydigital/l10n-italy that referenced this pull request Jan 13, 2023

FIX l10n_it_ricevute_bancarie: (OCA#507)

dc22940

include accreditation and unsolved move lines in reconciliation process

TonyMasciI pushed a commit to saydigital/l10n-italy that referenced this pull request Jan 27, 2023

FIX l10n_it_ricevute_bancarie: (OCA#507)

fe14fc7

include accreditation and unsolved move lines in reconciliation process

TonyMasciI pushed a commit to saydigital/l10n-italy that referenced this pull request Jan 27, 2023

FIX l10n_it_ricevute_bancarie: (OCA#507)

4f89395

include accreditation and unsolved move lines in reconciliation process

TonyMasciI pushed a commit to saydigital/l10n-italy that referenced this pull request Mar 17, 2023

FIX l10n_it_ricevute_bancarie: (OCA#507)

c1deb06

include accreditation and unsolved move lines in reconciliation process

TheMule71 pushed a commit to TheMule71/l10n-italy that referenced this pull request Apr 20, 2023

FIX l10n_it_ricevute_bancarie: (OCA#507)

dfd9155

include accreditation and unsolved move lines in reconciliation process

TheMule71 pushed a commit to TheMule71/l10n-italy that referenced this pull request Apr 21, 2023

FIX l10n_it_ricevute_bancarie: (OCA#507)

5241523

include accreditation and unsolved move lines in reconciliation process

TonyMasciI pushed a commit to saydigital/l10n-italy that referenced this pull request Jun 22, 2023

FIX l10n_it_ricevute_bancarie: (OCA#507)

c93567b

include accreditation and unsolved move lines in reconciliation process

TheMule71 pushed a commit to TheMule71/l10n-italy that referenced this pull request Jun 23, 2023

FIX l10n_it_ricevute_bancarie: (OCA#507)

98da5fe

include accreditation and unsolved move lines in reconciliation process

Borruso pushed a commit to DinamicheAziendali/l10n-italy that referenced this pull request Jul 13, 2023

FIX l10n_it_ricevute_bancarie: (OCA#507)

f0b166d

include accreditation and unsolved move lines in reconciliation process

TonyMasciI pushed a commit to saydigital/l10n-italy that referenced this pull request Aug 4, 2023

FIX l10n_it_ricevute_bancarie: (OCA#507)

a38b320

include accreditation and unsolved move lines in reconciliation process

TonyMasciI pushed a commit to saydigital/l10n-italy that referenced this pull request Aug 4, 2023

FIX l10n_it_ricevute_bancarie: (OCA#507)

257fcf0

include accreditation and unsolved move lines in reconciliation process

TonyMasciI pushed a commit to saydigital/l10n-italy that referenced this pull request Sep 7, 2023

FIX l10n_it_ricevute_bancarie: (OCA#507)

d226690

include accreditation and unsolved move lines in reconciliation process

SirAionTech pushed a commit to SirAionTech/l10n-italy that referenced this pull request Sep 28, 2023

FIX l10n_it_ricevute_bancarie: (OCA#507)

23c5120

include accreditation and unsolved move lines in reconciliation process

SirAionTech pushed a commit to SirAionTech/l10n-italy that referenced this pull request Sep 28, 2023

FIX l10n_it_ricevute_bancarie: (OCA#507)

514f8ff

include accreditation and unsolved move lines in reconciliation process

salvorapi mentioned this pull request Jan 24, 2024

[16.0] l10n_it_riba: fix state update on riba lines #3885

Merged

TennyMkt pushed a commit to mktsrl/pr-l10n-italy that referenced this pull request May 10, 2024

FIX l10n_it_ricevute_bancarie: (OCA#507)

b83c993

include accreditation and unsolved move lines in reconciliation process

Uh oh!

Conversation

eLBati commented Jun 11, 2018

Uh oh!

SimoRubi left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SimoRubi Jun 12, 2018

Choose a reason for hiding this comment

Uh oh!

eLBati Jun 12, 2018

Choose a reason for hiding this comment

Uh oh!

SimoRubi Jun 12, 2018

Choose a reason for hiding this comment

Uh oh!

SimoRubi Jun 12, 2018

Choose a reason for hiding this comment

Uh oh!

tafaRU Jun 12, 2018

Choose a reason for hiding this comment

Uh oh!

SimoRubi Jun 12, 2018

Choose a reason for hiding this comment

Uh oh!

eLBati Jun 12, 2018

Choose a reason for hiding this comment

Uh oh!

jackjack82 commented Jun 12, 2018

Uh oh!

eLBati commented Jun 12, 2018

Uh oh!

eLBati commented Jun 12, 2018

Uh oh!

eLBati commented Jun 22, 2018

Uh oh!

jackjack82 left a comment

Choose a reason for hiding this comment

Uh oh!

jackjack82 commented Jun 27, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

SimoRubi left a comment •

edited

Loading