[18.0] porting l10n_it_fatturapa_pec > l10n_it_edi_pec by eLBati · Pull Request #5102 · OCA/l10n-italy

eLBati · 2026-02-09T14:40:16Z

No description provided.

monen17 · 2026-02-13T17:53:33Z

/ocabot migration l10n_it_fatturapa_pec

marcelofrare

testato funzionalmente la fattura passiva → LGTM
sulla fattura inviata, ho verificato che gestisce correttamente lo stato SDI → LGTM
mi manca testare l'invio, lo farò alla prima occasione.
Grazie!

MaurizioPellegrinet

Test funzionale:
provato invio fattura OK

OCA-git-bot · 2026-02-16T16:52:57Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

marcelofrare

verificato anche anche l'invio
Tutto ok!

andreampiovesana · 2026-02-18T13:27:15Z

@TheMule71 merge?

MaurizioPellegrinet

Vedo solo ora che eventuali righe inserite come note vengono rimosse dal file xml.
È possibile fare una modifica?

eLBati · 2026-02-19T16:45:13Z

Vedo solo ora che eventuali righe inserite come note vengono rimosse dal file xml. È possibile fare una modifica?

Questo non dovrebbe dipendere dal canale di comunicazione ma da l10n_it_edi ed eventuali estensioni

eLBati · 2026-03-04T09:59:48Z

@MaurizioPellegrinet per te OK procedere?

VBNext · 2026-03-07T22:29:36Z

Vedo solo ora che eventuali righe inserite come note vengono rimosse dal file xml. È possibile fare una modifica?

@MaurizioPellegrinet anche standard Odoo non riporta note nel xml, io approverei così questa PR ed eventualmente si fa la modifica con un altro modulo? che dici?

monen17

Manca una revisione del codice

monen17

Revisione del codice

monen17 · 2026-03-13T10:04:29Z

+        if not self.company_id.l10n_it_edi_use_pec:
+            return super()._l10n_it_edi_upload(files)
+
+        company = self.company_id


Per essere sicuri di usare sempre la stessa azienda (quella della registrazione)

Suggested change

if not self.company_id.l10n_it_edi_use_pec:

return super()._l10n_it_edi_upload(files)

company = self.company_id

company = self.company_id

if not company.l10n_it_edi_use_pec:

return super()._l10n_it_edi_upload(files)

company = self.company_id

Non ho capito, per gestire quale caso?

Il caso in cui uno sviluppatore sprovveduto decide di mettere un'altra azienda, tipo self.env.company, in una delle due occorrenze di self.company_id.

eLBati · 2026-03-17T13:59:41Z

@monen17 dovrei aver fatto tutto

monen17

Grazie mille delle modifiche, ora a livello di codice per me non c'è più niente di bloccante.

Ho guardato invece la storia dei commit e mancano gran parte dei commit di l10n_it_sdi_channel, li puoi includere? Così rimane traccia di come è cambiato il modulo.

Anche il commit di migrazione che ora include entrambi i moduli andrebbe separato:

prima il commit di migrazione della dipendenza l10n_it_sdi_channel -> l10n_it_edi_sdi
poi la migrazione di l10n_it_fatturapa_pec -> l10n_it_edi_pec.

Normalmente andrebbero in due PR separate, ma visto che abbiamo già iniziato a mettere tutto qui per me si può anche evitare di aprire un'altra PR.

Potresti anche rimuovere i commit dei bot come indicato in https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate ? Così magari riusciamo a ridurre un po' i 100-+ commit di questa PR.

monen17 · 2026-03-20T09:53:25Z

+        if not self.company_id.l10n_it_edi_use_pec:
+            return super()._l10n_it_edi_upload(files)
+
+        company = self.company_id


Il caso in cui uno sviluppatore sprovveduto decide di mettere un'altra azienda, tipo self.env.company, in una delle due occorrenze di self.company_id.

…edi_pec

…urapa_pec is installed

OCA-git-bot · 2026-06-03T13:56:15Z

Congratulations, PR rebased to 18.0.

tafaRU · 2026-06-05T15:16:02Z

deve essere mergiata contestualmente a #5203

tafaRU · 2026-06-05T15:29:54Z

/ocabot merge nobump

OCA-git-bot · 2026-06-05T15:30:05Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-5102-by-tafaRU-bump-nobump, awaiting test results.

OCA-git-bot · 2026-06-05T15:51:15Z

It looks like something changed on 18.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 18.0-ocabot-merge-pr-5102-by-tafaRU-bump-nobump, awaiting test results.

OCA-git-bot · 2026-06-05T16:12:34Z

It looks like something changed on 18.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 18.0-ocabot-merge-pr-5102-by-tafaRU-bump-nobump, awaiting test results.

OCA-git-bot · 2026-06-05T16:33:48Z

@tafaRU The merge process could not be finalized, because command twine upload --disable-progress-bar --non-interactive --repository-url https://upload.pypi.org/legacy/ -u __token__ odoo_addon_l10n_it_edi_pec-18.0.1.0.0.2-py3-none-any.whl failed with output:

Uploading distributions to https://upload.pypi.org/legacy/
Uploading odoo_addon_l10n_it_edi_pec-18.0.1.0.0.2-py3-none-any.whl
�[33mWARNING �[0m Error during upload. Retry with the --verbose option for more details. 
�[31mERROR   �[0m HTTPError: 429 Too Many Requests from https://upload.pypi.org/legacy/  
         Too Many Requests

tafaRU · 2026-06-08T07:04:19Z

/ocabot merge nobump

OCA-git-bot · 2026-06-08T07:04:28Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-5102-by-tafaRU-bump-nobump, awaiting test results.

OCA-git-bot · 2026-06-08T07:25:51Z

It looks like something changed on 18.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 18.0-ocabot-merge-pr-5102-by-tafaRU-bump-nobump, awaiting test results.

OCA-git-bot · 2026-06-08T07:47:10Z

@tafaRU The merge process could not be finalized, because command twine upload --disable-progress-bar --non-interactive --repository-url https://upload.pypi.org/legacy/ -u __token__ odoo_addon_l10n_it_edi_pec-18.0.1.0.0.2-py3-none-any.whl failed with output:

Uploading distributions to https://upload.pypi.org/legacy/
Uploading odoo_addon_l10n_it_edi_pec-18.0.1.0.0.2-py3-none-any.whl
�[33mWARNING �[0m Error during upload. Retry with the --verbose option for more details. 
�[31mERROR   �[0m HTTPError: 429 Too Many Requests from https://upload.pypi.org/legacy/  
         Too Many Requests

tafaRU · 2026-06-08T18:02:40Z

/ocabot merge nobump

OCA-git-bot · 2026-06-08T18:02:49Z

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-5102-by-tafaRU-bump-nobump, awaiting test results.

OCA-git-bot · 2026-06-08T18:25:40Z

Congratulations, your PR was merged at baf6a6e. Thanks a lot for contributing to OCA. ❤️

eLBati mentioned this pull request Feb 9, 2026

REF porting l10n_it_edi_pec #5096

Closed

eLBati force-pushed the 18.0-mig-l10n_it_fatturapa_pec branch 4 times, most recently from f078044 to 204db14 Compare February 12, 2026 17:48

OCA-git-bot added this to the 18.0 milestone Feb 13, 2026

OCA-git-bot mentioned this pull request Feb 13, 2026

Migration to version 18.0 #4392

Open

46 tasks

monen17 added the no issue needed label Feb 13, 2026

marcelofrare approved these changes Feb 13, 2026

View reviewed changes

MaurizioPellegrinet approved these changes Feb 16, 2026

View reviewed changes

OCA-git-bot added approved ready to merge labels Feb 16, 2026

marcelofrare approved these changes Feb 16, 2026

View reviewed changes

MaurizioPellegrinet suggested changes Feb 18, 2026

View reviewed changes

OCA-git-bot removed approved ready to merge labels Feb 18, 2026

monen17 requested changes Mar 13, 2026

View reviewed changes

eLBati force-pushed the 18.0-mig-l10n_it_fatturapa_pec branch 2 times, most recently from 5e02ae3 to ea2e51b Compare March 17, 2026 13:59

monen17 self-requested a review March 20, 2026 09:17

monen17 requested changes Mar 20, 2026

View reviewed changes

eLBati force-pushed the 18.0-mig-l10n_it_fatturapa_pec branch from ea2e51b to e82509f Compare March 25, 2026 16:27

eLBati added 2 commits June 3, 2026 13:56

[MIG] l10n_it_fatturapa_pec: Migration to 18.0 and rename to l10n_it_…

5804fae

…edi_pec

[IMP] l10n_it_account: auto install l10n_it_edi_pec when l10n_it_fatt…

3ae61f9

…urapa_pec is installed

OCA-git-bot force-pushed the 18.0-mig-l10n_it_fatturapa_pec branch from 1b54ba4 to 3ae61f9 Compare June 3, 2026 13:56

OCA-git-bot added series:18.0 mod:l10n_it_account Module l10n_it_account mod:l10n_it_edi_pec Module l10n_it_edi_pec mod:l10n_it_edi_sdi Module l10n_it_edi_sdi labels Jun 3, 2026

tafaRU added the required label Jun 5, 2026

OCA-git-bot added the bot is merging ⏳ label Jun 5, 2026

OCA-git-bot removed the bot is merging ⏳ label Jun 5, 2026

OCA-git-bot added the bot is merging ⏳ label Jun 8, 2026

OCA-git-bot removed the bot is merging ⏳ label Jun 8, 2026

OCA-git-bot added the bot is merging ⏳ label Jun 8, 2026

OCA-git-bot merged commit 2d1700e into OCA:18.0 Jun 8, 2026
3 of 5 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jun 8, 2026

Uh oh!

Conversation

eLBati commented Feb 9, 2026

Uh oh!

monen17 commented Feb 13, 2026

Uh oh!

marcelofrare left a comment

Choose a reason for hiding this comment

Uh oh!

MaurizioPellegrinet left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Feb 16, 2026

Uh oh!

marcelofrare left a comment

Choose a reason for hiding this comment

Uh oh!

andreampiovesana commented Feb 18, 2026

Uh oh!

MaurizioPellegrinet left a comment

Choose a reason for hiding this comment

Uh oh!

eLBati commented Feb 19, 2026

Uh oh!

eLBati commented Mar 4, 2026

Uh oh!

VBNext commented Mar 7, 2026

Uh oh!

monen17 left a comment

Choose a reason for hiding this comment

Uh oh!

monen17 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

monen17 Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

eLBati Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

monen17 Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eLBati commented Mar 17, 2026

Uh oh!

monen17 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

monen17 Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

OCA-git-bot commented Jun 3, 2026

Uh oh!

tafaRU commented Jun 5, 2026

Uh oh!

tafaRU commented Jun 5, 2026

Uh oh!

OCA-git-bot commented Jun 5, 2026

Uh oh!

OCA-git-bot commented Jun 5, 2026

Uh oh!

OCA-git-bot commented Jun 5, 2026