[18.0][ADD] l10n_it_delivery_note: mostrare i totali prezzi in DDT#5138
[18.0][ADD] l10n_it_delivery_note: mostrare i totali prezzi in DDT#5138quirino95 wants to merge 6 commits into
Conversation
|
Hi @aleuffre, @renda-dev, @MarcoCalcagni, |
quirino95
force-pushed
the
18.0-fix-4109
branch
4 times, most recently
from
50bb43d to
e0c0a39
Compare
|
This PR has the |
|
@MarcoCalcagni merge? |
SirPyTech
left a comment
SirPyTech
left a comment
There was a problem hiding this comment.
Grazie della PR!
Ho fatto solo revisione del codice e la maggior parte delle modifiche sono ok, però manca l'aggiunta dei totali delle imposte nel report, puoi verificare?
|  | ||
| - colonna Import sulle righe | ||
| - riquadro con la lista degli importi e somma del totale | ||
|
|
There was a problem hiding this comment.
polish: Questo non diventa davvero un elenco, guarda nel HTML:
Penso sia colpa degli spazi a inizio riga, che nel commit originale 0ba6bce non ci sono.
In un commit successivo comunque questa parte viene rimossa.
There was a problem hiding this comment.
Updated usage.md file without spaces so that original commit in 14.0 is restored eventhough it is removed later by other commit
There was a problem hiding this comment.
issue: Manca l'aggiunta delle imposte nel report che è il motivo per cui è stato fatto questo commit
[IMP] l10n_it_delivery_note: add untaxed amount in report
Nel commit originale 10c64a1 c'è.
There was a problem hiding this comment.
Yes, it was missed from the original commit which has to be available for including taxes related info in the report.
There was a problem hiding this comment.
Including this change, introduces tax amount related information in the report:
| def test_partner_shipping_delivering_single_so(self): | ||
| # ⇒ "Ordine singolo: consegna a indirizzo diverso" | ||
| self._test_partners() | ||
| # ⇒ "Ordine singolo: consegna a indirizzo di consegna e fatturazione diversi" | ||
| self._test_partners(test_invoice_partner=True) | ||
|
|
||
| def _test_partners(self, test_invoice_partner=False): |
There was a problem hiding this comment.
chore: Questi test non ci sono nel commit originale 10c64a1, se vuoi aggiungerli ben venga ma andrebbero in un commit a parte.
There was a problem hiding this comment.
This is the original commit 414f5ab which introduces these testcases in 14.0. However, it has not been port forward to 16.0 as part of #4562 but just included testcases alone in a wrong commit which is not appropriate. In 18.0, either we can port forward 14.0 original commit which introduce testcase or just remove the testcase from wrong commit.
I have removed the testcase from the commit add untaxed amount in report for now. If require we can port forward this commit 414f5ab. Please let me know your views.
| user = new_test_user( | ||
| self.env, | ||
| login="test", | ||
| groups="stock.group_stock_manager", |
There was a problem hiding this comment.
note: Nel commit originale 10c64a1 c'era anche il gruppo per le funzionalità avanzate, ma se non serve per me va bene rimuoverlo, così usiamo i diritti minimi per far passare il test
There was a problem hiding this comment.
Yes, original commit has advanced DN groups in the testcase. As in 18.0 this group is not available, it is not used as part of this testcase.
OCA-git-bot
added
mod:l10n_it_delivery_note
10 participants
Forward port of #4089 #4112
Fixes: #4109