Skip to content

[14.0] [FIX] l10n_it_split_payment: avoid to duplicate tax line and its account refund line #5215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
patrickt-oforce wants to merge 1 commit into
base: 14.0
Choose a base branch
from
Open

[14.0] [FIX] l10n_it_split_payment: avoid to duplicate tax line and its account refund line #5215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions l10n_it_split_payment/models/account.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,15 @@ def _compute_amount(self):
move.amount_sp = move.amount_tax
move.amount_tax = 0.0
move.amount_total = move.amount_untaxed
move._compute_split_payments()
# Because method _compute_amount is called many times, need to
# call method to compute split payment data only when the
# account move has a line which belong to split payment tax,
# otherwise the tax and refund line are duplicated
move_has_split_line = move.line_ids.filtered(
lambda aml: aml.tax_repartition_line_id.tax_id.is_split_payment
)
if move_has_split_line:
move._compute_split_payments()
else:
move.amount_sp = 0.0

Expand Down Expand Up @@ -158,7 +166,7 @@ def _compute_split_payments(self):
else:
self.set_receivable_line_ids()
if self.amount_sp:
self.invoice_line_ids = [(0, 0, write_off_line_vals)]
self.line_ids = [(0, 0, write_off_line_vals)]


class AccountMoveLine(models.Model):
Expand Down
Loading
⚡