Skip to content

[11.0][MIG] l10n it reverse charge: Migration to 11.0#531

Closed
jackjack82 wants to merge 15 commits into
OCA:11.0from
jackjack82:11.0-mig-l10n_it_reverse_charge
Closed

[11.0][MIG] l10n it reverse charge: Migration to 11.0#531
jackjack82 wants to merge 15 commits into
OCA:11.0from
jackjack82:11.0-mig-l10n_it_reverse_charge

Conversation

@jackjack82

Copy link
Copy Markdown
Member

No description provided.

@pedrobaeza pedrobaeza mentioned this pull request Jun 30, 2018
35 tasks
@jackjack82 jackjack82 force-pushed the 11.0-mig-l10n_it_reverse_charge branch 2 times, most recently from 8d9fcc0 to f562a62 Compare July 2, 2018 10:06
@jackjack82

Copy link
Copy Markdown
Member Author

@eLBati metodo "_get_company_partner" rinominato in "_compute_company_partner" per verifiche LINT. il campo è calcolato non storato, non dovrebbe dare problemi. Modifica in models.account_invoice.py righe 45 e 53

@eLBati

eLBati commented Jul 6, 2018

Copy link
Copy Markdown
Member

@jackjack82 controlla travis plis

@jackjack82 jackjack82 force-pushed the 11.0-mig-l10n_it_reverse_charge branch from f562a62 to 6bace74 Compare July 6, 2018 10:42
@jackjack82

jackjack82 commented Jul 6, 2018

Copy link
Copy Markdown
Member Author

@eLBati travis ok. why is cl/runbot still giving error "2018-07-06 10:56:03,562 166 WARNING openerp_test odoo.addons.base.ir.ir_ui_view: Error-prone use of @Class in view res.partner.pec.kanban (): use the hasclass(*classes) function to filter elements by their classes" if https://github.com/OCA/l10n-italy/pull/533/files is merged?

@eLBati

eLBati commented Jul 6, 2018

Copy link
Copy Markdown
Member

@jackjack82 I see commits that should not be here, like 84fa8b3 and 3c54d88
as already contained in 11.0
Did you add them to your branch instead of rebasing on top of 11.0?

Davide Corio and others added 15 commits July 6, 2018 17:28
[IMP] pep8

[FIX] typos and pep8

[IMP] l10n_it_reverse_charge refactoring

[ADD] account_move_skip

[IMP] skip expr

[IMP] i18n

[IMP] tax mapping

[IMP] mandatory fields

[IMP] autohide if == 0

[REM] pdb

[IMP] no need to specify expr

[FIX] write if no credit/debit
[ADD] l10n_it_reverse_charge: add initial draft of README

[ADD] l10n_it_reverse_charge: add note about 'Integrazione IVA'

[ADD] l10n_it_reverse_charge: add check if there is default credit account defined on Self Invoice Payment Journal

[ADD] l10n_it_reverse_charge: set rc on invoice.line according to RC Type defined on fiscal position

[FIX] l10n_it_reverse_charge: rename tax_src_id and tax_dest_id fields to be more consinstent and easier to understand their purpose

[IMP] l10n_it_reverse_charge: adapt to latest OCA guidelines

[FIX] l10n_it_reverse_charge: fix 'WARNING test_reverse_charge openerp.modules.loading: The model account.rc.type has no access rules'

[ADD] l10n_it_reverse_charge
Handle invoice supplier cancellation and reopening for method 'selfinvoice':
* cancellation: both supplier invoice and selfinvoice are cancelled
* reopening: data on existing selfinvoice are copied to supplier invoice

[FIX] l10n_it_reverse_charge: fix WARNING account.invoice.line.create() with unknown fields: uom_id

[IMP] l10n_it_reverse_charge: improve README

[IMP] l10n_it_reverse_charge: add more comments for making code easier to understand

[IMP] l10n_it_reverse_charge: add help to tax_ids field

[FIX] l10n_it_reverse_charge:
* do not copy rc_self_invoice_id
* check if inv has rc_self_invoice_id before to proceed with its cancellation

[FIX] l10n_it_reverse_charge: avoid product from self invoice lines to better handle related stats

[ADD] 8.0-l10n_it_reverse_charge: copy self_invoice_text to self invoice name
[W7910(wrong-tabs-instead-of-spaces), ]  Use wrong tabs indentation instead of four spaces

FIX screenshots

FIX allow to use and compute RC field in invoice line form pop up
to enable the creation of an additional supplier self
invoice. This is tipically used for extraUE suppliers,
in order to show, in supplier register, an invoice to the
specified partner (tipically, my company), instead of the
extraUE partner

Also FIX
ValueError: "local variable 'tax_code_id' referenced before assignment" while evaluating
u'invoice_validate()'
when tax mapping not found
FIX invoice_line_tax_ids field
…nvoice_draft due to odoo/odoo@bc8d5db (OCA#433)

In this way both invoices are again set as draft.
…module l10n_it_vat_registries_reverse_charge, in new PR), add link in purchase invoice to payment move

port PR 522 and 432 to 11.0 (NOT included  module l10n_it_vat_registries_reverse_charge, in new PR)

add link in purchase invoice to payment move
@jackjack82 jackjack82 force-pushed the 11.0-mig-l10n_it_reverse_charge branch from 13a162e to aaf4d6b Compare July 6, 2018 15:28

@SimoRubi SimoRubi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'website': 'https://www.odoo-italia.net',
'depends': [
'account_accountant',
# 'account_menu_group',

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why commenting a dependency? Keep it or remove it

comodel_name='account.invoice',
string='RC Self Purchase Invoice', copy=False, readonly=True)

rc_partner_supplier_id = fields.Many2one(

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is new functionality, please implement new functionalities out of the migration commit, thanks

* Davide Corio
* Alex Comba <alex.comba@agilebg.com>
* Lorenzo Battistini <lorenzo.battistini@agilebg.com
* Lorenzo Battistini <lorenzo.battistini@agilebg.com>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can autogenerate a much nicer README using this script

@eLBati

eLBati commented Jul 24, 2018

Copy link
Copy Markdown
Member

@jackjack82 please consider including #559

@eLBati eLBati added needs fixing Has conflicts or is failing mandatory CI checks and removed 11.0 labels Aug 28, 2018
@eLBati eLBati added this to the 11.0 milestone Aug 28, 2018
@alessandrocamilli

Copy link
Copy Markdown
Contributor

@eLBati possiamo passare a #658 ? e chiudere questa PR?

@eLBati

eLBati commented Nov 13, 2018

Copy link
Copy Markdown
Member

👍

@eLBati eLBati closed this Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs fixing Has conflicts or is failing mandatory CI checks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants