[11.0][MIG] account vat period end statement (final version) by jackjack82 · Pull Request #555 · OCA/l10n-italy

jackjack82 · 2018-07-18T06:19:34Z

No description provided.

SimoRubi

Just code review, mostly non-blocking comments

SimoRubi · 2018-07-20T11:07:03Z

        'Interest - Percent', default=_get_default_interest_percent)
    fiscal_page_base = fields.Integer(
        'Last printed page', required=True, default=0)
+    fiscal_year = fields.Char(


Here you are adding a new functionality, I suggest you do this in a separate commit

SimoRubi · 2018-07-20T11:14:32Z

 * Alex Comba <alex.comba@agilebg.com>
 * Alessandro Camilli <camillialex@gmail.com>
 * Simone Rubino <simone.rubino@agilebg.com>
+* Giacomo Grasso <giacomo.grasso.82@gmail.com>


You can autogenerate a nice README using this script

SimoRubi · 2018-07-20T11:25:25Z

@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 #


Please fix copyrights following the format defined in the template module: generic in __init__ files, with authors elsewhere (xml files too)

SimoRubi · 2018-07-20T11:34:03Z

            if statement.move_id.exists():
                for line in statement.move_id.line_ids:
-                    payment_lines.extend(filter(None, [
+                    payment_lines.extend([_f for _f in [


Maybe it can be more clear to simply wrap filter in list: list(filter(...)), but that's ok too

It's the command 2to3 -wnj4 --no-diffs . that convert the line

[FIX] period vat move set equal to date vat period statement [FIX] code for 7.0 [FIX] other code for 7.0 [FIX] other code for 7.0 [FIX] copyright

[FIX] in fase di liquidazione iva, quando vado a ricercare i periodi per la liquidazione, questi sono visualizzati solo dall'utente Admin. L'utente "normale" anche se ha diritti di administratore non visualizza i periodi

…y is missing "from openerp.osv import orm"

[FIX] liquidazione IVA - impossibile salvare una nuova liquidazione [REF] Set all the modules of the master branches to "installable": False moves all modules into a __unported__ directory

Update code using by 'git checkout origin/7.0 -- account_vat_period_end_statement' Replace OpenERP Italia by Odoo Italia in all header files Update copyright year for agilebg Extract the description in README.rst Improve the manifest file: change version, add OCA as author, remove deprecated key as active Add OCA icon Fix 'ImportError: No module named tools.translate' Fix 'ImportError: No module named decimal_precision' Fix 'ImportError: No module named report' Add group tags to show up the missing labels

[FIX] typos

…thub.com/alessandrocamilli/test [IMP] PEP8 and copyright [IMP] translation

…ollo tipo conto imposta credit/debit

[ADD] missing translatable terms

fix Travis << fix line too long Vat registries: - add last printed page - tax registries, add type layout - add flag print only totals Vat end period statment: - link header to l10n_it_account - print payment information l10n_it_account: - change header and footer

FIX avoid breaking inheritance of report.minimal_layout IMP README with images IMP translations

fix author description

PEP8 README CamelCase ADD test VAT statement creation

OCA Transbot updated translations from Transifex

remove active_id and correct number revision Fix selection of interest in vat statement

OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex

…d of account_invoice_sequential_dates Refactoring for variables name to be more clear

OCA Transbot updated translations from Transifex

…at.period.end.statement account_vat_period_end_statement: change module version and add post-migration script to copy company from periods

ADD postgresql: "9.2" minimal postgresql version for the daterange method account_vat_period_end_statement ADD description on statement.generic.account.line

ADD interessi dovuti e modifica del loro calcolo

ValueError: Expected singleton: account.vat.period.end.statement(1, 2, 4, 6, 7, 8, 9, 10, 12, 13, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27)

…ing account.period (with vat statement) to date.range (OCA#408)

… integrazione iva (OCA#379) fix imponibile imposta figlia con integrazione iva

…stance in the migration script (OCA#411)

…mpany compliant (OCA#428) [FIX] account_vat_period_end_statement: check move_id exists to get statement_draft properly working (OCA#435) move_id needs to be checked if exists in the computed fields, otherwise the method unlink, during the fields recomputation, raises a MissingError for them [FIX] account_vat_period_end_statement: post move + cancel move (OCA#436)

…te.range and date.range.type Otherwise a user who belongs to adviser group cannot add a date.range to vat statement

In cases like today, feb 28, no date range is found

[FIX] README format issues (OCA#501)

sergiocorato · 2019-01-16T07:45:14Z

@jackjack82 puoi fare un rebase per risolvere i conflitti sulle dipendenze che sono state aggiunte nel frattempo nel file oca_dependencies.txt?

eLBati · 2019-02-05T10:32:22Z

@labaggio sei interessata a portare avanti questa PR?

labaggio · 2019-02-05T10:48:36Z

@labaggio sei interessata a portare avanti questa PR?

@eLBati mi stai sfruttando ahahahah cerco di infilarlo nei prossimi giorni.. ma arrivati ad un certo numero di porting vinco qualcosa? :)

eLBati · 2019-02-05T11:51:48Z

Ricchi premi!

labaggio · 2019-02-11T19:24:08Z

Ricchi premi!
@eLBati
#996 fatta, vediamo come vanno i controlli :)

eLBati · 2019-02-12T09:07:51Z

Chiudo allora questa

jackjack82 mentioned this pull request Jul 18, 2018

[11.0][MIG] account vat period end statement: : Migration to 11.0 #524

Closed

SimoRubi reviewed Jul 20, 2018

View reviewed changes

eLBati added this to the 11.0 milestone Aug 28, 2018

eLBati added the needs fixing Has conflicts or is failing mandatory CI checks label Aug 28, 2018

jackjack82 force-pushed the 11.0-mig-account_vat_period_end_statement_DEF branch from 2895a5c to 915b6fd Compare October 4, 2018 20:07

sergiocorato and others added 25 commits October 5, 2018 11:09

[ADD] account_vat_period_end_statement - works as is

e3f1d95

[FIX] period vat move set equal to date vat period statement [FIX] code for 7.0 [FIX] other code for 7.0 [FIX] other code for 7.0 [FIX] copyright

[FIX] authors and description

502b083

[imp] field help

297ea8a

[FIX] in fase di liquidazione iva, quando vado a ricercare i periodi per la liquidazione, questi sono visualizzati solo dall'utente Admin. L'utente "normale" anche se ha diritti di administratore non visualizza i periodi

in account_vat_period_end_statement/report/vat_period_end_statement.p…

9fe96ae

…y is missing "from openerp.osv import orm"

[imp] description

ea839a3

[FIX] liquidazione IVA - impossibile salvare una nuova liquidazione [REF] Set all the modules of the master branches to "installable": False moves all modules into a __unported__ directory

[IMP] move vat_statement_type to l10n_it_account

e510cf7

[FIX] typos

[ADD] porting account_vat_period_end_statement_report from https://gi…

7ca404b

…thub.com/alessandrocamilli/test [IMP] PEP8 and copyright [IMP] translation

fix calcolo totali iva stampa registri, fix stampa liquidazione contr…

ffa6efa

…ollo tipo conto imposta credit/debit

[FIX] report translation

d34abd8

[ADD] missing translatable terms

FIX dependency and versions

11f600a

FIX avoid breaking inheritance of report.minimal_layout IMP README with images IMP translations

Add last printed page and interest managment.

91abf02

fix author description

FIX old import

fed90ba

PEP8 README CamelCase ADD test VAT statement creation

OCA Transbot updated translations from Transifex

5b92f20

[MIG] Make modules uninstallable

718d67b

[FIX] remove en.po that was erroneously created by transbot

7167a76

[MIG] Rename manifest files

1f0d5df

OCA Transbot updated translations from Transifex

1bd6468

OCA Transbot updated translations from Transifex

account vat period end statement set interest flag manually

451229b

remove active_id and correct number revision Fix selection of interest in vat statement

OCA Transbot updated translations from Transifex

3374292

remove trailing withespaces

845320f

OCA Transbot updated translations from Transifex

113f956

OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex

Solve problem with tests of account_vat_period_end_statement after ad…

3524623

…d of account_invoice_sequential_dates Refactoring for variables name to be more clear

OCA Transbot updated translations from Transifex

3748e9a

OCA Transbot updated translations from Transifex

tafaRU and others added 19 commits October 5, 2018 11:10

account_vat_period_end_statement: add multicompany rule for account.v…

5631eb3

…at.period.end.statement account_vat_period_end_statement: change module version and add post-migration script to copy company from periods

OCA Transbot updated translations from Transifex

90d4a1b

porting account_vat_period_end_statement to 10

2cfcd73

ADD postgresql: "9.2" minimal postgresql version for the daterange method account_vat_period_end_statement ADD description on statement.generic.account.line

OCA Transbot updated translations from Transifex

ffa0d22

account_vat_period_end_statement ADD crediti d'imposta

62b43d5

ADD interessi dovuti e modifica del loro calcolo

FIX

7cabaf5

ValueError: Expected singleton: account.vat.period.end.statement(1, 2, 4, 6, 7, 8, 9, 10, 12, 13, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27)

[ADD] account_vat_period_end_statement: add migration script for copy…

b899cb9

…ing account.period (with vat statement) to date.range (OCA#408)

[FIX][10]: correzione calcolo liquidazione iva in caso di fatture con…

8b323b4

… integrazione iva (OCA#379) fix imponibile imposta figlia con integrazione iva

[FIX] account_vat_period_end_statement: check account_peiod table exi…

f49fef6

…stance in the migration script (OCA#411)

modificate traduzioni nella stampa della liquidazione (OCA#413)

e85434e

OCA Transbot updated translations from Transifex

1bf0969

OCA Transbot updated translations from Transifex

d005411

[IMP] account_vat_period_end_statement: allow to adviser to manage da…

4e95f43

…te.range and date.range.type Otherwise a user who belongs to adviser group cannot add a date.range to vat statement

[FIX] Move menu related to date range to l10n_it_account module

a053417

FIX account_vat_period_end_statement tests (OCA#459)

c6ffd53

In cases like today, feb 28, no date range is found

[FIX] account_vat_period_end_statement README description (OCA#477)

5ce600a

[FIX] README format issues (OCA#501)

[UPD] Update account_vat_period_end_statement.pot

3a4ac2b

[11][MIG] Migrating account vat statement to 11

640d9bd

eLBati force-pushed the 11.0-mig-account_vat_period_end_statement_DEF branch from 915b6fd to 640d9bd Compare October 5, 2018 09:10

eLBati approved these changes Oct 5, 2018

View reviewed changes

labaggio approved these changes Jan 16, 2019

View reviewed changes

labaggio mentioned this pull request Feb 11, 2019

[11.0] [MIG] account vat period end statement #996

Merged

eLBati closed this Feb 12, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[11.0][MIG] account vat period end statement (final version)#555

[11.0][MIG] account vat period end statement (final version)#555
jackjack82 wants to merge 44 commits into
OCA:11.0from
jackjack82:11.0-mig-account_vat_period_end_statement_DEF

jackjack82 commented Jul 18, 2018

Uh oh!

SimoRubi left a comment

Uh oh!

SimoRubi Jul 20, 2018

Uh oh!

SimoRubi Jul 20, 2018

Uh oh!

SimoRubi Jul 20, 2018

Uh oh!

SimoRubi Jul 20, 2018

Uh oh!

labaggio Feb 11, 2019 •

edited

Loading

Uh oh!

sergiocorato commented Jan 16, 2019

Uh oh!

eLBati commented Feb 5, 2019

Uh oh!

labaggio commented Feb 5, 2019

Uh oh!

eLBati commented Feb 5, 2019

Uh oh!

labaggio commented Feb 11, 2019

Uh oh!

eLBati commented Feb 12, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

Uh oh!

Conversation

jackjack82 commented Jul 18, 2018

Uh oh!

SimoRubi left a comment

Choose a reason for hiding this comment

Uh oh!

SimoRubi Jul 20, 2018

Choose a reason for hiding this comment

Uh oh!

SimoRubi Jul 20, 2018

Choose a reason for hiding this comment

Uh oh!

SimoRubi Jul 20, 2018

Choose a reason for hiding this comment

Uh oh!

SimoRubi Jul 20, 2018

Choose a reason for hiding this comment

Uh oh!

labaggio Feb 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sergiocorato commented Jan 16, 2019

Uh oh!

eLBati commented Feb 5, 2019

Uh oh!

labaggio commented Feb 5, 2019

Uh oh!

eLBati commented Feb 5, 2019

Uh oh!

labaggio commented Feb 11, 2019

Uh oh!

eLBati commented Feb 12, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

labaggio Feb 11, 2019 •

edited

Loading