11.0 mig l10n it ricevute bancarie rt by ruben-tonetto · Pull Request #680 · OCA/l10n-italy

ruben-tonetto · 2018-11-28T06:48:03Z

No description provided.

oca-clabot · 2018-11-28T06:48:05Z

Hey @ruben-tonetto, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

@nicothebrush (login unknown in OCA database)

Appreciation of efforts,
OCA CLAbot

eLBati · 2018-12-07T09:03:03Z

@ruben-tonetto vedo conflitti su oca_dependencies.txt. Dovresti fare rebase sul branch 11.0 aggiornato

ruben-tonetto · 2018-12-09T18:22:23Z

Ho fatto

eLBati · 2018-12-12T09:53:21Z

@ruben-tonetto controlla travis per favore

ruben-tonetto · 2018-12-12T21:51:03Z

Le correzioni flake sono a posto; ci sono 2 errori che non so sistemare:

no module named odoo.report
https://github.com/ruben-tonetto/l10n-italy/blob/d9c32e3519e1f63205b26bfe4ecd68b8a08ddf01/l10n_it_ricevute_bancarie/tests/test_riba.py#L8
variabile file non definita
https://github.com/ruben-tonetto/l10n-italy/blob/d9c32e3519e1f63205b26bfe4ecd68b8a08ddf01/l10n_it_ricevute_bancarie/tests/test_riba.py#L124

eLBati · 2018-12-13T13:44:35Z

Flake8 dice ancora l10n_it_ricevute_bancarie/tests/test_riba.py:124:13: F821 undefined name 'file'

I test invece falliscono per

File "/home/travis/build/OCA/l10n-italy/l10n_it_ricevute_bancarie/tests/test_riba.py", line 8, in <module>
from odoo.report import render_report
ImportError: No module named 'odoo.report'

Dovresti provare ad eseguire i test in locale
https://www.odoo.com/documentation/11.0/reference/testing.html

I test vanno eseguiti su DB con dati demo.
Puoi anche guardare come fa travis, cioè

/home/travis/OCB-11.0/odoo-bin -d openerp_template --log-level=info --stop-after-init --init website_mail,bus,date_range,website,website_form,http_routing,sale_stock,product,sale_management,base_vat,account_invoicing,analytic,base_setup,website_sale,sale,stock,rating,web_planner,account,stock_picking_package_preparation_line,sale_payment,web_tour,mail,sales_team,website_rating,account_fiscal_year,payment,account_group_menu,web,base_iban,portal,barcodes,base,stock_account,web_editor,decimal_precision,stock_picking_package_preparation,website_payment

per creare il DB e

/home/travis/OCB-11.0/odoo-bin -d openerp_test --db-filter=^openerp_test$ --stop-after-init --log-level info --log-handler openerp.tools.yaml_import:DEBUG --test-enable --init l10n_it_abicab,l10n_it_account,l10n_it_account_tax_kind,l10n_it_causali_pagamento,l10n_it_codici_carica,l10n_it_corrispettivi,l10n_it_corrispettivi_sale,l10n_it_ddt,l10n_it_esigibilita_iva,l10n_it_fiscal_document_type,l10n_it_fiscal_payment_term,l10n_it_fiscalcode,l10n_it_ipa,l10n_it_pec,l10n_it_rea,l10n_it_ricevute_bancarie,l10n_it_split_payment,l10n_it_website_sale_corrispettivi,l10n_it_withholding_tax,l10n_it_withholding_tax_causali,l10n_it_withholding_tax_payment

per testare i moduli

ruben-tonetto · 2018-12-13T22:27:54Z

Flake8 è passato.

ho creato l'ambiente di test per l'errore ModuleNotFoundError: No module named 'odoo.report' ma mi si ripresenta (in from odoo.report import render_report)

dove si trova ora questo modulo nella 11?

labaggio · 2019-01-23T10:00:37Z

Flake8 è passato.

ho creato l'ambiente di test per l'errore ModuleNotFoundError: No module named 'odoo.report' ma mi si ripresenta (in from odoo.report import render_report)

dove si trova ora questo modulo nella 11?

hai seguito queste specifiche ? https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-11.0

C'è una parte dedicata ai cambiamenti dei report.
Sto provando ad utilizzarlo e le stampe si rompono.

ruben-tonetto · 2019-01-24T06:54:00Z

@labaggio grazie del suggerimento.
Ho apportato le modifiche, ma devo controllare.
Se puoi verifica come girano le stampe

labaggio · 2019-01-24T17:55:45Z

@labaggio grazie del suggerimento.
Ho apportato le modifiche, ma devo controllare.
Se puoi verifica come girano le stampe

@ruben-tonetto Non funziona..
Pensi di riuscire a sistemare il modulo in tempi brevi?
Se non riesci avvisa che lo prendo in carico.
Se provi a stampare una distinta esce questo errore:
AttributeError: 'report.l10n_it_ricevute_bancarie.distinta_qweb' object has no attribute 'get_report_values'

ruben-tonetto · 2019-01-24T21:02:09Z

@labaggio ho sistemato il report e ho fatto la stampa, funziona

labaggio · 2019-02-12T08:54:37Z

@labaggio ho sistemato il report e ho fatto la stampa, funziona

@ruben-tonetto Per me va bene, manca solo di raggruppare i commit per autore, così poi riusciamo a farla mergiare, giusto @eLBati? :)
https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests

moving from https://code.launchpad.net/~openobject-italia-core-devs/openobject-italia/l10n_it_ricevute_bancarie

…_jasper

Changes for 6.0 should be done in a branch for 6.0. For the reason to use 'fields.date' instead of 'time', see https://bugs.launchpad.net/openobject-server/+bug/925361 https://bugs.launchpad.net/openerp-web/+bug/918257

…ect-italia/adding_riba_v7/+merge/194620/comments/449412

and valueerror

…A#321)

after odoo/odoo@efa4f85 otherwise: 2017-05-20 03:21:02,605 6389 ERROR openerp_test odoo.addons.l10n_it_ricevute_bancarie.tests.test_riba: ERROR: test_delete_due_cost_line (odoo.addons.l10n_it_ricevute_bancarie.tests.test_riba.TestInvoiceDueCost) 2017-05-20 03:21:02,605 6389 ERROR openerp_test odoo.addons.l10n_it_ricevute_bancarie.tests.test_riba: Traceback (most recent call last): 2017-05-20 03:21:02,605 6389 ERROR openerp_test odoo.addons.l10n_it_ricevute_bancarie.tests.test_riba: ` File "/home/travis/build/OCA/l10n-italy/l10n_it_ricevute_bancarie/tests/test_riba.py", line 205, in test_delete_due_cost_line 2017-05-20 03:21:02,605 6389 ERROR openerp_test odoo.addons.l10n_it_ricevute_bancarie.tests.test_riba: ` self.invoice.action_invoice_draft() 2017-05-20 03:21:02,606 6389 ERROR openerp_test odoo.addons.l10n_it_ricevute_bancarie.tests.test_riba: ` File "/home/travis/build/OCA/l10n-italy/l10n_it_ricevute_bancarie/models/account/account.py", line 213, in action_invoice_draft 2017-05-20 03:21:02,606 6389 ERROR openerp_test odoo.addons.l10n_it_ricevute_bancarie.tests.test_riba: ` line.unlink() 2017-05-20 03:21:02,606 6389 ERROR openerp_test odoo.addons.l10n_it_ricevute_bancarie.tests.test_riba: ` File "/home/travis/odoo-10.0/addons/account/models/account_invoice.py", line 1360, in unlink 2017-05-20 03:21:02,606 6389 ERROR openerp_test odoo.addons.l10n_it_ricevute_bancarie.tests.test_riba: ` raise UserError(_('You can only delete an invoice line if the invoice is in draft state.')) 2017-05-20 03:21:02,606 6389 ERROR openerp_test odoo.addons.l10n_it_ricevute_bancarie.tests.test_riba: ` UserError: (u'You can only delete an invoice line if the invoice is in draft state.', None)

File "odoo/lib/python2.7/site-packages/odoo/models.py", line 4369, in <lambda> @api.returns('self', lambda value: value.id) AttributeError: 'NoneType' object has no attribute 'id' while duplicating

…on riba line, and button 'Settle all' that allow to settle all the riba lines that are in state 'Accredited' (OCA#359)

…y in riba.configuration (OCA#438)

…zione, viene usato sempre lo stesso conto. (OCA#472) Allora per la riconciliazione prendiamo comunque la riga che ci interessa, quella con 'debit'

)

…form view 2) autopost settle and unsolved moves 3) bank expenses in move only if existing, does not make sense to have 0 value accounting lines (OCA#484)

prevent to use a bank accoun tfor "Ri.Ba. bank account", otherwise, if a bank account is used, its move lines will appear as blu lines in bank statement reconciliation

[FIX] file() to open() in test_riba [FIX] distinta_qweb report [FIX] odoo.report.render_report deprecated in test_riba.py

dcorio

Ci sono errori sul form del partner, vedi commenti

dcorio · 2019-03-06T15:48:19Z

+        <field name="inherit_id" ref="base.view_partner_form"/>
+        <field name="groups_id" eval="[(4, ref('account.group_account_user'))]"/>
+        <field name="arch" type="xml">
+            <field name="property_payment_term_id" position="after">


questo separatore ed il gruppo rompono la vista, facendo sparire tutte le label ai campi.
oltretutto il campo property_payment_term_id non deriva dal modulo base, ma dal modulo account

@ruben-tonetto puoi sistemare questa cosa?

@labaggio purtroppo mi serve parecchio tempo per sistemarlo; meglio che ti passo il modulo se tu riesci a completarlo in tempi brevi

Ho fatto un PR sul tuo repo, devi solo fare il merge
lbaggio#2

SimoRubi · 2019-08-16T11:29:59Z

@dcorio puoi aggiornare la tua review dopo gli ultimi cambiamenti?

eLBati · 2019-08-31T09:32:44Z

@dcorio @alessandrocamilli voi lo usate in produzione?

warp10 · 2020-10-12T10:35:21Z

@dcorio @alessandrocamilli voi lo usate in produzione?

Rispondo con giusto un lieve ritardo: sì, è in uso sui clienti 11 da un annetto abbondante ormai

rcerrillo2 · 2021-05-24T16:25:55Z

+        'account.invoice', 'invoice_unsolved_line_rel', 'line_id',
+        'invoice_id', 'Unsolved Invoices')
+    iban = fields.Char(
+        related='partner_id.bank_ids.acc_number', string='IBAN', store=False)


Non so se questo PR e ancora attivo. In ogni caso, il cliente può avere vari conti bancari, se in uno ha un mandato anullato, il related non lo sa e mete un iban non valido.

Non so se questo PR e ancora attivo. In ogni caso, il cliente può avere vari conti bancari, se in uno ha un mandato anullato, il related non lo sa e mete un iban non valido.

Grazie. Sai se il problema è anche sulla 12?

Forse no, il iban si ottiene di un altro modo, ma sembra anche di ottenere il primo conto che trova senza vedere il mandato. Ma come ho detto non sono sicuro, non ho una 12 per provare adesso.

github-actions · 2021-10-24T12:26:24Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

eLBati mentioned this pull request Nov 28, 2018

[11.0][MIG] l10n it ricevute bancarie: Migration to 11.0 #526

Closed

ruben-tonetto force-pushed the 11.0-mig-l10n_it_ricevute_bancarie-rt branch from d3972a1 to db954de Compare December 9, 2018 18:06

ruben-tonetto force-pushed the 11.0-mig-l10n_it_ricevute_bancarie-rt branch from db954de to d9c32e3 Compare December 12, 2018 21:42

ruben-tonetto force-pushed the 11.0-mig-l10n_it_ricevute_bancarie-rt branch 2 times, most recently from a4b9c19 to 859cf56 Compare January 24, 2019 20:50

labaggio approved these changes Feb 5, 2019

View reviewed changes

eLBati and others added 11 commits February 23, 2019 09:58

[ADD] l10n_it_ricevute_bancarie

80fa5fc

moving from https://code.launchpad.net/~openobject-italia-core-devs/openobject-italia/l10n_it_ricevute_bancarie

[IMP] l10n_it_ricevute_bancarie splitted in l10n_it_ricevute_bancarie…

136db9e

…_jasper

[FIX] classe riba_distinta_move_line e context_today sconosciuto in 6\.0

8a1f266

[FIX] Reverted to previous revision.

2c1b84d

Changes for 6.0 should be done in a branch for 6.0. For the reason to use 'fields.date' instead of 'time', see https://bugs.launchpad.net/openobject-server/+bug/925361 https://bugs.launchpad.net/openerp-web/+bug/918257

[FIX] removing useless rows

5c969cf

[IMP] copyright

0dbe393

[REM] l10n_it_ricevute_bancarie*

69c8a4a

[ADD] riba v7

ad9cea0

Inserito fix richiesto da eLBati

de79bb5

[FIX] https://code.launchpad.net/~openobject-italia-core-devs/openobj…

90ab2e7

…ect-italia/adding_riba_v7/+merge/194620/comments/449412

[FIX] AttributeError: 'cursor' object has no attribute 'pool'

294fbf4

and valueerror

ruben-tonetto force-pushed the 11.0-mig-l10n_it_ricevute_bancarie-rt branch from 859cf56 to 2caa4ba Compare February 23, 2019 09:03

scigghia and others added 19 commits February 28, 2019 20:13

[8.0] evita di riaprire fattura se presente una ricevuta bancaria (OC…

fba95d0

…A#321)

OCA Transbot updated translations from Transifex

a57d274

OCA Transbot updated translations from Transifex

71ff6e1

FIX l10n_it_ricevute_bancarie

b35a914

File "odoo/lib/python2.7/site-packages/odoo/models.py", line 4369, in <lambda> @api.returns('self', lambda value: value.id) AttributeError: 'NoneType' object has no attribute 'id' while duplicating

[ADD] added automatic settlemet of riba lines, using fa-check button …

02f0ad5

…on riba line, and button 'Settle all' that allow to settle all the riba lines that are in state 'Accredited' (OCA#359)

OCA Transbot updated translations from Transifex

c58e94c

[FIX] l10n_it_ricevute_bancarie: only show bank related to the compan…

946a10d

…y in riba.configuration (OCA#438)

FIX l10n_it_ricevute_bancarie quando , nella registrazione di accetta…

c006ad8

…zione, viene usato sempre lo stesso conto. (OCA#472) Allora per la riconciliazione prendiamo comunque la riga che ci interessa, quella con 'debit'

IMP l10n_it_ricevute_bancarie README (OCA#478)

2708e79

[10.0][FIX][riba] Fix when moving to draft state all riba lines (OCA#467

a52a4fd

)

IMP l10n_it_riba_commission tests (OCA#486)

5ee2c84

l10n_it_ricevute_bancarie - Small improvements: 1) created riba line …

8600ce7

…form view 2) autopost settle and unsolved moves 3) bank expenses in move only if existing, does not make sense to have 0 value accounting lines (OCA#484)

[10.0] fix riba invoice date string (OCA#480)

9dbd870

IMP l10n_it_ricevute_bancarie (OCA#498)

a3a8570

prevent to use a bank accoun tfor "Ri.Ba. bank account", otherwise, if a bank account is used, its move lines will appear as blu lines in bank statement reconciliation

OCA Transbot updated translations from Transifex

1b1d610

[UPD] Update l10n_it_ricevute_bancarie.pot

4840bd2

[11.0] migation module ricevute bancarie to 11, includes PR 507

e659160

[FIX] params in get_move_lines_for_reconciliation()

40b8549

[FIX] file() to open() in test_riba [FIX] distinta_qweb report [FIX] odoo.report.render_report deprecated in test_riba.py

ruben-tonetto force-pushed the 11.0-mig-l10n_it_ricevute_bancarie-rt branch from 2caa4ba to 40b8549 Compare March 2, 2019 18:11

dcorio suggested changes Mar 6, 2019

View reviewed changes

OCA-git-bot removed the approved label Mar 6, 2019

corretta visualizzazione label in partner (#2)

a5cea98

rcerrillo2 reviewed May 24, 2021

View reviewed changes

github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 24, 2021

github-actions Bot closed this Nov 28, 2021

Uh oh!

Conversation

ruben-tonetto commented Nov 28, 2018

Uh oh!

oca-clabot commented Nov 28, 2018

Uh oh!

eLBati commented Dec 7, 2018

Uh oh!

ruben-tonetto commented Dec 9, 2018

Uh oh!

eLBati commented Dec 12, 2018

Uh oh!

ruben-tonetto commented Dec 12, 2018

Uh oh!

eLBati commented Dec 13, 2018

Uh oh!

ruben-tonetto commented Dec 13, 2018

Uh oh!

labaggio commented Jan 23, 2019

Uh oh!

ruben-tonetto commented Jan 24, 2019

Uh oh!

labaggio commented Jan 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ruben-tonetto commented Jan 24, 2019

Uh oh!

labaggio commented Feb 12, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dcorio left a comment

Choose a reason for hiding this comment

Uh oh!

dcorio Mar 6, 2019

Choose a reason for hiding this comment

Uh oh!

labaggio Jul 11, 2019

Choose a reason for hiding this comment

Uh oh!

ruben-tonetto Jul 20, 2019

Choose a reason for hiding this comment

Uh oh!

labaggio Jul 24, 2019

Choose a reason for hiding this comment

Uh oh!

SimoRubi commented Aug 16, 2019

Uh oh!

eLBati commented Aug 31, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

warp10 commented Oct 12, 2020

Uh oh!

rcerrillo2 May 24, 2021

Choose a reason for hiding this comment

Uh oh!

eLBati Jun 3, 2021

Choose a reason for hiding this comment

Uh oh!

rcerrillo2 Jun 3, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Oct 24, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

labaggio commented Jan 24, 2019 •

edited

Loading

labaggio commented Feb 12, 2019 •

edited

Loading

eLBati commented Aug 31, 2019 •

edited

Loading