Skip to content

[18.0][MIG] partner_multi_relation_archive_propagate#2364

Merged
OCA-git-bot merged 7 commits into
OCA:18.0from
Therp:18.0-mig-partner_multi_relation_archive_propagate
Jun 14, 2026
Merged

[18.0][MIG] partner_multi_relation_archive_propagate#2364
OCA-git-bot merged 7 commits into
OCA:18.0from
Therp:18.0-mig-partner_multi_relation_archive_propagate

Conversation

@ntsirintanis

Copy link
Copy Markdown
Contributor

Migration from 16.0. Depends on #2361

@OCA-git-bot OCA-git-bot added series:18.0 mod:partner_archive_propagate Module partner_archive_propagate mod:partner_multi_relation_archive_propagate Module partner_multi_relation_archive_propagate labels May 26, 2026
@ntsirintanis ntsirintanis force-pushed the 18.0-mig-partner_multi_relation_archive_propagate branch 2 times, most recently from 252ba5c to ce790cf Compare May 26, 2026 13:07

@Kiplangatdan Kiplangatdan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ntsirintanis PR contains changes on the partner_archive_propagate.

Is the last commit needed?

@BhaveshHeliconia BhaveshHeliconia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I've figured out a issue

  • Steps to reproduce:

    • Create two contacts contact1 and contact2
    • Create one relation for this two contacts with Propagate archive true in relation type
    • Go to contact1 form and click Archive Contact and Children button
    • Remove contact2 from wizard lines
    • Click on 'Archive' button
    • Observe that contact2 is also archived

@ntsirintanis

Copy link
Copy Markdown
Contributor Author
  • I've figured out a issue

    • Steps to reproduce:

      • Create two contacts contact1 and contact2
      • Create one relation for this two contacts with Propagate archive true in relation type
      • Go to contact1 form and click Archive Contact and Children button
      • Remove contact2 from wizard lines
      • Click on 'Archive' button
      • Observe that contact2 is also archived

Thank you very much @BhaveshHeliconia . A fix is underway for this

@ntsirintanis ntsirintanis force-pushed the 18.0-mig-partner_multi_relation_archive_propagate branch 2 times, most recently from b4f38eb to 5776e0f Compare June 8, 2026 11:06
@ntsirintanis ntsirintanis force-pushed the 18.0-mig-partner_multi_relation_archive_propagate branch from f6f345c to 9c1c5bd Compare June 8, 2026 12:24
@OCA-git-bot OCA-git-bot removed the mod:partner_archive_propagate Module partner_archive_propagate label Jun 8, 2026

@NL66278 NL66278 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@NL66278

NL66278 commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

@Kiplangatdan @BhaveshHeliconia Could you both have another look? Would be great to merge this!

@BhaveshHeliconia BhaveshHeliconia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@NL66278

NL66278 commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

/ocabot merge nobump

@OCA-git-bot

Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-2364-by-NL66278-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 6ca37aa into OCA:18.0 Jun 14, 2026
7 checks passed
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 19f4ddf. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants