Skip to content

[Snyk] Security upgrade MailKit from 4.6.0 to 4.15.1#5364

Open
tidusjar wants to merge 24 commits into
developfrom
snyk-fix-4e078b14febf89ab911aca25dc622fed
Open

[Snyk] Security upgrade MailKit from 4.6.0 to 4.15.1#5364
tidusjar wants to merge 24 commits into
developfrom
snyk-fix-4e078b14febf89ab911aca25dc622fed

Conversation

@tidusjar

Copy link
Copy Markdown
Member

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the nuget dependencies of this project.

Snyk changed the following file(s):

  • src/Ombi.Notifications/Ombi.Notifications.csproj

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity CRLF Injection
SNYK-DOTNET-MIMEKIT-15468175
  738  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 CRLF Injection

claude and others added 24 commits March 23, 2026 23:15
Rewrites the Dockerfile to be fully self-contained by adding an Angular
UI build stage (Node 20) alongside the .NET publish stage, removing the
broken dependency on pre-built ClientApp dist from the host context.

Adds a new `docker` job to the CI build workflow that builds multi-arch
images (amd64, arm64, arm/v7) and publishes them to GitHub Container
Registry (ghcr.io). Images are tagged with the version number, plus
`latest` for master builds and `develop` for develop builds.

https://claude.ai/code/session_01KDhvnvXoLLSq4krH3n2SVe
workflow_dispatch can run on arbitrary branches, so unconditionally
pushing would publish unreviewed images to GHCR. Now the image is only
pushed when running on master or develop.

https://claude.ai/code/session_01KDhvnvXoLLSq4krH3n2SVe
…-AxIAV

feat: add Docker image publishing to CI pipeline
The .NET 8 jammy base images (sdk:8.0-jammy, aspnet:8.0-jammy) only
support linux/amd64 and linux/arm64. The linux/arm/v7 platform caused
buildx to fail immediately when resolving base images.

https://claude.ai/code/session_01KDhvnvXoLLSq4krH3n2SVe
The old individual API projects (Ombi.Api.CloudService, Ombi.Api.Discord,
Ombi.Api.Plex, etc.) were consolidated into Ombi.Api.External, but the
Dockerfile still referenced the old directories. Docker COPY fails when
source files don't exist in the build context, causing immediate build
failure.

Updated to match the current solution structure with 15 projects.

https://claude.ai/code/session_01KDhvnvXoLLSq4krH3n2SVe
The Angular production build tries to fetch and inline Google Fonts
(Material Icons) at build time. This fails inside Docker containers
that have no network access to fonts.googleapis.com, breaking the
Docker image build.

Disable font optimization while keeping script and style optimization
enabled.

https://claude.ai/code/session_01KDhvnvXoLLSq4krH3n2SVe
@coderabbitai

coderabbitai Bot commented Mar 27, 2026

Copy link
Copy Markdown

Important

Review skipped

Ignore keyword(s) in the title.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 36d576d9-d258-4548-9131-55fafa214f36

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch snyk-fix-4e078b14febf89ab911aca25dc622fed

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tidusjar

Copy link
Copy Markdown
Member Author

⚠️ Snyk checks are incomplete.

Status Scan Engine Critical High Medium Low Total (0)
⚠️ Open Source Security 0 0 0 0 See details

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@sonarqubecloud

Copy link
Copy Markdown

@cypress

cypress Bot commented Mar 27, 2026

Copy link
Copy Markdown

Ombi Automation    Run #2625

Run Properties:  status check failed Failed #2625  •  git commit 74a7b9d197 ℹ️: Merge 227e5198c37f7ed65d369ad2f3dd83347b06c445 into 922598b562ec89f7b087bf3450f7...
Project Ombi Automation
Branch Review snyk-fix-4e078b14febf89ab911aca25dc622fed
Run status status check failed Failed #2625
Run duration 05m 58s
Commit git commit 74a7b9d197 ℹ️: Merge 227e5198c37f7ed65d369ad2f3dd83347b06c445 into 922598b562ec89f7b087bf3450f7...
Committer Jamie Rees
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 4
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 102
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/tests/discover/discover-cards-requests.spec.ts • 1 failed test

View Output

Test Artifacts
Discover Cards Requests Tests > Not requested movie allows non-admin to request Test Replay Screenshots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants