[Snyk] Fix for 3 vulnerabilities#5365
Open
tidusjar wants to merge 24 commits into
Open
Conversation
Rewrites the Dockerfile to be fully self-contained by adding an Angular UI build stage (Node 20) alongside the .NET publish stage, removing the broken dependency on pre-built ClientApp dist from the host context. Adds a new `docker` job to the CI build workflow that builds multi-arch images (amd64, arm64, arm/v7) and publishes them to GitHub Container Registry (ghcr.io). Images are tagged with the version number, plus `latest` for master builds and `develop` for develop builds. https://claude.ai/code/session_01KDhvnvXoLLSq4krH3n2SVe
The v2 action uses a deprecated Node.js runtime. https://claude.ai/code/session_01KDhvnvXoLLSq4krH3n2SVe
workflow_dispatch can run on arbitrary branches, so unconditionally pushing would publish unreviewed images to GHCR. Now the image is only pushed when running on master or develop. https://claude.ai/code/session_01KDhvnvXoLLSq4krH3n2SVe
…-AxIAV feat: add Docker image publishing to CI pipeline
The .NET 8 jammy base images (sdk:8.0-jammy, aspnet:8.0-jammy) only support linux/amd64 and linux/arm64. The linux/arm/v7 platform caused buildx to fail immediately when resolving base images. https://claude.ai/code/session_01KDhvnvXoLLSq4krH3n2SVe
The old individual API projects (Ombi.Api.CloudService, Ombi.Api.Discord, Ombi.Api.Plex, etc.) were consolidated into Ombi.Api.External, but the Dockerfile still referenced the old directories. Docker COPY fails when source files don't exist in the build context, causing immediate build failure. Updated to match the current solution structure with 15 projects. https://claude.ai/code/session_01KDhvnvXoLLSq4krH3n2SVe
The Angular production build tries to fetch and inline Google Fonts (Material Icons) at build time. This fails inside Docker containers that have no network access to fonts.googleapis.com, breaking the Docker image build. Disable font optimization while keeping script and style optimization enabled. https://claude.ai/code/session_01KDhvnvXoLLSq4krH3n2SVe
…plate-logo-to-the-site-logo
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-DOTNET-AUTOMAPPER-15602868 - https://snyk.io/vuln/SNYK-DOTNET-SYSTEMTEXTJSON-7433719 - https://snyk.io/vuln/SNYK-DOTNET-SYSTEMTEXTJSON-8168848
|
Important Review skippedIgnore keyword(s) in the title. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Member
Author
|
| Status | Scan Engine |  Critical |
 High |
 Medium |
 Low |
Total (0) |
|---|---|---|---|---|---|---|
| Open Source Security | 0 | 0 | 0 | 0 | See details |
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Snyk has created this PR to fix 3 vulnerabilities in the nuget dependencies of this project.
Snyk changed the following file(s):
src/Ombi.Core/Ombi.Core.csprojVulnerabilities that will be fixed with an upgrade:
SNYK-DOTNET-AUTOMAPPER-15602868
SNYK-DOTNET-SYSTEMTEXTJSON-7433719
SNYK-DOTNET-SYSTEMTEXTJSON-8168848
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Denial of Service (DoS)