Fix camera angle(omega,phi,kappa) calculation#1977
Closed
originlake wants to merge 1 commit intoOpenDroneMap:masterfrom
Closed
Fix camera angle(omega,phi,kappa) calculation#1977originlake wants to merge 1 commit intoOpenDroneMap:masterfrom
originlake wants to merge 1 commit intoOpenDroneMap:masterfrom
Conversation
|
Hi, Thank you for pushing this ! Maybe it will be better to merge my OpenSfM fork (or cherry pick relevant commits), so that the fixes is directly in OpenSfM. Cheers, Yann |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be a bug in camera angle calculation, leading to bad performance in triangulation reconstruction method.
The issue is discussed here. I'm not 100% sure if the fix meets the goal of the original design, but at least the fix would make it mathematically correct. Wish to get some input for this.
mapillary/OpenSfM#1098