Conversation
The pandas series comparison needed a correction.
…form/open-MaStR into feature-272-restructuring
Renaming of functions and variables to increase clarity. Additionally changed folder structure.
sessions.py contained data information. This information is also in orm.py and should be received from there.
The download_power_plants function does not work anymore, but it is also never called so we did not notice.
This function can be used both in backfill_basics and backfill_location_basics.
Minor changes.
New functions were introduced to make the function retrieve_additional_data better readable.
Decreasing Size and complexity of the function.
Put methods that are accessed from outside the class as first methods.
Additional other minor changes.
New unit test for _additional_data_from_basic_unit method. Applied black.
Member
Author
|
Probably code can be refactored even more, but other features are waiting for this branch to be merged so we should not delay the merging too much. |
…to feature-272-restructuring Solve Merge conflicts
The import statements were automatically changed, which introduced an error.
deniztepe
approved these changes
Jul 8, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch does not change any functionality. Its purpose is refactoring and restructuring.